From: Noam Postavsky <npostavs@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: master 305dbc7 2/4: Move description of value to syntax-ppss function.
Date: Sat, 15 Feb 2020 09:55:36 -0500 [thread overview]
Message-ID: <CAM-tV-8C_MFDKBxErPVw+_+J3LSzqKTMQxdMXkVHsnLa=DdVvg@mail.gmail.com> (raw)
In-Reply-To: <7fbe5ad6-2ea6-5a5d-d77e-6df2ba143eb4@yandex.ru>
On Fri, 13 Dec 2019 at 08:03, Dmitry Gutov <dgutov@yandex.ru> wrote:
>> - (innermost-start
>> + (list-start
>
> Sounds ambiguous: the point is that it's innermost, among possible other
> list starts.
>> - (last-complete-sexp-start
>> + (last-sexp-start
>
> Same (but, like, in reverse): "complete" is important.
Not sure I agree, but I can live with the current names.
> > - (comment-nesting nil :documentation "\
> > + (comment nil :documentation "\
>
> Doesn't this name imply some other value? Like a string (comment opener
> or its contents)?
Hmm, you might be right about that. How about 'comment-depth': two
characters shorter, and the other names also use "depth" rather than
"nesting".
> > - (comment-or-string-start
> > + (context-start
> > nil :documentation
> > "character address of start of comment or string; nil if not in one.")
>
> That kind of implies that strings and comments are the most important
> contexts when parsing a file.
Yeah, I think was I looking at syntax-ppss-context when I originally
wrote this, but in that case there is an argument to tell what
"context" refers to, so I agree it doesn't really make sense here.
> > - (open-paren-positions
> > + (open-parens
> > nil :documentation
> > "List of positions of currently open parens, outermost first.")
> > - (two-character-syntax nil :documentation "\
> > + (syntax-sequence nil :documentation "\
> > When the last position scanned holds the first character of a
> > (potential) two character construct, the syntax of that position,
> > otherwise nil. That construct can be a two character comment
>
> These look okay to me.
I'm actually feeling that the two-character-syntax one should be left
as is, it's kind of obscure so having a longer and more explicit name
seems better.
> min-depth too, but, like last-complete-sexp-start, these fields in
> values returned by syntax-ppss are unreliable/undefined, so they won't
> be used in most Lisp programs anyway.
I might be biased by having worked on the lisp indentation code which
uses those fields quite a bit.
next prev parent reply other threads:[~2020-02-15 14:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191030121649.15369.13207@vcs0.savannah.gnu.org>
[not found] ` <20191030121651.BFCF8204DF@vcs0.savannah.gnu.org>
2019-10-30 14:59 ` master 305dbc7 2/4: Move description of value to syntax-ppss function Dmitry Gutov
2019-10-30 15:03 ` Lars Ingebrigtsen
2019-10-30 15:13 ` Dmitry Gutov
2019-10-30 15:22 ` Lars Ingebrigtsen
2019-10-30 15:26 ` Dmitry Gutov
2019-10-30 15:30 ` Lars Ingebrigtsen
2019-10-30 15:29 ` Lars Ingebrigtsen
2019-10-30 16:13 ` Dmitry Gutov
2019-10-30 16:17 ` Lars Ingebrigtsen
2019-10-30 16:47 ` Dmitry Gutov
2019-10-30 17:03 ` Lars Ingebrigtsen
2019-10-30 19:39 ` Stefan Monnier
2019-10-30 20:28 ` Lars Ingebrigtsen
2019-12-13 12:34 ` Noam Postavsky
2019-12-13 13:03 ` Dmitry Gutov
2019-12-17 16:28 ` Lars Ingebrigtsen
2020-02-15 14:55 ` Noam Postavsky [this message]
2020-02-15 15:14 ` Dmitry Gutov
2020-02-15 16:23 ` Noam Postavsky
2020-02-23 14:11 ` Noam Postavsky
2019-10-30 20:34 ` Alan Mackenzie
2019-10-30 20:41 ` Dmitry Gutov
2019-10-31 1:45 ` Stefan Monnier
2019-10-31 14:06 ` Lars Ingebrigtsen
2019-10-30 20:47 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM-tV-8C_MFDKBxErPVw+_+J3LSzqKTMQxdMXkVHsnLa=DdVvg@mail.gmail.com' \
--to=npostavs@gmail.com \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).