From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Fri, 27 Jan 2017 22:46:22 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485575195 32059 195.159.176.226 (28 Jan 2017 03:46:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 03:46:35 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 04:46:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXJyA-0007fb-IR for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 04:46:30 +0100 Original-Received: from localhost ([::1]:49817 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXJyC-0000l6-VK for ged-emacs-devel@m.gmane.org; Fri, 27 Jan 2017 22:46:32 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXJy5-0000kp-V8 for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:46:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXJy5-00027A-9A for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:46:25 -0500 Original-Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:35294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXJy5-00026z-4B for emacs-devel@gnu.org; Fri, 27 Jan 2017 22:46:25 -0500 Original-Received: by mail-oi0-x234.google.com with SMTP id j15so168221378oih.2 for ; Fri, 27 Jan 2017 19:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=L8TLe3yDTZikmzTKCC1Hig6t6HnfL7QMWHqFnU6+jmg=; b=kiozwxTvEGpuvheany0IrkOUGxmXnRSUDFqvzNbr5X5Dnn+gzG/8LJwBp+0Q5Ihttq gn7adFWsJrWdJTVOtOgmxgzuKMSvW9c7ARtMQAwemz/lg165C+RkGsF5NBvgIXw8w9O4 ZDbJ6+hwoDBFvqhosVB5ku8RzAYDFoKWdlltldu+Rg6sQDtF2efJaCtyxr1auOcRkG8Y ga0K/0pd74K8ZhJL5WCsOakp2seKhMhdrfcYE39Ux8SeD1QgFdpWSKdosldbfKGaOJ4M 2UWQ3ELWp7gc8UTBffBDsOA8eRCd13F5EODtK7ZR0JdEbUH4YRzxzwncwRt6ud11ue+L 45Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=L8TLe3yDTZikmzTKCC1Hig6t6HnfL7QMWHqFnU6+jmg=; b=jJyWUAxKh4M8tEiHVYSsnC22+9SBBqeYeRBptloRuiSja/ZY5Fm0a+FdlvbQGLC65n 6EHnKL0yNYwIkK9lgEhA6waqiqh+aMAskCRxYz5hGbj61VvY9HpbTDzYnQJfAQZb1Hpw m9PZNsnO1SyqQ/YVRnu127HhWPOyd8iPnI+t7RuNiZGEcBO9zeccYYfbvFZuAdYPVyBv vqsucKH0S+bIJ0KcAgQFf/OuLIG2RDvvPtNSdL6oJuoX8qzV6pirtFeEFu0exBgdf3Vj yZaOlAuv/Zb6ximZu3wfO9E+vSySXpWV6N2/7LmeLx1m4y/J1hyaCOTxmpMuiKQ7qxQX 7zYQ== X-Gm-Message-State: AIkVDXI2lNhcw26KAot2OSEjq7DSLhnB3QxKuGFaOaymNv0Y8beMmZXtvPLL4LC6a1Rpauul7nobDM4jfvp86w== X-Received: by 10.202.172.136 with SMTP id v130mr6928700oie.167.1485575182901; Fri, 27 Jan 2017 19:46:22 -0800 (PST) Original-Received: by 10.157.21.117 with HTTP; Fri, 27 Jan 2017 19:46:22 -0800 (PST) In-Reply-To: <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> X-Google-Sender-Auth: feOaxQeM2Sy1duR3SQGRNTv_8mk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211670 Archived-At: On Fri, Jan 27, 2017 at 10:30 PM, Cl=C3=A9ment Pit--Claudel wrote: > On 2017-01-27 20:59, Noam Postavsky wrote: >> I guess let-binding `debugger' to a function which performs the >> logging should do the trick? > > I already do that, in fact, and I do re-throw the exception from there. = Looks like things didn't work because of the way `debugger' is called in `c= l--assertion-failed'. Is that call correct? The argument in (funcall debu= gger `(cl-assertion-failed ,form ,string ,@sargs)) doesn't seem to match th= e docs: > > If due to error, args are =E2=80=98error=E2=80=99 and a list of the a= rgs to =E2=80=98signal=E2=80=99. > > Is the call just missing an 'error argument? > Oh yeah, I guess it is.