unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: John Wiegley <jwiegley@gmail.com>,
	Andreas Schwab <schwab@linux-m68k.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Lisp watchpoints
Date: Sun, 29 Nov 2015 19:57:05 -0500	[thread overview]
Message-ID: <CAM-tV-88E2GQXNaMr-XFc57d0mx-wyFb6yq0u23DSkFLyh7DaA@mail.gmail.com> (raw)
In-Reply-To: <83lh9gokfm.fsf@gnu.org>

On Sun, Nov 29, 2015 at 11:10 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Sun, 29 Nov 2015 09:12:34 -0500
>> From: Noam Postavsky <npostavs@users.sourceforge.net>
>> Cc: John Wiegley <jwiegley@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
>>       Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
>>
>> > Ffuncall does all necessary checks.
>>
>> It would signal in case of error right? Currently the code is ignoring
>> bad watcher elements (including out of range integers), but perhaps
>> it's actually better to signal an error.
>
> No, I think it would be better to report an error, and then continue,
> perhaps after removing the watch.

I'm thinking to just call display-warning then (removing the element
looks like too much work to be worthwhile, having to modify the list
while iterating over it is kind of annoying).

I noticed that display_malloc_warning passes intern ("emergency") as
the LEVEL, but it should be intern (":emergency") (with a colon),
right?



  reply	other threads:[~2015-11-30  0:57 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14 18:14 Lisp watchpoints (Was: [Emacs-diffs] master 19e09cf: Ensure redisplay after evaluation) Noam Postavsky
2015-11-14 22:29 ` Lisp watchpoints Stefan Monnier
2015-11-22 20:13   ` Noam Postavsky
2015-11-22 20:41     ` Eli Zaretskii
2015-11-22 21:25       ` Stefan Monnier
2015-11-23  3:32         ` Eli Zaretskii
2015-11-23  2:31       ` Noam Postavsky
2015-11-29  2:04       ` Noam Postavsky
2015-11-29  4:44         ` Stefan Monnier
2015-11-29  5:12           ` Noam Postavsky
2015-11-29 11:28             ` Andreas Schwab
2015-11-29 14:12               ` Noam Postavsky
2015-11-29 15:37                 ` Stefan Monnier
2015-11-29 16:10                 ` Eli Zaretskii
2015-11-30  0:57                   ` Noam Postavsky [this message]
2015-11-30  1:14                     ` Stefan Monnier
2015-11-30 15:49                     ` Eli Zaretskii
2015-11-29 11:28           ` Andreas Schwab
2015-11-29 15:39             ` Stefan Monnier
2015-11-29 15:45           ` Eli Zaretskii
2015-11-29 16:01             ` Noam Postavsky
2015-11-29 16:04               ` Noam Postavsky
2015-11-29 17:13                 ` Eli Zaretskii
2015-11-29 22:24                 ` Stefan Monnier
2015-11-29 17:11               ` Eli Zaretskii
2015-11-29 16:06             ` Stefan Monnier
2015-11-29 16:43         ` Eli Zaretskii
2015-11-29 19:40           ` Noam Postavsky
2015-11-29 19:54             ` Eli Zaretskii
2015-11-29 20:35               ` Noam Postavsky
2015-11-29 20:45                 ` Eli Zaretskii
2015-11-29 21:33                   ` Noam Postavsky
2015-11-29 20:00           ` Andreas Schwab
2015-11-29 20:19             ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2016-12-03 14:51 Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-88E2GQXNaMr-XFc57d0mx-wyFb6yq0u23DSkFLyh7DaA@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jwiegley@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).