From: Noam Postavsky <npostavs@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: "Fabián E. Gallina" <fgallina@gnu.org>,
"Michael Albinus" <michael.albinus@gmx.de>,
"Emacs developers" <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633)
Date: Tue, 27 Feb 2018 22:33:28 -0500 [thread overview]
Message-ID: <CAM-tV-81_mUZrQ+y4dKC0JCvA-HazBM70hWeiPGRMSSg2kac0g@mail.gmail.com> (raw)
In-Reply-To: <jwv4lm1q3p0.fsf-monnier+emacsdiffs@gnu.org>
On Tue, Feb 27, 2018 at 9:03 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> + "
>> +Overlapping strings detected (start=%d, last-end=%d)")
>
> You can put a \ at the end of the first line to avoid inserting
> a newline in the string's content.
Oops. I meant to do that, but somehow the backslash disappeared on me
(a paredit boosted typo, I guess).
>> - (set (make-local-variable 'prettify-symbols-alist)
>> - python--prettify-symbols-alist)
>> + (when (and (boundp 'prettify-symbols-alist)
>> + (boundp 'python--prettify-symbols-alist))
>> + (set (make-local-variable 'prettify-symbols-alist)
>> + python--prettify-symbols-alist))
>
> Setting prettify-symbols-alist when it's not defined should be harmless.
> So I'm curious what was the motivation behind the (boundp
> 'prettify-symbols-alist) test?
> Could we replace it with a (defvar prettify-symbols-alist)?
Yeah, I was just going through the compiler warnings, so defvar could work too.
> [ As for python--prettify-symbols-alist, it's defined above, so it will
> always be 'boundp'. ]
Oh, I see, in Emacs 24, the compiler doesn't realize that
define-obsolete-variable-alias defines a variable, so it still warns
about it. Actually, we could just use the non-obsolete
python-prettify-symbols-alist name there, right?
next prev parent reply other threads:[~2018-02-28 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180228012154.1636.19993@vcs0.savannah.gnu.org>
[not found] ` <20180228012156.38869207B1@vcs0.savannah.gnu.org>
2018-02-28 2:03 ` [Emacs-diffs] master 2291d9a: Fix python.el for Emacs 24, bump ELPA version to 0.26.1 (Bug#30633) Stefan Monnier
2018-02-28 3:33 ` Noam Postavsky [this message]
2018-02-28 5:10 ` Stefan Monnier
2018-02-28 7:55 ` Michael Albinus
2018-03-02 3:15 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-81_mUZrQ+y4dKC0JCvA-HazBM70hWeiPGRMSSg2kac0g@mail.gmail.com \
--to=npostavs@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=fgallina@gnu.org \
--cc=michael.albinus@gmx.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).