From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Tue, 8 Nov 2016 19:55:11 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1478652975 30145 195.159.176.226 (9 Nov 2016 00:56:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 Nov 2016 00:56:15 +0000 (UTC) Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 09 01:56:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4HB5-0004f5-K5 for ged-emacs-devel@m.gmane.org; Wed, 09 Nov 2016 01:55:47 +0100 Original-Received: from localhost ([::1]:36217 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4HB8-0007Ze-OG for ged-emacs-devel@m.gmane.org; Tue, 08 Nov 2016 19:55:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4HAX-0007YN-P9 for emacs-devel@gnu.org; Tue, 08 Nov 2016 19:55:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4HAX-0005nq-01 for emacs-devel@gnu.org; Tue, 08 Nov 2016 19:55:13 -0500 Original-Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:36152) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4HAW-0005nf-S4 for emacs-devel@gnu.org; Tue, 08 Nov 2016 19:55:12 -0500 Original-Received: by mail-oi0-x234.google.com with SMTP id v84so220097738oie.3 for ; Tue, 08 Nov 2016 16:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ErJNe9+2L8k6ik+oow98duhl02IOpZWjEOOFad+IY6s=; b=EdKZbC1T6XwNono8bkihgFFU3Ha/uQi+o1W0Hd1euSCom4b4MPWunAVo6wFJK4h7Dj BrFfq3w/xLvcBO7pfAaH+P7+AFL4pzNe1ro5B0aTyNTu52uO5C/L9ETFtnUQi/KtDd4J 8YNmjoCp6PqfCK1bP/JNJd66AXRpSrItbDWojZIq/FE7k/r4vYEbndP3MUKdWEscux+s XRnPA/BEB33QDzqCwhpbSTS+GnFiwWZgwFhqsu1OQWYFz2I3eHU+PD4tT7H9vPe4eQx4 6RWSV/KLDcfbTd4BYn3r/1ossSIbqCgUZaIlWUiLnHIZeD9yPAke7WiZANXxRbFOM2SH kwtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ErJNe9+2L8k6ik+oow98duhl02IOpZWjEOOFad+IY6s=; b=CkjaQCDG00NpojElhj5faaF9ITYXG0tWm0gwE1lIR9g+g9/Q3xI/YffrDkidugil1Y ND3fn/ffowaa+uDRqI7XIY3pSkhURV2PgrKdOAMwWlzWZ5t3rckXMKvJin59nIqsXtEn gpPfJn4pi/7QXCLzDUNorVhDKViCXS6cME9OACzsTWkwoZaNR0jksD76x6sRPt4tGPiW 503bQsxmNoFaOsWkHnmN6q1AeOu7VgVFHp/ipJtEGgl3+50TDbvRojVMAgkCO64BcOmT MyoFobnVi4YgfX9Z7KzkIWhn4nZ70alymjWBjfWEe6A/ucvrvXXayfCmBGBAy2G22bAl zicA== X-Gm-Message-State: ABUngvdC87XUia3PR+vY4QVmxCe7leL9ZddPRAGONO/HMKIi3U5/MvHRm34Q0KS0AoNHb+6B+mHbWliZ5kjOzw== X-Received: by 10.202.90.3 with SMTP id o3mr10290391oib.46.1478652912129; Tue, 08 Nov 2016 16:55:12 -0800 (PST) Original-Received: by 10.157.4.86 with HTTP; Tue, 8 Nov 2016 16:55:11 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: gSeP39-S48QOyNjTK9yl8mr0bwM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209298 Archived-At: On Tue, Nov 8, 2016 at 9:32 AM, Stefan Monnier wrote: >>> Wouldn't it better to use >>> (setq debug-on-error '(cl-assertion-failed) debug-on-signal t) along with: >> But I want debug-on-error to be t, so setting debug-on-signal non-nil is >> not an option because it's too invasive. > > Hmm... maybe what I'd really want is > > (setq debug-on-signal '(cl-assertion-failed)) That makes sense. I think we should do that for 26.1. Meanwhile, I've pushed the (funcall debugger...) solution to emacs-25 since that is less of a change vs 25.1 than what's there currently.