From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Merging bignum to master Date: Mon, 13 Aug 2018 21:12:01 -0400 Message-ID: References: <877ekwu1mn.fsf@tromey.com> <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1534209039 11770 195.159.176.226 (14 Aug 2018 01:10:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Aug 2018 01:10:39 +0000 (UTC) Cc: Tom Tromey , Pip Cet , Emacs developers To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 14 03:10:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpNr0-0002wn-Tb for ged-emacs-devel@m.gmane.org; Tue, 14 Aug 2018 03:10:35 +0200 Original-Received: from localhost ([::1]:41986 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpNt7-0005wq-Ak for ged-emacs-devel@m.gmane.org; Mon, 13 Aug 2018 21:12:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fpNsS-0005wl-M5 for emacs-devel@gnu.org; Mon, 13 Aug 2018 21:12:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fpNsR-0000yw-Le for emacs-devel@gnu.org; Mon, 13 Aug 2018 21:12:04 -0400 Original-Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:36737) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fpNsR-0000yk-FT for emacs-devel@gnu.org; Mon, 13 Aug 2018 21:12:03 -0400 Original-Received: by mail-oi0-x233.google.com with SMTP id n21-v6so30731324oig.3 for ; Mon, 13 Aug 2018 18:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=vztHbTCpNRRgYOhr89A/Dv5x05c9MhivbzrcHRFkdkU=; b=b0+nPuSdQVuekMMZyMu/0N/oMSp+MYzwQXNT5QTLHl7S8oACLPLxccv88WgF2cBkGa R57lwcmLdkRnRtXAjZ8DYPwr2e8yc4Ndv5fYJd1QHizbcQrWuT966IM1pNFEQpseh6VW UhG3eAPDecZoqPdBXz/sew97Bst7KGVNoR6NbIcf/e1TKT+NVHrPNzMBh5Dffa4eAf13 erU2ktt3Drm+A0k4ndqqmBXwk0lehKSS21xEz00xF/cWpZR/2+DbPVvrWRZ6rwBU6Zzy l6ebm4DBeV8T7rHedFPzmtzVuyc8u4D3ZBNlMIeBm+DVv+44PreNjYFADAxlXtqYRVjc EM4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=vztHbTCpNRRgYOhr89A/Dv5x05c9MhivbzrcHRFkdkU=; b=SjhZKd/VBQb8Y/Cv1qeaCqUCDus3iuajHKjnSOrql3pxqFk4U0fu3CG16nmDHFjYlB zCC9ZmD80BdAGr/1HSr9Vbn0bVEWkJqpfUTIehwyvSsllw89lrkGdZDUSUN/OddwWrKS TQ+/q7BDP5R/CG+AA4HbJnJFk/q+/Lmw7z+BfUzK4ECpZb8fIFNLTf3k3nLValiSngEB 99AHtkPJCN8eslKGJ+uLyqsdOxPLcVVbTDQLxHSHivYY7JTslTH2sIfqM/iTaHaGMrVH VsPj/PDh1zsqcorl8F+gdHVk3YFnacI75SpodDKbI69AC6hqVsTJst869Xip5LA8O68s M45A== X-Gm-Message-State: AOUpUlEGmXDIQwTb5uZVWMSRFPvqt2Xk4nvmqekncaHAlexHz8qVrBac QypQvuilga6wW5TfIVgWfGbErdcnge7GTPMgo9M= X-Google-Smtp-Source: AA+uWPzRSv+wxyOsbkshPiJACr6Z8HePoyWSD8y8932ub16hnoi+0CtX2hcZBIMTQy8bSl4ELwbna7uNqGSYr5aI6/I= X-Received: by 2002:aca:a993:: with SMTP id s141-v6mr21436696oie.72.1534209122563; Mon, 13 Aug 2018 18:12:02 -0700 (PDT) Original-Received: by 2002:a9d:268d:0:0:0:0:0 with HTTP; Mon, 13 Aug 2018 18:12:01 -0700 (PDT) In-Reply-To: <611579fd-52f2-0104-ef82-a7a4a3929700@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228514 Archived-At: On 13 August 2018 at 18:58, Paul Eggert wrote: > meantime I installed the attached first patch to fix a glitch I saw in th= is > area while looking at the current XFIXNUMPTR uses. > --- a/src/lisp.h > +++ b/src/lisp.h > @@ -1189,9 +1189,15 @@ XFIXNUMPTR (Lisp_Object a) > } > > INLINE Lisp_Object > +make_pointer_integer_unsafe (void *p) > +{ > + return TAG_PTR (Lisp_Int0, p); > +} > + > +INLINE Lisp_Object > make_pointer_integer (void *p) > { > - Lisp_Object a =3D TAG_PTR (Lisp_Int0, p); > + Lisp_Object a =3D make_pointer_integer_unsafe (p); I use ./configure --enable-check-lisp-object-type, and this gives me CC dispnew.o In file included from dispnew.c:27:0: lisp.h: In function =E2=80=98make_pointer_integer_unsafe=E2=80=99: lisp.h:568:28: error: expected expression before =E2=80=98{=E2=80=99 token # define LISP_INITIALLY(w) {w} ^ lisp.h:790:3: note: in expansion of macro =E2=80=98LISP_INITIALLY=E2=80=99 LISP_INITIALLY ((Lisp_Word) ((untagged_ptr) (ptr) + LISP_WORD_TAG (tag))= ) ^~~~~~~~~~~~~~ lisp.h:1194:10: note: in expansion of macro =E2=80=98TAG_PTR=E2=80=99 return TAG_PTR (Lisp_Int0, p); ^~~~~~~