From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: master 491531b: Avoid ert test failures Date: Sat, 22 Apr 2017 23:23:08 -0400 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: blaine.gmane.org 1492917823 32176 195.159.176.226 (23 Apr 2017 03:23:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Apr 2017 03:23:43 +0000 (UTC) Cc: Emacs developers To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 23 05:23:38 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d287e-0008H4-8C for ged-emacs-devel@m.gmane.org; Sun, 23 Apr 2017 05:23:38 +0200 Original-Received: from localhost ([::1]:37702 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d287k-0000Us-5p for ged-emacs-devel@m.gmane.org; Sat, 22 Apr 2017 23:23:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d287E-0000Un-B6 for emacs-devel@gnu.org; Sat, 22 Apr 2017 23:23:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d287D-0002av-FV for emacs-devel@gnu.org; Sat, 22 Apr 2017 23:23:12 -0400 Original-Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:34353) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d287B-0002ZT-BX; Sat, 22 Apr 2017 23:23:09 -0400 Original-Received: by mail-oi0-x231.google.com with SMTP id x184so134067748oia.1; Sat, 22 Apr 2017 20:23:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=06Ov2IfLb1Ce1hBoUoRQ+qMn2Ee9eRaXVT0HtoFokLg=; b=KGMvCRCqli7WofcpOwpRAhFCMRF9+z9XPmiCtsU8O/PBjdgPGJd24XP3DZm5x4WjCp kM623hpkdnOilliOw11Mc3Rc2/U/aMP88/FaYfPVRHp7fiAKy8ObGk2+5BhoKMqNfswy BMYEF5bvuq622LqDIpxbYSAP+4vjWbBNqRAnGYY9ixE97zQwwvfWvUwIfOjC0mo805XD dVPRqj9nK8e03vvKvAAAKTCLP0CGQfUeIwKdU3woytMB7as4x1vbQ3YnEuChw2WejakN 9DG+HeUlY8DeIy8elETYV73BytFfvOz0MOXOzOq2LMQgMYecCgZHgPny5fdW07F7FCpz Vmbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=06Ov2IfLb1Ce1hBoUoRQ+qMn2Ee9eRaXVT0HtoFokLg=; b=eD59qsVP5v484iG/FioX8l6VP3crqf9D0qc6IAKsh49yixmSt9cZJibR4RWhDSXDvl Wj6fHNTQv9MQULAkwK2ThaL3TkVTFRlgFEIbpMd4IPC+LzL/IF3JEUPPmtbEXAvEsvgg DTjcPBnrDm6D3IGTugXbmRALSSbrz8urD0HEJeeLyhrBN2KysDwA0P9F10WFcWj4qXKk wXVyORfkDStieCiriiYpXEiUQLLpMOfutoAMI+54FSbLGKo2cuzVpTpQMNPvkVhMN1tV oh51McFEJG3NESuf3JRvmZwK8Ig28S5K0wSpaQiF+dSQLxx1dZgoSLLDX05xMRamzynx GHZg== X-Gm-Message-State: AN3rC/5auSFxigxJ82ERB1jxUaCPKff0UY5KfDD7JKnIwK8AYv4bH0Uw ov/6mTFlRMnHAjXCHtdaGC6aIQurXCV5 X-Received: by 10.157.7.169 with SMTP id 38mr11368379oto.221.1492917788442; Sat, 22 Apr 2017 20:23:08 -0700 (PDT) Original-Received: by 10.157.9.178 with HTTP; Sat, 22 Apr 2017 20:23:08 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: eqVh-ZUm2tKEi_rmmi-1dJUn4fY X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214232 Archived-At: >> Anyway, I was considering fixing this by using (bound-and-true-p >> byte-compile-macro-environment) instead of loading `bytecomp', which >> almost seems to work except that eval-tests--bugs-24912-and-24913 >> fails because `should-error' fails to catch the error from >> byte-compile. Actually the issue there was just a missing defvar for `byte-compile-debug'. There should have been a compile warning about an unused local variable except that loading the compiler defines this variable. Fixed in [1: b20d05c6d7]. [1: b20d05c6d7]: 2017-04-22 23:17:59 -0400 Don't require bytecomp for running ert tests http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b20d05c6d76ddaf7e70da1430c9aac56ef1d6b31