From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Sun, 29 Jan 2017 10:37:33 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485704309 19045 195.159.176.226 (29 Jan 2017 15:38:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jan 2017 15:38:29 +0000 (UTC) Cc: Stefan Monnier , Emacs developers To: =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 29 16:38:25 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXrYK-0002up-9Z for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 16:38:04 +0100 Original-Received: from localhost ([::1]:55742 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXrYP-0001Gd-Mj for ged-emacs-devel@m.gmane.org; Sun, 29 Jan 2017 10:38:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXrXt-0001GV-4c for emacs-devel@gnu.org; Sun, 29 Jan 2017 10:37:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXrXs-0002xn-BU for emacs-devel@gnu.org; Sun, 29 Jan 2017 10:37:37 -0500 Original-Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]:34123) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXrXs-0002x2-5H for emacs-devel@gnu.org; Sun, 29 Jan 2017 10:37:36 -0500 Original-Received: by mail-oi0-x231.google.com with SMTP id s203so51081008oie.1 for ; Sun, 29 Jan 2017 07:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=IL9fsxQXJ85+LcglTbSubaBz3XxHzXmmaIoJ9fdHfHU=; b=F+uJu2LzVRKpAfnIwa4dT1upEJXMjiF+f6iRrOo1pLby4f6aMDMfEi7oS0IKk5oO2F NRcUAOjADxqV7xHVobH3X45/bRuwd/y/g7+JUg5vsHNrhXvOgxPzX+oYNN9ywBHu3l49 rgfwRKYM32bkshogrYD4xENB19X7AsVBTxs9XjDJIZ3Cp+s14Gc32psO3rBIVoF5o2Lt I6Nj/anNaJakfbQF/ETeqCTdcw7ZWlOaKvZnA4kKYpfnkdK5mx+a2o01rRsr4ci9Fh9L TAFZBY4h74qDk8xyXYPpYdon9FPwt/azSrO2NfVL/eGqUpfXnN+Tu0JXPSTZ1Pk8tnjt xoew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=IL9fsxQXJ85+LcglTbSubaBz3XxHzXmmaIoJ9fdHfHU=; b=kg/0FIR9fSdS2YeyEPo6/k1r3pothkwDX9hWiS88+xLAWlaMWGsJy8DbUb5NF5XNpz BK7ehyhtIGZ/KrMScXA0R5MFXXfnil4CLhS0WtJa9b7KRIVnTK81+7gglS4Hd8tRQCR8 Plu2+CDchQugOmhJK+Ls2+DJsCcAEtt6I1QYpmvqZth1SOxC8HudN4e5cfM2veofp1EB FlP18Q4bmMwI5mG+uvEBzqWVtJ1srl7gGTRJid/ANDIYKlvQQ85tTP/uzdSICed61OgY hde/nLsLKKa72NLfXmdWsWOws+RGESda2qD7WqpPGx5uLxTJpLzznflN4HiujIQuib8a aCzQ== X-Gm-Message-State: AIkVDXLyThO3eQEYcP9oLguaw9StPie7YtBye9Ts8BX0rrJdtAYWeKw5SalD4g7HPdUVSApDifCW7qKRfP6r8g== X-Received: by 10.202.4.84 with SMTP id 81mr9258951oie.127.1485704253921; Sun, 29 Jan 2017 07:37:33 -0800 (PST) Original-Received: by 10.157.21.117 with HTTP; Sun, 29 Jan 2017 07:37:33 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: n27oe29Zo5Mas-a1B1ZlV_sOOVs X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211725 Archived-At: On Fri, Jan 27, 2017 at 10:46 PM, Noam Postavsky wrote: > On Fri, Jan 27, 2017 at 10:30 PM, Cl=C3=A9ment Pit--Claudel > wrote: >> On 2017-01-27 20:59, Noam Postavsky wrote: >>> I guess let-binding `debugger' to a function which performs the >>> logging should do the trick? >> >> I already do that, in fact, and I do re-throw the exception from there. = Looks like things didn't work because of the way `debugger' is called in `= cl--assertion-failed'. Is that call correct? The argument in (funcall deb= ugger `(cl-assertion-failed ,form ,string ,@sargs)) doesn't seem to match t= he docs: >> >> If due to error, args are =E2=80=98error=E2=80=99 and a list of the = args to =E2=80=98signal=E2=80=99. >> >> Is the call just missing an 'error argument? >> > > Oh yeah, I guess it is. Um, should this be (funcall debugger 'error `(cl-assertion-failed ,form ,string ,@sargs)) or (funcall debugger 'error `(cl-assertion-failed (,form ,string ,@sargs))) I'm getting confused with all the levels of nesting and funcall/apply.