From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 db436e9: Don't call debug on failed cl-assert Date: Mon, 30 Jan 2017 21:53:11 -0500 Message-ID: References: <20161105015720.6371.89806@vcs.savannah.gnu.org> <20161105015720.88A6322012D@vcs.savannah.gnu.org> <4f7ad1cf-7632-abea-e15e-a3fdfff795c6@gmail.com> <12a5baea-9bca-994f-ec92-5ddd36321c11@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1485831248 32037 195.159.176.226 (31 Jan 2017 02:54:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 31 Jan 2017 02:54:08 +0000 (UTC) Cc: Emacs developers To: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 31 03:54:03 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYOa3-00087i-O9 for ged-emacs-devel@m.gmane.org; Tue, 31 Jan 2017 03:54:03 +0100 Original-Received: from localhost ([::1]:35874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYOa9-0004NB-9G for ged-emacs-devel@m.gmane.org; Mon, 30 Jan 2017 21:54:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cYOZF-0004M4-Sy for emacs-devel@gnu.org; Mon, 30 Jan 2017 21:53:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cYOZF-0002xp-6x for emacs-devel@gnu.org; Mon, 30 Jan 2017 21:53:13 -0500 Original-Received: from mail-oi0-x241.google.com ([2607:f8b0:4003:c06::241]:36006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cYOZF-0002xh-2F for emacs-devel@gnu.org; Mon, 30 Jan 2017 21:53:13 -0500 Original-Received: by mail-oi0-x241.google.com with SMTP id u143so27284463oif.3 for ; Mon, 30 Jan 2017 18:53:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=p+damTNOBiif6Bdji+BKmPN2ae/vnqWsS1nZCm65eZs=; b=QEdDnMdzmAnRORK1Ei1mtnFG4Z6ss9zFcc2PwcmKH4jR0P+PWmCCdM/pYK1eG6J+pf 6aZDMZfvQRS1jWBVZBEQ5UMRU859BywULgH3fo2owxyy1tlLDcB84o+coEUHuQIR5KYA JA6h8vZE7rRtLsmGo3y5kYp6NCy728I5g6sQ/iGpzvI3NENdS/K5/QciEvQLdpEFLvvR 9gmud/7GTrxs0X9waN1hdvH7KXjwFN7Te6/7F/W5xcpbuudszJjNdtonNPOUVr21SDVb 1eA8bxmj1xm2HMZv3HXxp8rk9nOOPCCC03/3kVIR1r6+bJ9cdiHFiaaF/525fWqoZ1I+ N9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=p+damTNOBiif6Bdji+BKmPN2ae/vnqWsS1nZCm65eZs=; b=QFP9R4tyDvWZ2TWq5667i/XaBIidzRv6l9n5h4Jn8K09TnHxsyONHXFBDUG2jA6GMk X7OEd5mXZfMN5C0eH0pbxQeJhz+gl8NHPGo76qIdvsWHv2nwUUskJIV0DPv2Van1eJw1 fvkDxoid32oH024Q4OuorbLsEgFT67s0GjJcJnGLywoMED3ZuztPUA+lcsC+ju0Z8c3d S9RKVK7ZwifKcVX8SiuCGYLIDN7U20xFTo3X4G8cW71tWlT/6Of+faI2nX84fEy8jfMp jRSrIBT5itmTrc9JNN4l54EpHluC7xOBKUGpSk0G04iCWHFK2r0IJd8JhwTUP7ETuWCB rWEw== X-Gm-Message-State: AIkVDXKb0+qUF/kwpFssbx7kgXzZvAxoj1F4cQaQtl4sKkxsXK4xpApSTjjtdY3wbXkNZB0xQAetiunGoeP1PA== X-Received: by 10.202.4.84 with SMTP id 81mr12875998oie.127.1485831192073; Mon, 30 Jan 2017 18:53:12 -0800 (PST) Original-Received: by 10.157.21.117 with HTTP; Mon, 30 Jan 2017 18:53:11 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: GIrFCgDYwmMn4qQQ7i8wSXVpSog X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211781 Archived-At: On Sun, Jan 29, 2017 at 4:09 PM, Cl=C3=A9ment Pit-Claudel wrote: >> Um, should this be >> >> (funcall debugger 'error `(cl-assertion-failed ,form ,string ,@sargs)) >> >> or >> >> (funcall debugger 'error `(cl-assertion-failed (,form ,string ,@sargs))) >> >> I'm getting confused with all the levels of nesting and funcall/apply. > > > I think the second one. `debugger' gets two arguments, 'error and a list= of arguments to `signal'. That list should have two entries: `cl-assertio= n-failed' and `(,form ,string ,@sargs). > Pushed to emacs-25 [1: 72ef710]. 1: 2017-01-30 21:45:02 -0500 72ef710f6e1c8e334fd50da9480a8cb151e823a2 Fix call to debugger on assertion failure