From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Replace trivial pcase occurrences in the Emacs sources Date: Tue, 23 Oct 2018 11:07:10 -0400 Message-ID: References: <20151216202605.GA3752@acm.fritz.box> <83fuygcs5g.fsf@gnu.org> <56886E32.70305@yandex.ru> <83si2f9ve4.fsf@gnu.org> <56889EC3.3040108@yandex.ru> <877fjrkpdf.fsf@fencepost.gnu.org> <56892334.4000106@yandex.ru> <8760zakb7q.fsf@fencepost.gnu.org> <56892BDA.6060103@dancol.org> <871t9yk98g.fsf@fencepost.gnu.org> <568936F0.3060505@yandex.ru> <87wprqitj5.fsf@fencepost.gnu.org> <56893C8C.3060200@yandex.ru> <87oad2irtd.fsf@fencepost.gnu.org> <5689456A.1010601@yandex.ru> <87egdy8tyz.fsf@fencepost.gnu.org> <56895FDE.4060406@yandex.ru> <8760za8r4a.fsf@fencepost.gnu.org> <87h9iunkcg.fsf@web.de> <87h8hc4xw2.fsf_-_@web.de> <87bm7k4t5s.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1540307156 19329 195.159.176.226 (23 Oct 2018 15:05:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 23 Oct 2018 15:05:56 +0000 (UTC) Cc: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , Emacs developers To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 23 17:05:52 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gEyFj-0004up-Ns for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 17:05:51 +0200 Original-Received: from localhost ([::1]:42608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEyHq-0005pi-5d for ged-emacs-devel@m.gmane.org; Tue, 23 Oct 2018 11:08:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gEyHh-0005f1-Bh for emacs-devel@gnu.org; Tue, 23 Oct 2018 11:07:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gEyHb-0004GX-Jw for emacs-devel@gnu.org; Tue, 23 Oct 2018 11:07:53 -0400 Original-Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:37991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gEyHZ-0003hh-HV for emacs-devel@gnu.org; Tue, 23 Oct 2018 11:07:47 -0400 Original-Received: by mail-oi1-x229.google.com with SMTP id k19-v6so1381120oiw.5 for ; Tue, 23 Oct 2018 08:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5BhP2+3CyWy124DSi5qOhy2tD0Ss0ukXBeOd/yh60JQ=; b=TaaEpUeCDfEmB7X/VxroxPzHWD66WdEXtJW0LoOLHbij3nXrrr0b49MgsjipuIBzgn 8QMQTadA1A0dV/0l9gqtvT+hB9qhvm/Mol2CpZxbp4VfiY6+Q4K5i1GcCwfBneKktfPY rhP/LTHTbLFV51Kd2B8+ZKum4A4QL1e4cHx++i7IchDXDp4jQDr2A4MH3NSS/+V57RCj MkgoSSE8koM0l0Jr+wfGjd7vXVJxPgo5mE+9dpoKF/V6Wy0zWx+o58BKRQ/D0H7SK40X /+rZQn7ioYo/HqqPde+JzjGAjmaoar8hk7TkQHZBJEROSHZe4lDyoeMDuEfdB9pBOSC5 i5cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5BhP2+3CyWy124DSi5qOhy2tD0Ss0ukXBeOd/yh60JQ=; b=EFiOoROP55B6qiuu1Qr1mm0/FH6DhttVDsUc85VphO/wYbPAEHY2nZB4Ow72klagrR ba7FD45O70Bo+HZcoyOVUyZB6IJr8xjITvHVdlkAxIa+ig7GjAuB6BVIepivbuw8udJl H8aknbFeZ81mRKzJLsem0gHsXwAEMRGkVpDuTtZztPvSKaifJP+aPVBeiA6skKAJNAaj ZVnPxn11hwlND9CT2b1+wknC/DRmTPRftxJkusAnNGXyUj6ioYyqfTk+CedskynuGoql k34SB0TfI20VU9IaZI20FbfPJ2D/9ocl0P69qM6Q6C4XDg71oRNJEu8vNrR5dWyyCiNs rC4Q== X-Gm-Message-State: ABuFfoi9NJqbyPL0eSCRpwlEftSB0HDcR5sXt+pXiU78Ot1HlTDA6gIf iWl6UCmkr+PvtszFKZqdbG4tGrFZSQtst9AkyNk= X-Google-Smtp-Source: ACcGV61PbujFEW/fGqa7V+GUYbdOW7Mio1AnENKg3RLu5f48kbMqL5NdzSMFfjiZq/3gIICccg9HL9v+Yzg4irvKxpg= X-Received: by 2002:aca:b04:: with SMTP id 4-v6mr27242461oil.192.1540307239703; Tue, 23 Oct 2018 08:07:19 -0700 (PDT) In-Reply-To: <87bm7k4t5s.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230587 Archived-At: On Tue, 23 Oct 2018 at 10:47, Michael Heerdegen wrote: > > Cl=C3=A9ment Pit-Claudel writes: > > > On 23/10/2018 09.04, Michael Heerdegen wrote: > > > In a second step, I also would want to replace the unnecessarily > > > backquoted patterns to use quotes > > > > IIRC, one issue with that is that the quoted form doesn't work in some > > old-but-still-popular Emacsen. > > I'm not sure I understand. I plan to do that only in the Emacs sources > (in master). How can that be problematic for older Emacsen? There are some files in Emacs master branch that are also distributed in GNU ELPA for older Emacs, e.g., python.el (I don't know if it has any pcase instances that you might want to replace, it's just the first example that came to mind). Another thing to watch out for is that pcase is available earlier than cl-case in the bootstrap sequence.