unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] master 3f2bfe9 4/4: Keep nxml-prolog-end up to date (Bug#18871)
       [not found] ` <20190604124340.2B1FF209A5@vcs0.savannah.gnu.org>
@ 2019-06-04 13:35   ` Stefan Monnier
  2019-06-06  0:35     ` Noam Postavsky
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-06-04 13:35 UTC (permalink / raw)
  To: emacs-devel; +Cc: Noam Postavsky

> +(defun nxml-maybe-rescan-prolog (start _end _length)
> +  "Reparse the prolog if START lies within it.
> +`nxml-mode' adds this function on `after-change-functions'."
> +  (when (<= start nxml-prolog-end)
> +    (save-excursion
> +      (nxml-scan-prolog))))

Can't this be called from the syntax-propertize-function instead of the
after-change-functions?


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Emacs-diffs] master 3f2bfe9 4/4: Keep nxml-prolog-end up to date (Bug#18871)
  2019-06-04 13:35   ` [Emacs-diffs] master 3f2bfe9 4/4: Keep nxml-prolog-end up to date (Bug#18871) Stefan Monnier
@ 2019-06-06  0:35     ` Noam Postavsky
  0 siblings, 0 replies; 2+ messages in thread
From: Noam Postavsky @ 2019-06-06  0:35 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: Emacs developers

On Tue, 4 Jun 2019 at 09:35, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> > +      (nxml-scan-prolog))))
>
> Can't this be called from the syntax-propertize-function instead of the
> after-change-functions?

The answer seems to be yes.

[1: da118e6a7c]: 2019-06-05 20:30:23 -0400
  Keep nxml prolog updated via syntax-propertize
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=da118e6a7c5d1d1d07fd186b0ae5e60340ac9dca



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-06  0:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20190604124338.22123.87100@vcs0.savannah.gnu.org>
     [not found] ` <20190604124340.2B1FF209A5@vcs0.savannah.gnu.org>
2019-06-04 13:35   ` [Emacs-diffs] master 3f2bfe9 4/4: Keep nxml-prolog-end up to date (Bug#18871) Stefan Monnier
2019-06-06  0:35     ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).