From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build Date: Tue, 28 May 2019 16:43:48 -0400 Message-ID: References: <831s0xd3z1.fsf@gnu.org> <83pnohbhny.fsf@gnu.org> <83zhn6zkgf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5125"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Eli Zaretskii , Stefan Monnier , Emacs developers To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 28 22:47:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVizt-0001Cf-Qg for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 22:47:01 +0200 Original-Received: from localhost ([127.0.0.1]:42532 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVizs-0000Fc-Ru for ged-emacs-devel@m.gmane.org; Tue, 28 May 2019 16:47:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVix7-0006jp-6c for emacs-devel@gnu.org; Tue, 28 May 2019 16:44:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVix6-0002nW-2k for emacs-devel@gnu.org; Tue, 28 May 2019 16:44:09 -0400 Original-Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]:38115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVix4-0002i4-4p; Tue, 28 May 2019 16:44:06 -0400 Original-Received: by mail-ot1-x329.google.com with SMTP id s19so19126630otq.5; Tue, 28 May 2019 13:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q+yHrzAZkVr0EFjxqxBAwad44BtM9GoSHV8Dvjb9Q0M=; b=TQxzaWmwLjX25OZSVKCzdZeBlVV14kb2zahfU/MEIBfoXWXDuYL9/rL3HkF3rZ4ok2 ChXQcF+Oh6fTfYBblrp1gVH2tX/rLhoaXNmpUdS5DLy/i18iaCLaD9BZv7eaMMSRJOLW cg6Hh5b1yRJxzJrqvyc8FXrxnhUDciw9Pl/RuaKm/vyQQsa9WjaTaT226IFnGu0dTusS 3+WM5kJXpxTRUfvMVi3jiSkCq0zW6ogdmp7c4FsJ/dQsu7YWEWY5JacVmZ3jxqw/9n56 vFMrBJU1zO7DtH+621Ghp0QZUxTeCm+SSqVAZY/dYVKXmONxelm2ixA90NdWf0riXEwQ wC0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q+yHrzAZkVr0EFjxqxBAwad44BtM9GoSHV8Dvjb9Q0M=; b=CGRX/lPDLQQTn7Far3k1TcPjt9X8RYDfHygi1fgT+ykkOR+u2z4Mp/4K+sAX/ROprh +DMJutMIfMCvj8dPB9t9fQR5gfH/G6ZLsdRzoyT/tZJ8K13jBF8YSURgU+6VaS37KPaj meFTbIGMeV/5vndMwhyOzg0lrjXJs4tB0xp+VXdRwJhFSOf1g5b/i55B05DS+Gb3uevO 7XOBT00e/p+Olj3FKimQ92qyb2vC0lin3pz0SLg4XLIIDcnknP0dli3ZnhSpBWUSrOSc f7SGheXLA3qtoWTC0h5NOXhvo7O7ff+tli5phCWmRJn7CGD//J37/XeP8QLcT+6r04wD J2tg== X-Gm-Message-State: APjAAAU1hwhoklB2BOpIzyAjAmcvJsgaGUPYcyhzBX1KTNx93xwFj9KY CSAM1X/gUivIROHREgHNnNkweLXY2r2MQHyUcaM= X-Google-Smtp-Source: APXvYqweyvPuwGPwZzo+xqs79dkbsaxih/aHF6pEpwS+yxMaFtQ1hMHzBoT1F/dD0Q50lyJQzTnQwFqC7Xy7io07I9M= X-Received: by 2002:a9d:7354:: with SMTP id l20mr19418009otk.115.1559076244570; Tue, 28 May 2019 13:44:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::329 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237129 Archived-At: On Tue, 28 May 2019 at 11:11, Lars Ingebrigtsen wrote: > +(defmacro with-suppressed-warnings (warnings &rest body) > + "Like `progn', but prevents compiler warnings in the body." Not quite like progn, since WARNINGS (is that WARNINGS or WARNING, by the way?) is not evaluated. > + (declare (indent 1)) A debug spec would be a good thing to have. > + ;; The implementation for the interpreter is basically trivial. > + `(with-suppressed-warnings-1 ',warnings (progn ,@body))) A comment here on why we need both a function and macro would be useful (or is it possible to have this work with just a macro?) > +(defun with-suppressed-warnings-1 (_ &rest body) > + "Like `progn', but prevents compiler warnings in the body." > + (declare (indent 1)) This should be called internal--with-suppressed-warnings-1, and the (declare (indent 1)) thing left out, since nobody should be calling this function directly anyway, right?