unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Alan Mackenzie" <acm@muc.de>,
	"Emacs developers" <emacs-devel@gnu.org>,
	"João Távora" <joaotavora@gmail.com>,
	"Tino Calancha" <tino.calancha@gmail.com>
Subject: Re: Finding macro-generated ert test definitions (WAS: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings.)
Date: Wed, 23 May 2018 18:40:24 -0400	[thread overview]
Message-ID: <CAM-tV--Em3Bp4xgRNJFaF5HzMQu3g+cj8b2xYHL3Uh5qKJKC9A@mail.gmail.com> (raw)
In-Reply-To: <83r2m2cthd.fsf@gnu.org>

On 23 May 2018 at 10:54, Eli Zaretskii <eliz@gnu.org> wrote:

>> > Also M-x ert-find-test-other-window could have helped you, but it
>> > doesn't (brings me to the beginning of the file, which isn't helpful). I
>> > don't know why, does anyone?
>>
>> It works by searching the source file for "(ert-deftest TEST-NAME",
>> but in this case TEST-NAME doesn't occur in the source, it's produced
>> at compile time by the define-electric-pair-test macro.
>>
>> See ert--find-test-regexp and find-function-search-for-symbol.
>
> WIBNI this was described in ert.texi?

It's mostly not ert-specific, although probably worth warning about
it. How's this?

--- i/doc/misc/ert.texi
+++ w/doc/misc/ert.texi
@@ -386,5 +386,10 @@ How to Write Tests

+@findex ert-find-test-other-window
 Just like @code{find-function} is only able to find where a function
 was defined if the function was loaded from a file, ERT is only able
-to find where a test was defined if the test was loaded from a file.
+to find where a test was defined (via
+@code{ert-find-test-other-window}) if the test was loaded from a file.
+Since this relies on a textual search of the source, it will likely
+fail if you use a macro which expands into the @code{ert-deftest}
+form, especially if the test name itself is absent from the source.



  reply	other threads:[~2018-05-23 22:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22 22:55 Finding macro-generated ert test definitions (WAS: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings.) Noam Postavsky
2018-05-23  0:52 ` Finding macro-generated ert test definitions João Távora
2018-05-23 14:54 ` Finding macro-generated ert test definitions (WAS: [Emacs-diffs] master bb591f139f: Enhance CC Mode's fontification, etc., of unterminated strings.) Eli Zaretskii
2018-05-23 22:40   ` Noam Postavsky [this message]
2018-05-24 16:41     ` Eli Zaretskii
2018-05-24 16:50       ` Finding macro-generated ert test definitions João Távora
2018-05-24 22:34         ` Noam Postavsky
2018-05-24 23:00           ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV--Em3Bp4xgRNJFaF5HzMQu3g+cj8b2xYHL3Uh5qKJKC9A@mail.gmail.com \
    --to=npostavs@gmail.com \
    --cc=acm@muc.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).