From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dape Date: Tue, 17 Oct 2023 22:39:49 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21700"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Mauro Aranda Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 17 22:41:14 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qsqsL-0005Yw-Vu for ged-emacs-devel@m.gmane-mx.org; Tue, 17 Oct 2023 22:41:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsqrP-00082i-5B; Tue, 17 Oct 2023 16:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsqrJ-00080d-EB for emacs-devel@gnu.org; Tue, 17 Oct 2023 16:40:12 -0400 Original-Received: from mail-ua1-f45.google.com ([209.85.222.45]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsqrC-0003SM-GB for emacs-devel@gnu.org; Tue, 17 Oct 2023 16:40:07 -0400 Original-Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-7b652e785dbso1631254241.0 for ; Tue, 17 Oct 2023 13:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697575200; x=1698180000; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6rAx+tt9Z6CiOqadka5bflrTBNl5JD66+jDXrJkLjC0=; b=iV2HF3Pwfits2btwo97SEYGodAmE+WRAWuy5gbpeQdD/VWqH9BHPsFE5bPWHjhRbEu oY8PxYbegzU7UJ9/Bv0njD4gv2a7tmdbXW4bHpr5n5qcTp1FxTTjAnZiqosE73oAKejo 4l+EsqoyxcKyiRtTwJ1Cue1a5V2eMf7qLfyqv6VSJ9OiKreE8UBZmsOYjQs5u30ikLvb 6ZQhFnMU05lhm0LQl9q1b0HwAmsjbgHqb7O59KEEkwVRvi5CVx9AsNI/LFLZHE4K2tXr VrHofP5e22d6+KME0eji+HH8CUqIFb6XUKJ+nkHoRqf1PEJ+6Sl28nYR9Ztmg+Q+hTVb ZUTg== X-Gm-Message-State: AOJu0YwRJrOWy2asrfT1CA7xrRdI0x0GLik/fwO4XLk1aX9yxUclO6bd 5ME9Uimv6JYlGhBUQywaFsMrfS+foQszvQ== X-Google-Smtp-Source: AGHT+IFTZkuQlbmV5DNo9TpNHG4D5dSZOBNUMjbz+I/ydPGUD5PbRRKN5GPp3zw2XTf9zLqFCcdIvQ== X-Received: by 2002:a67:e09b:0:b0:457:bc52:9b04 with SMTP id f27-20020a67e09b000000b00457bc529b04mr3122816vsl.35.1697575200508; Tue, 17 Oct 2023 13:40:00 -0700 (PDT) Original-Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com. [209.85.217.47]) by smtp.gmail.com with ESMTPSA id n11-20020a67e04b000000b00450fce34dcesm272929vsl.8.2023.10.17.13.40.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Oct 2023 13:40:00 -0700 (PDT) Original-Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-457e9088d7aso1223718137.1 for ; Tue, 17 Oct 2023 13:40:00 -0700 (PDT) X-Received: by 2002:a67:b043:0:b0:457:c982:57fa with SMTP id q3-20020a67b043000000b00457c98257famr3776993vsh.5.1697575200104; Tue, 17 Oct 2023 13:40:00 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: Received-SPF: pass client-ip=209.85.222.45; envelope-from=daniel.dpettersson.net@gmail.com; helo=mail-ua1-f45.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311548 Archived-At: On Sun, Oct 15, 2023 at 3:55=E2=80=AFPM Mauro Aranda wrote: > I have some comments about the defcustoms in dape.el: Super! I am not that familiar with customs. > (keyword sexp) as the last :options looks really weird. Are you sure > that is the intention? Removed :) > If you're going to depend on 29.1, then perhaps it's better to use 'key, > since a decision was made to obsolete 'key-sequence. If something > doesn't work with 'key but works with 'key-sequence, then please report > it. Makes sense. > This doesn't allow for any customization at all when using Customize. I > think you want to use '(repeat function) This has been changed to 'hooks. > > (defcustom dape-main-functions '("main") > > "Functions to set breakpoints at startup if no other breakpoints > are set." > > :type '(list string)) > I think you want (repeat string) here. Fixed! > > (defcustom dape-read-memory-default-count 1024 > > "The default count for `dape-read-memory'." > > :type '(integer)) > > Is natnum better suited here? Sure, changed. > > (defcustom dape--debug-on > > '(io info error std-server) > > "Types of logs should be printed to *dape-debug*." > > :type '(list (const :tag "dap IO" io) > > (const :tag "info logging" info) > > (const :tag "error logging" error) > > (const :tag "dap tcp server stdout" std-server))) > > Similar to dape-buffers-on-start. Fixed, `set' instead of `list'. Should do it right. Great input!