From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Pettersson Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: dape Date: Sat, 4 Nov 2023 10:51:04 +0100 Message-ID: References: <46ea1ab1-e447-4c83-9c81-2f9bd149fe91@alphapapa.net> <6964ff20-921e-beff-43a0-9570ea79aa7d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13620"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , John Yates , Krister Schuchardt , Adam Porter , emacs-devel@gnu.org, philipk@posteo.net To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 04 10:52:07 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzDK3-0003In-9k for ged-emacs-devel@m.gmane-mx.org; Sat, 04 Nov 2023 10:52:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzDJJ-0004SL-RT; Sat, 04 Nov 2023 05:51:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzDJH-0004SB-4F for emacs-devel@gnu.org; Sat, 04 Nov 2023 05:51:19 -0400 Original-Received: from mail-qk1-f169.google.com ([209.85.222.169]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzDJF-0004O2-CH for emacs-devel@gnu.org; Sat, 04 Nov 2023 05:51:18 -0400 Original-Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-77891c236fcso190140285a.3 for ; Sat, 04 Nov 2023 02:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699091476; x=1699696276; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7JLIzEHsnBxCYPY6sNSwaC389dPe4EAPhHRWR50iE4k=; b=nTpmAhH14TM+pM+5RWnxIo7M/+MSQAmbUtC2iLL2TcbXeHjVnJY4596ra9DnFq2iZ2 wRVS2ZSXvqrG4oWH97WnA2eJmKBxYBAbO74M7GB3/p/VyUOJaQOiBn7KF6szz9GdpMFC 34pj5MAoXuCxFMzG5qCJNX9ZdzOCJoAc/T4VlUqxGV1QewC+NaH/+FyhOBBPF09yyvnh I06U4gnRw3lVpwaO8FDehTFS1V4W7eRbKPRu0HHMmgqHnoS0KxpuwUemf79JMx9a6BLW c5pzzP15/qOkKZImjZnn6rsCF2p7iCb0nUmBvz/ExDzMW37Px63WtgwXpKScPqH0NmlP /b2A== X-Gm-Message-State: AOJu0YyCSWW8ZyJZwUhDp+Tdg4U5q44BMrIqsTIoCW5Z7bVHedXIQlu2 CmfJkk74PNrpi1M3UmMrOnbflVTFQeF4mHwo X-Google-Smtp-Source: AGHT+IGROfAtIr2+05o/q1a4PWj67NpZIT2xFfMGqPdh1v/rE+6rgPkApAizYKcqID/1zYHFyE+zZQ== X-Received: by 2002:a05:620a:4046:b0:777:71d7:fae8 with SMTP id i6-20020a05620a404600b0077771d7fae8mr26248982qko.50.1699091476078; Sat, 04 Nov 2023 02:51:16 -0700 (PDT) Original-Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com. [209.85.222.41]) by smtp.gmail.com with ESMTPSA id x48-20020a9f3233000000b007b9b2817a6asm657511uad.12.2023.11.04.02.51.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 02:51:15 -0700 (PDT) Original-Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-7ba962d534eso1260697241.3 for ; Sat, 04 Nov 2023 02:51:15 -0700 (PDT) X-Received: by 2002:a1f:9ec7:0:b0:4ab:e701:5d48 with SMTP id h190-20020a1f9ec7000000b004abe7015d48mr5208457vke.14.1699091475378; Sat, 04 Nov 2023 02:51:15 -0700 (PDT) In-Reply-To: X-Gmail-Original-Message-ID: Received-SPF: pass client-ip=209.85.222.169; envelope-from=daniel.dpettersson.net@gmail.com; helo=mail-qk1-f169.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312200 Archived-At: On Wed, Nov 1, 2023 at 7:35=E2=80=AFPM Philip Kaludercic wrote: > Did we ever come to a conclusion on this point? Sorry I have been putting the naming thing off as this thread sparked a bit of interest in the package which lead to a lot of great input and bugfixing. There have been a lot of good suggestions and no consensus which has made the even task harder. On Thu, Nov 2, 2023 at 5:24=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > Just found out about this initiative, great stuff. Thanks for the encouragement. > I especially like the fact that like Eglot, it seems to be completely > language agnostic and doesn't require little dape-.el > add-ons. > > But shouldn't it be using jsonrpc.el? It seems to implement > that base protocol all over again, much like eglot.el did > in its early days. Was this intentional, is there a limitation > in jsonrpc.el that should be addressed? Would be great to reuse jsonrpc but for some extremely strange reason DAP is not an JSONRPC 2.0 protocol. https://microsoft.github.io/debug-adapter-protocol/specification#Base_Proto= col_ProtocolMessage It's close but not close enough, it's able to reuse jsonrpc process filter but it falls to pieces in `jsonrpc-connection-receive', due to slight differences in the protocol. The protocol request/response id is replaced by seq or request_seq and method is command in DAP to name a few differences. If jsonrpc is generalized of any jsonrpc like protocol DAP could make use of it, but I don't know if that would be a good idea. > As to the name, I think "dape" is fine. You would be the first one :) or maybe the second one as someone in the reddit thread said "dape is dope".