From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fejfighter Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 7057c3562ff: * src/pgtkterm.c (mark_pgtkterm): Exclude from MPS builds. Date: Tue, 23 Jul 2024 15:12:37 +1000 Message-ID: References: <171946868539.21672.18232144356511203768@vcs2.savannah.gnu.org> <20240627061127.3F4BCC1FB5B@vcs2.savannah.gnu.org> <875xtuvrhp.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000007ce5d9061de336e1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34391"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, =?UTF-8?Q?Gerd_M=C3=B6llmann?= , pipcet@protonmail.com, Eli Zaretskii To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 23 07:14:18 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sW7qs-0008op-Ir for ged-emacs-devel@m.gmane-mx.org; Tue, 23 Jul 2024 07:14:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sW7pn-0001IB-Kb; Tue, 23 Jul 2024 01:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sW7pV-0000Qd-9U for emacs-devel@gnu.org; Tue, 23 Jul 2024 01:12:55 -0400 Original-Received: from mail-qv1-xf36.google.com ([2607:f8b0:4864:20::f36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sW7pT-0001zS-7H; Tue, 23 Jul 2024 01:12:53 -0400 Original-Received: by mail-qv1-xf36.google.com with SMTP id 6a1803df08f44-6b97097f7fdso14069596d6.0; Mon, 22 Jul 2024 22:12:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721711569; x=1722316369; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4Q0ogaHBKYpeXT8c+ciDBNQ18L0EX3BsB4EJ+qhMIEc=; b=KP2dnrmdqHB/lbDKxYGNLmhL+lERSkS7epAGF51BJJC+Y9wPmV/82g0VvyKKC14/kd 3uWvrE3LvuSYTGFJ1MEotMumdXqzLJJFSBU7oI+u2ow78o6W1DHjvq0oiUECwndjOQKa dK8LPwS6ezZGDcQYoQ6nkffeyje6QBAxjIi09pZlUODjGubU62kezZi5lytDked8t0Eb yrY5c38sIdCDuHs4UIzpR1XYnoz0Pi9H/rGAWHMGCunba0YA4idxpNzTA8wS7HDJuF2S Zwxowh6GYef/Gd8BTdXfOGCJ8bHJsvpyDgq0QLJNK373ceXnlcAE9cnEaCA9dews1486 M8pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721711569; x=1722316369; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Q0ogaHBKYpeXT8c+ciDBNQ18L0EX3BsB4EJ+qhMIEc=; b=P+0Hp11ngfj+MjMF/sP1thyYwZi+cyUKRvKN8sRF+C/NvVVBbIL1GHyEQedjMQAyS6 ZYP2UyQF6plWWKJ4Np+KokZ+thumkV7JetbtXSUjNHIKlEjSU89lifmLgph43J1QeS3h pAZYeu5dZUwvxn5Knocxbe9W0qYTyA9x+08vuAjfAOjaGrkFCeufHjIYZGtUrUYfES1Y hRbju+TSg+BS+nPS2doXS8tfaQh6VolGBv8F+pSozH5+GbLaoEHSo7z/9a5S43teV4Wq QaamVnvsoUOkWyEdKuWByspkUHK2/flPWR84f5Plj33/ODS1P0+nKxwjQ6igI/fCxPvX 5/pQ== X-Forwarded-Encrypted: i=1; AJvYcCWoRWt6ZQmnO6MLuWvIyn1TaRUbWXEHnbSAzu1XTaUKNT+QUw37bO6dd0IgQxEHXcXg37fDfHwv+NZONyA= X-Gm-Message-State: AOJu0Yx5TZCur1fhOIunx7qG1HHd6YdESBQ3KF3MlXpIbpJ7Ugqn7Wph Fn97I0sLbw0A7oD69SzkLQwKUjLkVREVwrt9bGV7zGjOX/S2ax39DFuc1/l+NL72YSX+TEXnhOA WZ7i6xF4loD8tinZgD+uFLv4ySvkxuA== X-Google-Smtp-Source: AGHT+IESzqIcYq06XA4/zEdsX7GQUvfLh+L9WjXynJNCD4U35fgOB52HXTOxQ6qBBDFuqPFlrVb51xGElmS9Oh5lM3Y= X-Received: by 2002:a05:6214:212e:b0:6b5:40d:c2d9 with SMTP id 6a1803df08f44-6b94f0130f3mr136647316d6.19.1721711569186; Mon, 22 Jul 2024 22:12:49 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::f36; envelope-from=fejfighter@gmail.com; helo=mail-qv1-xf36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321969 Archived-At: --0000000000007ce5d9061de336e1 Content-Type: multipart/alternative; boundary="0000000000007ce5d8061de336df" --0000000000007ce5d8061de336df Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Comparing to xterm.c and scanning other parts of the pgtk specific code I only found this as the only allocation unique to PGTK as much of the things xterm needs to worry about is managed by gtk. Could someone apply this patch to the scratch/igc branch please? I also ran the benchmark suite with the latest changes and it's the first time that it has not crashed emacs/oom'd out or otherwise destabilized my machine, It is starting to appear to be more stable for my use cases Thanks for the hard work. Jeff Walsh On Thu, Jun 27, 2024 at 4:51=E2=80=AFPM Fejfighter w= rote: > Yeah that makes sense and is likely the cause of the crashes I have on > that branch, rather than other common code. > > I can't promise I'll have something up soon, but I will try. > > > > On Thu, Jun 27, 2024 at 4:18=E2=80=AFPM Po Lu wrote: > >> Eli Zaretskii writes: >> >> > branch: scratch/igc >> > commit 7057c3562ff373c6061b2b9e6d124fb5f6b90ee5 >> > Author: Jeff Walsh >> > Commit: Eli Zaretskii >> > >> > * src/pgtkterm.c (mark_pgtkterm): Exclude from MPS builds. >> > --- >> > src/pgtkterm.c | 2 ++ >> > 1 file changed, 2 insertions(+) >> > >> > diff --git a/src/pgtkterm.c b/src/pgtkterm.c >> > index 49b7ea406f8..7279f5d863b 100644 >> > --- a/src/pgtkterm.c >> > +++ b/src/pgtkterm.c >> > @@ -336,6 +336,7 @@ evq_flush (struct input_event *hold_quit) >> > return n; >> > } >> > >> > +#ifndef HAVE_MPS >> > void >> > mark_pgtkterm (void) >> > { >> > @@ -369,6 +370,7 @@ mark_pgtkterm (void) >> > mark_object (device->name); >> > } >> > } >> > +#endif >> > >> > char * >> > get_keysym_name (int keysym) >> >> Doesn't this require that device structures be registered and >> deregistered as GC roots when allocated and deallocated? The same >> applies to objects in the module's private event queue. >> > --0000000000007ce5d8061de336df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Comparing to xterm.c and scanning other parts of the = pgtk specific code I only found this as the only allocation unique to PGTK = as much of the things xterm needs to worry about is managed by gtk.

Could someone apply this patch to the scratch/igc branch = please?

I also ran the benchmark suite with th= e latest changes and it's the first time that it has not crashed emacs/= oom'd out or otherwise destabilized my machine,
It is startin= g to appear to be more stable for my use cases=C2=A0

Thanks for the hard work.
Jeff Walsh

On Thu, Jun 27, = 2024 at 4:51=E2=80=AFPM Fejfighter <fejfighter@gmail.com> wrote:
Yeah that makes = sense and is likely the cause of the crashes I have on that branch, rather = than other common code.

I can't promise I'll hav= e something up soon, but I will try.



On Thu, Jun 27, 2024 at 4:18=E2=80=AFPM Po Lu <luangruo@yahoo.com> wrote:
=
Eli Zaretskii <eliz@gnu.org> writes:

> branch: scratch/igc
> commit 7057c3562ff373c6061b2b9e6d124fb5f6b90ee5
> Author: Jeff Walsh <fejfighter@gmail.com>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
>=C2=A0 =C2=A0 =C2=A0* src/pgtkterm.c (mark_pgtkterm): Exclude from MPS = builds.
> ---
>=C2=A0 src/pgtkterm.c | 2 ++
>=C2=A0 1 file changed, 2 insertions(+)
>
> diff --git a/src/pgtkterm.c b/src/pgtkterm.c
> index 49b7ea406f8..7279f5d863b 100644
> --- a/src/pgtkterm.c
> +++ b/src/pgtkterm.c
> @@ -336,6 +336,7 @@ evq_flush (struct input_event *hold_quit)
>=C2=A0 =C2=A0 return n;
>=C2=A0 }
>=C2=A0
> +#ifndef HAVE_MPS
>=C2=A0 void
>=C2=A0 mark_pgtkterm (void)
>=C2=A0 {
> @@ -369,6 +370,7 @@ mark_pgtkterm (void)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0mark_object (device->name);
>=C2=A0 =C2=A0 =C2=A0 }
>=C2=A0 }
> +#endif
>=C2=A0
>=C2=A0 char *
>=C2=A0 get_keysym_name (int keysym)

Doesn't this require that device structures be registered and
deregistered as GC roots when allocated and deallocated?=C2=A0 The same
applies to objects in the module's private event queue.
--0000000000007ce5d8061de336df-- --0000000000007ce5d9061de336e1 Content-Type: application/x-patch; name="0001-src-pgtkterm.c-pgtk_term_init-allocated-dpyinfo-as-a.patch" Content-Disposition: attachment; filename="0001-src-pgtkterm.c-pgtk_term_init-allocated-dpyinfo-as-a.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ly76th4l0 RnJvbSAwNmNlYjMyMzI5ZGU0ZTg5ZTRjNjU5MjllYmVhMDFkOGMzZjAyM2Y0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIFdhbHNoIDxmZWpmaWdodGVyQGdtYWlsLmNvbT4KRGF0 ZTogRnJpLCAyOCBKdW4gMjAyNCAyMToxOTowOSArMTAwMApTdWJqZWN0OiBbUEFUQ0hdICogc3Jj L3BndGt0ZXJtLmMgKHBndGtfdGVybV9pbml0KTogYWxsb2NhdGVkIGRweWluZm8gYXMgYW1iaWcK IHJvb3QKCi0tLQogc3JjL3BndGt0ZXJtLmMgfCAxMCArKysrKysrKysrCiAxIGZpbGUgY2hhbmdl ZCwgMTAgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9wZ3RrdGVybS5jIGIvc3JjL3Bn dGt0ZXJtLmMKaW5kZXggN2VjMDk2OWExNGIuLjgxY2VjMjdlOTIxIDEwMDY0NAotLS0gYS9zcmMv cGd0a3Rlcm0uYworKysgYi9zcmMvcGd0a3Rlcm0uYwpAQCAtNjYsNiArNjYsMTAgQEAgQ29weXJp Z2h0IChDKSAxOTg5LCAxOTkzLTE5OTQsIDIwMDUtMjAwNiwgMjAwOC0yMDI0IEZyZWUgU29mdHdh cmUKICNpbmNsdWRlIDxnZGsvZ2Rrd2F5bGFuZC5oPgogI2VuZGlmCiAKKyNpZmRlZiBIQVZFX01Q UworI2luY2x1ZGUgImlnYy5oIgorI2VuZGlmCisKICNkZWZpbmUgRlJBTUVfQ1JfQ09OVEVYVChm KQkJKChmKS0+b3V0cHV0X2RhdGEucGd0ay0+Y3JfY29udGV4dCkKICNkZWZpbmUgRlJBTUVfQ1Jf QUNUSVZFX0NPTlRFWFQoZikJKChmKS0+b3V0cHV0X2RhdGEucGd0ay0+Y3JfYWN0aXZlKQogI2Rl ZmluZSBGUkFNRV9DUl9TVVJGQUNFKGYpCQkoY2Fpcm9fZ2V0X3RhcmdldCAoRlJBTUVfQ1JfQ09O VEVYVCAoZikpKQpAQCAtNzEyNSw3ICs3MTI5LDEzIEBAICNkZWZpbmUgTlVNX0FSR1YgMTAKICAg ICAgdGhhdCBpc24ndCBzdXBwb3J0ZWQuICAqLwogICBwZ3RrX2Rpc3BsYXlfeF93YXJuaW5nIChk cHkpOwogCisjaWZkZWYgSEFWRV9NUFMKKyAgLy8gRklYTUUvaWdjOiB1c2UgZXhhY3QgcmVmZXJl bmNlcworICBkcHlpbmZvID0gaWdjX3h6YWxsb2NfYW1iaWcgKHNpemVvZiAqZHB5aW5mbyk7Cisj ZWxzZQogICBkcHlpbmZvID0geHphbGxvYyAoc2l6ZW9mICpkcHlpbmZvKTsKKyNlbmRpZgorCiAg IHBndGtfaW5pdGlhbGl6ZV9kaXNwbGF5X2luZm8gKGRweWluZm8pOwogICB0ZXJtaW5hbCA9IHBn dGtfY3JlYXRlX3Rlcm1pbmFsIChkcHlpbmZvKTsKIAotLSAKMi40NS4yCgo= --0000000000007ce5d9061de336e1--