From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Fejfighter Newsgroups: gmane.emacs.devel Subject: Re: MPS and pgtk Date: Thu, 27 Jun 2024 10:26:51 +1000 Message-ID: References: <878qyr6ewh.fsf@disroot.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000a41d62061bd4306a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39283"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Gerd_M=C3=B6llmann?= , Aleksandr Vityazev , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 27 02:28:13 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMczk-000A0z-AR for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Jun 2024 02:28:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMcyu-0002sr-VB; Wed, 26 Jun 2024 20:27:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMcyj-0002rB-DR for emacs-devel@gnu.org; Wed, 26 Jun 2024 20:27:11 -0400 Original-Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMcyg-00084L-I3; Wed, 26 Jun 2024 20:27:08 -0400 Original-Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-79c0e7ec66dso204695985a.1; Wed, 26 Jun 2024 17:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719448023; x=1720052823; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qk7n7t3HF7OXYlt/QFiY3/9J0Yl+gM0kfgOLphTPzYE=; b=c8FhleRHf79JDzqNgvkfOYWnrfX8znm1VToRzOG5ZB4bQ5E6YzJHYld/4iSCvCtRrj LE6vhBRblN4JM6knU17zIQnl7IYYpTpW8JLujWkThlDwJ738U5q33gp40XYwruCHA87L BQD+dRpOSR7DH9URo1I0TVd+xGxnapb5PwvwIb4Mt7oVAkw2XKlEoX005NktdqWmm5eb VegM7JpWTsNuwDsFDEldWJyYF2IUMxkKxh3x8XxafM1NPDQO9ktLW8wJSl9rwD7Bqv/E A65rwTd17qqei0kF90Nk0qippYC7aqg1Ch4WGxS6VAnM4Bo/8v5IwiaakZobDjICRhxm H7OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719448023; x=1720052823; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qk7n7t3HF7OXYlt/QFiY3/9J0Yl+gM0kfgOLphTPzYE=; b=lPWwmNmhbhs6TjxP0jr+6lM/GOzgRsqCn0ibH0+b6InTwYVwiuoOfcXXM3RjlBnBUy OQ9yrgqE4t4i8lCNf9Ql10X1dFiEkRixuRsZ18eM2vXID0Df0hmrjXzJRttA/jly/Jru wxfxEPZO9adwatPMMgNdcmooxKVly6rA34Wy7Pti652nMMf1bmmCXZkoC1fQybaZogBt xBGHiDzSkxIQRPmatUHLE1cm1tdDhvXTboe7gxAdcPEUv3hQJVFLprnU1K3KY6OVZIAj GVd7NuFscpoIKzoR8945W+JwJYN0a4KCDyKNeEF50SgzYhqDrpw+bfGZgZRsb8BxTvDL DOew== X-Forwarded-Encrypted: i=1; AJvYcCXCxY4J77zR+QOuqC4+iAz7zYFWjgNcsK0bBYMXMoQcx/mooY4Mm+GGBHc/2Zc/ZkpQdx+6VXIg0KTdGPO38tVRipDnkMttlJRQK1siCqdEn2k= X-Gm-Message-State: AOJu0YzCGFkF9tydBocTOdmQr0r6CKQGHpjbFGyTuczyfo81X83r+UJd o9XWFc4XYfXUI8rxdPt+eme6Uu90IEOp/Psca/hx9J6s2H88TiKvejgDZ5wNYMlg9S70pzfDnq5 C4XB49gxeAUYk7i0TenIr2iwMxSY= X-Google-Smtp-Source: AGHT+IEMCYfJUrtUigJrno9TfifYUlQ6QFrX5wGKNCH+8HzVQRnzl5ULQnWagl40F6otGuvPCY1ka24SWzCg28xJYDw= X-Received: by 2002:a05:622a:1ba5:b0:444:a34d:9009 with SMTP id d75a77b69052e-444d6466a15mr167804961cf.2.1719448023297; Wed, 26 Jun 2024 17:27:03 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::729; envelope-from=fejfighter@gmail.com; helo=mail-qk1-x729.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320735 Archived-At: --000000000000a41d62061bd4306a Content-Type: multipart/alternative; boundary="000000000000a41d61061bd43068" --000000000000a41d61061bd43068 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I have been loosely tracking the branch, but not with much time to actively participate. Here's a simple patch that will get Aleksandr past the compile issue. I think there are still a couple of places that may catch out parts of gtk/wayland, but this is usually stable for a few minutes. But this branch is fast moving so it's hard to track what's unique. On Thu, Jun 27, 2024 at 8:39=E2=80=AFAM Ergus wrote: > On Wed, Jun 26, 2024 at 06:38:03PM GMT, Gerd M=EF=BF=BDllmann wrote: > >Aleksandr Vityazev writes: > > > >> Hello, > >> > >> I tried to build scratch/igc with the "--with-pgtk" flag > >> got the following errors: > >> > >> make[3]: Leaving directory > '/tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/admin/unidata' > >> CCLD temacs > >> ld: pgtkterm.o: in function `mark_pgtkterm': > >> > /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:3= 57: > undefined reference to `mark_object' > >> ld: > /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:3= 58: > undefined reference to `mark_object' > >> ld: > /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:3= 59: > undefined reference to `mark_object' > >> ld: > /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:3= 60: > undefined reference to `mark_object' > >> ld: > /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:3= 61: > undefined reference to `mark_object' > >> ld: > pgtkterm.o:/tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/p= gtkterm.c:369: > more undefined references to `mark_object' follow > >> collect2: error: ld returned 1 exit status > >> > >> The remaining configuration flags were as follows: > >> --with-mps=3Dyes > >> --with-cairo > >> --with-modules > >> --with-native-compilation=3Dno > >> --disable-build-details > > > >Looks like pgtk is currently not supported, i.e. apparenlty no one > >working on igc is using it, sorry. > > > This is wondering me because all the main distributions/desktops are > moving (or have already moved) to Wayland. > > So, IMHO the pgtk support may be prioritized as it is the only way we > support Wayland natively. > > Not sure if there are plans or alternatives under consideration to > change/improve pgtk, but if igc becomes an issue for it... we may > rethink if we really want it looking to the future? > > WDYT? > Ergus > > --000000000000a41d61061bd43068 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have been loosely tracking the branch, but not with= much time to actively participate.

Here's a s= imple patch that will get Aleksandr past the compile issue.
I thi= nk there are still a couple of places that may catch out parts of gtk/wayla= nd, but this is usually stable for a few minutes.
But this branch= is fast moving so it's hard to track what's unique.

On T= hu, Jun 27, 2024 at 8:39=E2=80=AFAM Ergus <spacibba@aol.com> wrote:
On Wed, Jun 26, 2024 at 06:38:03PM GMT, Gerd M=EF=BF= =BDllmann wrote:
>Aleksandr Vityazev <avityazev@disroot.org> writes:
>
>> Hello,
>>
>> I tried to build scratch/igc with the "--with-pgtk" flag=
>> got the following errors:
>>
>> make[3]: Leaving directory '/tmp/guix-build-emacs-igc-31.0.50-= 0.544e031.drv-0/source/admin/unidata'
>>=C2=A0 =C2=A0CCLD=C2=A0 =C2=A0 =C2=A0temacs
>> ld: pgtkterm.o: in function `mark_pgtkterm':
>> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkt= erm.c:357: undefined reference to `mark_object'
>> ld: /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/p= gtkterm.c:358: undefined reference to `mark_object'
>> ld: /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/p= gtkterm.c:359: undefined reference to `mark_object'
>> ld: /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/p= gtkterm.c:360: undefined reference to `mark_object'
>> ld: /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/p= gtkterm.c:361: undefined reference to `mark_object'
>> ld: pgtkterm.o:/tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/s= ource/src/pgtkterm.c:369: more undefined references to `mark_object' fo= llow
>> collect2: error: ld returned 1 exit status
>>
>> The remaining configuration flags were as follows:
>> --with-mps=3Dyes
>> --with-cairo
>> --with-modules
>> --with-native-compilation=3Dno
>> --disable-build-details
>
>Looks like pgtk is currently not supported, i.e. apparenlty no one
>working on igc is using it, sorry.
>
This is wondering me because all the main distributions/desktops are
moving (or have already moved) to Wayland.

So, IMHO the pgtk support may be prioritized as it is the only way we
support Wayland natively.

Not sure if there are plans or alternatives under consideration to
change/improve pgtk, but if igc becomes an issue for it... we may
rethink if we really want it looking to the future?

WDYT?
Ergus

--000000000000a41d61061bd43068-- --000000000000a41d62061bd4306a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-src-pgtkterm.c-mark_pgtkterm-exclude-from-MPS-builds.patch" Content-Disposition: attachment; filename="0001-src-pgtkterm.c-mark_pgtkterm-exclude-from-MPS-builds.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lxwiupx70 RnJvbSAzMDhjY2I2MTQ1ZjM5MDE2OGY4NDJmMWI0MTM1ZTA4NjhkNDhkNjhiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWZmIFdhbHNoIDxmZWpmaWdodGVyQGdtYWlsLmNvbT4KRGF0 ZTogV2VkLCAyOSBNYXkgMjAyNCAxMjo0MDowMyArMTAwMApTdWJqZWN0OiBbUEFUQ0hdICogc3Jj L3BndGt0ZXJtLmMgKG1hcmtfcGd0a3Rlcm0pOiBleGNsdWRlIGZyb20gTVBTIGJ1aWxkcwoKLS0t CiBzcmMvcGd0a3Rlcm0uYyB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9zcmMvcGd0a3Rlcm0uYyBiL3NyYy9wZ3RrdGVybS5jCmluZGV4IDQ5Yjdl YTQwNmY4Li43Mjc5ZjVkODYzYiAxMDA2NDQKLS0tIGEvc3JjL3BndGt0ZXJtLmMKKysrIGIvc3Jj L3BndGt0ZXJtLmMKQEAgLTMzNiw2ICszMzYsNyBAQCBldnFfZmx1c2ggKHN0cnVjdCBpbnB1dF9l dmVudCAqaG9sZF9xdWl0KQogICByZXR1cm4gbjsKIH0KIAorI2lmbmRlZiBIQVZFX01QUwogdm9p ZAogbWFya19wZ3RrdGVybSAodm9pZCkKIHsKQEAgLTM2OSw2ICszNzAsNyBAQCBtYXJrX3BndGt0 ZXJtICh2b2lkKQogCW1hcmtfb2JqZWN0IChkZXZpY2UtPm5hbWUpOwogICAgIH0KIH0KKyNlbmRp ZgogCiBjaGFyICoKIGdldF9rZXlzeW1fbmFtZSAoaW50IGtleXN5bSkKLS0gCjIuNDUuMgoK --000000000000a41d62061bd4306a--