Re: MPS and pgtk

[Fejfighter <fejfighter@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2471 bytes --]

I have been loosely tracking the branch, but not with much time to actively
participate.

Here's a simple patch that will get Aleksandr past the compile issue.
I think there are still a couple of places that may catch out parts of
gtk/wayland, but this is usually stable for a few minutes.
But this branch is fast moving so it's hard to track what's unique.

On Thu, Jun 27, 2024 at 8:39 AM Ergus <spacibba@aol.com> wrote:

> On Wed, Jun 26, 2024 at 06:38:03PM GMT, Gerd M�llmann wrote:
> >Aleksandr Vityazev <avityazev@disroot.org> writes:
> >
> >> Hello,
> >>
> >> I tried to build scratch/igc with the "--with-pgtk" flag
> >> got the following errors:
> >>
> >> make[3]: Leaving directory
> '/tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/admin/unidata'
> >>   CCLD     temacs
> >> ld: pgtkterm.o: in function `mark_pgtkterm':
> >>
> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:357:
> undefined reference to `mark_object'
> >> ld:
> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:358:
> undefined reference to `mark_object'
> >> ld:
> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:359:
> undefined reference to `mark_object'
> >> ld:
> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:360:
> undefined reference to `mark_object'
> >> ld:
> /tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:361:
> undefined reference to `mark_object'
> >> ld:
> pgtkterm.o:/tmp/guix-build-emacs-igc-31.0.50-0.544e031.drv-0/source/src/pgtkterm.c:369:
> more undefined references to `mark_object' follow
> >> collect2: error: ld returned 1 exit status
> >>
> >> The remaining configuration flags were as follows:
> >> --with-mps=yes
> >> --with-cairo
> >> --with-modules
> >> --with-native-compilation=no
> >> --disable-build-details
> >
> >Looks like pgtk is currently not supported, i.e. apparenlty no one
> >working on igc is using it, sorry.
> >
> This is wondering me because all the main distributions/desktops are
> moving (or have already moved) to Wayland.
>
> So, IMHO the pgtk support may be prioritized as it is the only way we
> support Wayland natively.
>
> Not sure if there are plans or alternatives under consideration to
> change/improve pgtk, but if igc becomes an issue for it... we may
> rethink if we really want it looking to the future?
>
> WDYT?
> Ergus
>
>

[-- Attachment #1.2: Type: text/html, Size: 3121 bytes --]

[-- Attachment #2: 0001-src-pgtkterm.c-mark_pgtkterm-exclude-from-MPS-builds.patch --]
[-- Type: text/x-patch, Size: 681 bytes --]

From 308ccb6145f390168f842f1b4135e0868d48d68b Mon Sep 17 00:00:00 2001
From: Jeff Walsh <fejfighter@gmail.com>
Date: Wed, 29 May 2024 12:40:03 +1000
Subject: [PATCH] * src/pgtkterm.c (mark_pgtkterm): exclude from MPS builds

---
 src/pgtkterm.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 49b7ea406f8..7279f5d863b 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -336,6 +336,7 @@ evq_flush (struct input_event *hold_quit)
   return n;
 }
 
+#ifndef HAVE_MPS
 void
 mark_pgtkterm (void)
 {
@@ -369,6 +370,7 @@ mark_pgtkterm (void)
 	mark_object (device->name);
     }
 }
+#endif
 
 char *
 get_keysym_name (int keysym)
-- 
2.45.2