From: Geoff Gole <geoffgole@gmail.com>
To: Emacs development discussions <emacs-devel@gnu.org>
Subject: xterm.c (x_clear_frame) - commented out call to XClearWindow
Date: Sat, 19 Nov 2011 10:09:57 +0800 [thread overview]
Message-ID: <CALhHxSUyKzx3oHOG8xS-GW+SETKqh=_q3u5P=FRjQGgME_L0Pg@mail.gmail.com> (raw)
In x_clear_frame in in xterm.c, somebody has commented out a call to
XClearWindow:
/* The following call is commented out because it does not seem to accomplish
anything, apart from causing flickering during window resize. */
/* XClearWindow (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f)); */
Unfortunately this results in a strip of pixels at the bottom of the
frame not being updated. You might be able to see it with:
emacs -Q
M-: (set-background-color "black")
Uncommenting the call fixes the problem, but results in the
aforementioned flicker during resize. Can we instead update only the
problematic strip:
{
int covered_pixels = FRAME_TEXT_LINES_TO_PIXEL_HEIGHT (f, FRAME_LINES (f));
int leftover_pixels = FRAME_PIXEL_HEIGHT (f) - covered_pixels;
XClearArea(FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
0, FRAME_PIXEL_HEIGHT (f) - leftover_pixels,
FRAME_PIXEL_WIDTH (f), leftover_pixels,
0);
}
Do I have this right? (I'm not familiar with either frame.c or xterm.c.)
next reply other threads:[~2011-11-19 2:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 2:09 Geoff Gole [this message]
2011-11-21 5:15 ` xterm.c (x_clear_frame) - commented out call to XClearWindow Chong Yidong
2011-11-21 7:19 ` Geoff Gole
2011-11-21 8:54 ` Chong Yidong
2011-11-21 11:36 ` Geoff Gole
2011-11-21 18:02 ` Jan Djärv
2011-11-22 2:38 ` Geoff Gole
2011-11-22 5:31 ` Chong Yidong
2011-11-22 6:41 ` Jan Djärv
2011-11-22 15:37 ` Stefan Monnier
2011-11-23 6:09 ` Chong Yidong
2011-11-29 18:13 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALhHxSUyKzx3oHOG8xS-GW+SETKqh=_q3u5P=FRjQGgME_L0Pg@mail.gmail.com' \
--to=geoffgole@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).