From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Sebastian Wiesner Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Tue, 26 Nov 2013 22:16:04 +0100 Message-ID: References: <3F18D207-3DA2-4003-B995-A8867E8F0140@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1385500567 1365 80.91.229.3 (26 Nov 2013 21:16:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 21:16:07 +0000 (UTC) Cc: Stefan Monnier , Bozhidar Batsov , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 22:16:12 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VlPzP-0006Lb-FH for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 22:16:11 +0100 Original-Received: from localhost ([::1]:32809 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlPzO-0001b3-Ue for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 16:16:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58660) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlPzL-0001an-Iy for emacs-devel@gnu.org; Tue, 26 Nov 2013 16:16:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlPzK-0000gJ-FZ for emacs-devel@gnu.org; Tue, 26 Nov 2013 16:16:07 -0500 Original-Received: from mail-qe0-x22d.google.com ([2607:f8b0:400d:c02::22d]:45151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlPzJ-0000fz-4J; Tue, 26 Nov 2013 16:16:05 -0500 Original-Received: by mail-qe0-f45.google.com with SMTP id 6so6407748qea.32 for ; Tue, 26 Nov 2013 13:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=NWIVgDZ8YwGjedjMw9WL8UO7dm/BrkCAoja2N03WyFg=; b=KnFtc6rOuLr4dIpalyE8edpg7yLU+4MZZ4xzojBCTFLzRX4bD4hKSnF+Wy8g5sgOji HKUWFLb3YWoaVoaEB/bhDoYITIWEEYwwdgIfCfM/9LkCokytbOhDgrsWBiHQiM5/NYgy pKRiiwJz7DzSdOyilyVgBTBJE61XQvKuRd3kZpQK2poNljnItPwNUIoj5sBU1tOnCsFM vUPEuLwNNB0/ogPhyp3+ozo8PrNQjDaQESSVhcYIC4rQ7/t5gK6F7pSOpQG/hm3au6zE OXxTwkuEm00lwnunLzU3m+Oy9RIQ9Uq4wsyrzTYeNCoNR8AE9fsmlvc42/LihBzEvgN4 nh7A== X-Received: by 10.224.40.138 with SMTP id k10mr58611308qae.67.1385500564396; Tue, 26 Nov 2013 13:16:04 -0800 (PST) Original-Received: by 10.224.207.73 with HTTP; Tue, 26 Nov 2013 13:16:04 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c02::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165788 Archived-At: 2013/11/26 Glenn Morris : > > When installing changes by others, please think about the copyright > assignment aspect. The rule is, we can accept no more than 10-15 lines > total (cumulative over all changes) from any one person without an > assignment. Changes that fall under that rule should be marked "(tiny > change") in the ChangeLog. > > I'd say this one qualifies as a tiny change (although it's more than 15 > lines, much of it is mechanical). We would probably need a copyright > assignment to accept any more from this author, though. Meaning, that if I were to write documentation for this feature as well, I'd have to sign a copyright assignment? > Also, please try and use --author when you commit someone else's changes > (Emacs can do this for you). > > > BTW, I think it would be nicer if I could write: > > (put 'comint-run 'interactive-only 'make-comint) > > instead of: > > (put 'comint-run 'interactive-only "Use `make-comint' instead") I agree. I did not think of that. However, a string still needs to be allowed, to handle cases, where there is no single alternative. For instance, "replace-regexp" should be replaced with a while loop over "re-search-forward" and "replace-match". > Also, the installed change is inconsistent as to whether "Use `foo' > instead" should end in a period (I guess it should). Well, the original message did not end in a period, as do all messages in bytecomp.el. Hence, I omitted the period in the messages, but I did not apply much care, since this did not seem so important to me. > Also also, maybe "; use `foo' instead." with no preceding newline would > look better most of the time? I tried, but if the original message, i.e. =E2=80=9Cfoo used from=E2=80=A6d= esigned for interactive use only=E2=80=9D, should be retained, this formatting gives ve= ry long messages in some cases.