unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Robert Pluim <rpluim@gmail.com>
Cc: Philip Kaludercic <philipk@posteo.net>,
	Theodor Thornhill <theo@thornhill.no>,
	emacs-devel <emacs-devel@gnu.org>,
	Stephen Leake <stephen_leake@stephe-leake.org>
Subject: Re: Minor bug in eglot; managed-major-mode must be a list
Date: Tue, 25 Oct 2022 09:33:22 +0100	[thread overview]
Message-ID: <CALDnm53ubc3Y11Tk8vTwPhmtcwQE4rOWi31XYFQDU==yM+-irw@mail.gmail.com> (raw)
In-Reply-To: <8735bdqjs5.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

On Mon, Oct 24, 2022, 17:55 Robert Pluim <rpluim@gmail.com> wrote:

> >>>>> On Mon, 24 Oct 2022 15:54:19 +0000, Philip Kaludercic <
> philipk@posteo.net> said:
>
>     Philip> Robert Pluim <rpluim@gmail.com> writes:
>     >>>>>>> On Mon, 24 Oct 2022 06:49:56 +0200, Theodor Thornhill <
> theo@thornhill.no> said:
>     >>
>     Theodor> I believe eglot has a helper for this - 'eglot--ensure-list',
> maybe
>     Theodor> use that for consistency?
>     >>
>     >> Or even the `ensure-list' from subr.el
>
>     Philip> That was defined in 28.1 but Eglot intends to support versions
> back to
>     Philip> 26.1.  I would suggest using Compat to avoid issues like this
> but that
>     Philip> is a matter of taste.
>
> Iʼd forgotten eglot started life outside emacs :-)
>

Yes. Be sure to read the commentary on the file's header able compatibility
with other Emacs versions, and design philosophy in general. Happy to add
clarifications. Grammar fixes welcome there, too ;-)

Also, please try to CC me in Eglot-related matters, i don't always track
the mailing lists so closely recently.

João

>

[-- Attachment #2: Type: text/html, Size: 2055 bytes --]

  reply	other threads:[~2022-10-25  8:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-23 17:55 Minor bug in eglot; managed-major-mode must be a list Stephen Leake
2022-10-24  4:49 ` Theodor Thornhill
2022-10-24  8:54   ` Robert Pluim
2022-10-24 15:54     ` Philip Kaludercic
2022-10-24 16:16       ` Robert Pluim
2022-10-25  8:33         ` João Távora [this message]
2022-10-25 10:16           ` eglot.el commentary suggestion Robert Pluim
2022-10-25 11:00             ` João Távora
2022-10-25 11:16               ` Po Lu
2022-10-25 12:26                 ` Robert Pluim
2022-10-25 12:51                   ` João Távora
2022-10-25 13:18                     ` Robert Pluim
2022-10-25  8:35 ` Minor bug in eglot; managed-major-mode must be a list João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm53ubc3Y11Tk8vTwPhmtcwQE4rOWi31XYFQDU==yM+-irw@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    --cc=rpluim@gmail.com \
    --cc=stephen_leake@stephe-leake.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).