From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 08c80c45dde: Don't use file-truepath in Eglot (bug#70036) Date: Thu, 18 Apr 2024 17:22:12 +0100 Message-ID: References: <171215083924.12380.5369373861551158668@vcs2.savannah.gnu.org> <20240403132719.A18EFC12C28@vcs2.savannah.gnu.org> <87il0fsufu.fsf@thornhill.no> <86o7a7fcf4.fsf@gnu.org> <878r1bro1g.fsf@thornhill.no> <86zftqd6aw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38859"; mail-complaints-to="usenet@ciao.gmane.io" Cc: theo@thornhill.no, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 18 18:23:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxUXY-0009p1-JL for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Apr 2024 18:23:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxUWy-0007w5-QB; Thu, 18 Apr 2024 12:22:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxUWv-0007vW-UP for emacs-devel@gnu.org; Thu, 18 Apr 2024 12:22:34 -0400 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxUWq-0000XT-9K; Thu, 18 Apr 2024 12:22:30 -0400 Original-Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2d858501412so14432091fa.0; Thu, 18 Apr 2024 09:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713457346; x=1714062146; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m4or5RfXmtjWIBosbHOl9nQgP2k3YXBRWn+xdvmyPNM=; b=MUrds3x0zOxGKOuX9A8Hcak7RVBnhYLxWBeBFUBJf2UzaQNUYENmwFaLJ2+8Vm4qdA 2ODse2mTV7E5d0M95v81no1mk8NfI8SqmpIb6OyyL8e8Ff4NU50+0qJx6v81gWGaSfim kc84a3sZThBuDP93JQW5WBob3bu+qdUgUNd0tkNQu8WNJ6d/+zZc6seTQFt+xLG2H4cB CG1g/nnKV7fxuI5EHDNUXJWSz1xce2E8uqo63EpGSDoARfyb4jd4iIuGTieSKg0bDMU4 wpFw224SdcQ8sv0sOE3sebBSm2lT2u7bG3xo5LBUf8QiQYM06PzWmRP7lnBC2v+xcmDG s1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713457346; x=1714062146; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m4or5RfXmtjWIBosbHOl9nQgP2k3YXBRWn+xdvmyPNM=; b=amM29wCVxmprEakt+3g2wm/WVdLKtmAkCGHEXZ8TpEdNVs++6G0RLdHUyMIMUxUWPO FxbjLUWYzrJyqv1J3Nm7c7nGGKBJUszxj6eIgxALZNqf5UGuE/QFVrNevcu5N5bcj+q/ 2Gqs0EL1lWRaJzOR1Tx4GapY8JWxYimuWIOYcA+5ylZVDLM7suXFatmy5rsVacIpBNch vjT0Cw/wDGK2d3lAvCnLwoJRJ1XBeezeGoGt5+HYsj5Gux3n0x0c1dqzuc1xMn9Tn0Zp 2g/jy2/WWCFSiGHYgGoIqaik/haKauO6vCWA+EHqb25/x7scV49TNqougYN3L8jrI5nv 4wcA== X-Forwarded-Encrypted: i=1; AJvYcCU+2G1re09boZ0MpEd0cahKDNDKBf9g3+NebFFhKnLKKcXu+TaFB7DnO63cWjCXsyOZC6gaeQy5eB1sHt1GzuoExZJM X-Gm-Message-State: AOJu0YwkBoPsSHDtrA5wADRKwseWfBl5mbzQZpVkQ9UPC2kOPnDXIBao Rz0AXJi5og6ZfwZTrtdR/ZYMPvFprfNhXDQpD7H4eqYdsKm9wzOUO3EgpGaen6VuGy2J6d2pMd5 fWshVNgJaZvFf93nBLlKacekZishIdaBr X-Google-Smtp-Source: AGHT+IHI2EqV4P7tujuhQsnbUw1S5vQ4MNm9LjsnaN1f5i3GqTTdeF/TuBI0+zupjNodqPANS/IxWBYUAtHuS1d9euQ= X-Received: by 2002:a2e:a58d:0:b0:2d8:e05f:633e with SMTP id m13-20020a2ea58d000000b002d8e05f633emr2477414ljp.1.1713457345415; Thu, 18 Apr 2024 09:22:25 -0700 (PDT) In-Reply-To: <86zftqd6aw.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::22b; envelope-from=joaotavora@gmail.com; helo=mail-lj1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317820 Archived-At: On Thu, Apr 18, 2024 at 4:44=E2=80=AFPM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 18 Apr 2024 16:00:53 +0100 > > Cc: Eli Zaretskii , emacs-devel@gnu.org > > > > So to summarize: > > > > * we don't use it "everywhere". We use it once where it matters. > > * the "punishment" isn't really severe and the little there was > > of it has been completely avoided with my changes. > > If the last point is true, it should be confirmed by timing the old > and the new code. It is true at least from what I could gather are Theodor's experiments. Theodor states publishDiagnostics is a hotspot, but I couldn't find it in his files emacs-29-before-everything and emacs-30-before. The hotspots I could recognize from that data are 100% solved by my patch. The appeared _faintly_ in my tests (hence the comment about the "severity" of the punishment) and after the patch they don't appear at all. I've asked Theodor to post more data and details about a reproducible experiment. We should start there. I apologize in part for not being present in the beginning when analysing these (one-off and uncommon) performance concerns but I don't think that's a reason for rushing a regression-inducing change. Jo=C3=A3o