From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump)
Date: Mon, 28 Jan 2019 21:38:29 +0000 [thread overview]
Message-ID: <CALDnm53NR_q+y5z7jwA_oNN3BO9-EnzKcaSbi2q37BAJEmcmqg@mail.gmail.com> (raw)
In-Reply-To: <83munk33gj.fsf@gnu.org>
On Mon, Jan 28, 2019 at 8:57 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > I had no idea 'face' was reserved (how could/can I I know this)?
> No need to feel bad, I learned that very recently myself.
Heh, I'm not feeling that bad :-)
But really, is there a list of reserved symbols somewhere? And if this is
reserved for presumably "internal" purposes, couldn't that symbol be
renamed to 'internal--face-id' or something like that? Or are there too
many references?
> > Wouldn't another (perhaps uglier, but easier) fix amount to renaming the
> > face 'flymake-error-face'?
> Not sure how that would help in this matter.
As far as I can understand, this is because flymake-error, the flymake error
type, is conflated with flymake-error, the face. So if the face was
flymake-error-face I think it wouldn't happen. Have to check though, of
course.
> > For any of those, I'm away from my Emacs development machine right now,
> > so it'll have to wait a couple of days, or you someone can beat me to it.
> There's no rush.
OK.
--
João Távora
next prev parent reply other threads:[~2019-01-28 21:38 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190128152540.6870.46132@vcs0.savannah.gnu.org>
[not found] ` <20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
2019-01-28 16:05 ` [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Daniel Colascione
2019-01-28 18:14 ` Eli Zaretskii
2019-01-28 19:37 ` Daniel Colascione
2019-01-28 20:19 ` Eli Zaretskii
2019-01-28 17:58 ` Glenn Morris
2019-01-28 20:05 ` Eli Zaretskii
2019-01-28 20:12 ` Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-28 20:39 ` João Távora
2019-01-28 20:57 ` Eli Zaretskii
2019-01-28 21:38 ` João Távora [this message]
2019-01-29 16:54 ` Eli Zaretskii
[not found] ` <CALDnm53FnkT+fjneg3uLNMsCu1MxJK1aKWQyvz85EjVdOyr4bg@mail.gmail.com>
2019-01-29 17:26 ` Fwd: " João Távora
2019-01-29 17:51 ` Eli Zaretskii
2019-01-29 17:54 ` Daniel Colascione
2019-01-29 18:30 ` Eli Zaretskii
2019-01-29 18:43 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:19 ` Eli Zaretskii
2019-01-29 18:47 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) João Távora
2019-01-29 18:53 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:00 ` João Távora
2019-01-29 19:21 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-29 19:28 ` João Távora
2019-01-29 18:28 ` João Távora
2019-01-29 18:34 ` Fwd: Flymake and the 'face' property Johan Bockgård
2019-01-29 18:49 ` João Távora
2019-01-29 19:17 ` Eli Zaretskii
2019-01-29 19:33 ` João Távora
2019-01-29 19:48 ` Eli Zaretskii
2019-01-29 19:58 ` João Távora
2019-01-30 9:37 ` Stefan Monnier
2019-01-30 15:40 ` Eli Zaretskii
2019-01-30 17:05 ` João Távora
2019-01-30 18:01 ` Eli Zaretskii
2019-01-30 20:56 ` Stefan Monnier
2019-01-31 3:38 ` Eli Zaretskii
2019-02-02 8:23 ` Stefan Monnier
2019-02-02 10:12 ` Eli Zaretskii
2019-02-02 22:49 ` Stefan Monnier
2019-02-03 3:39 ` Eli Zaretskii
2019-02-03 12:35 ` Stefan Monnier
2019-01-29 17:52 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm53NR_q+y5z7jwA_oNN3BO9-EnzKcaSbi2q37BAJEmcmqg@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).