From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Landing feature/more-fds for Emacs 30? Date: Wed, 15 Mar 2023 18:02:01 +0000 Message-ID: References: <87wn3hud8z.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c31bfc05f6f42466" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20931"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Elliott Shugerman , emacs-devel To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 15 19:02:56 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcVSi-0005J6-KY for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Mar 2023 19:02:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcVS8-0000bx-OJ; Wed, 15 Mar 2023 14:02:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcVS4-0000Ud-Ez for emacs-devel@gnu.org; Wed, 15 Mar 2023 14:02:16 -0400 Original-Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcVS2-0004q5-AY for emacs-devel@gnu.org; Wed, 15 Mar 2023 14:02:16 -0400 Original-Received: by mail-oi1-x233.google.com with SMTP id bo10so3608502oib.11 for ; Wed, 15 Mar 2023 11:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678903332; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rtJ+2ZrEUqJNS46iWhuWCnSTTdqoAfis3vMtnUTtXQA=; b=DEhT7ser3bfN27rCwwHegHDTDrZ9DUT55ojgq7FX66VJD946mlApGHBvySwRo+2bTB U8nMncjUIK2VRJxkFV0EK+LbRIGfkZ0uk6Pj+9MtsJIb+7YZC/SPKmIuGR12f2SN8+Bj W2yWlRUmWBDW+6ppoINHTrjeM8EzT6Yb4s0ZtYRBQxYId+uqX3ORJc5YZmYYKSunSgJP d4wamhyotofpDfn4lzwoEyXjT0glTUVqnsrX592fVhRmKG0B8NFxY1YOHSsExlRz8h58 oEYmkUcyTYpZRALRiHgrRm3mFL7kHV2bqXOqLmQlvw9LCzT03tFLT37idKF6m8Lx/65z 0IHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678903332; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rtJ+2ZrEUqJNS46iWhuWCnSTTdqoAfis3vMtnUTtXQA=; b=a76gQQNlsH6APH4Zt/CzGUs8tRidT/VdL6u34MqSNThFCejcXVLwLETRkYdoxyjM55 LpgV7TI0caxkZ1PzVMderwUlwll+Dnekf69xyXcO9P4iAUBG6+8Tgo5mGhnMBt7Ov+8E aZW2Ww5UOAoieungJh9u90H/10YFlV9m6gQJbvYeboGOIPrYRq9rPj53uCQd3XCmdZ7U ANdvVGIg4DbybsGH/MYiTou1WpY0IEOVxnUMWCfv9tSp3hNgXK155WBKWCl5RqTRV8fu zfB4pf01W7IPiVDHUPAJxFJMH7NzupmCYK/VGKLJFvKNOEqenqTCrQVlzs1lD/ClsRzH jDng== X-Gm-Message-State: AO0yUKXi7J193dhE/NHv56424XEp4GyhWeaCm5/MR0p6m0rjlbMD0ZH9 h9NE6pczATZJNFz3iXrPx6QLnN/hl/RSBF0vHt4= X-Google-Smtp-Source: AK7set+wGczUK/SwWdtRrPSs6OzbBHd5qQ4c7a7MnFTMbLKYZLfrUAQ1cdEz5u5HUf5GQ/vtmzpIWwe3JRt/dNNt+z8= X-Received: by 2002:aca:1c19:0:b0:384:6d14:c707 with SMTP id c25-20020aca1c19000000b003846d14c707mr1055487oic.5.1678903332771; Wed, 15 Mar 2023 11:02:12 -0700 (PDT) In-Reply-To: <87wn3hud8z.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304503 Archived-At: --000000000000c31bfc05f6f42466 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Mar 15, 2023, 17:37 Robert Pluim wrote: > >>>>> On Wed, 15 Mar 2023 17:12:19 +0000, Jo=C3=A3o T=C3=A1vora < > joaotavora@gmail.com> said: > > Jo=C3=A3o> Hi Elliott, > Jo=C3=A3o> On Tue, Mar 14, 2023, 16:10 Elliott Shugerman < > eeshugerman@gmail.com> wrote: > > >> > >> I work on a large codebase with LSP and used to run into the "too > many > >> open files" error all the time unless I disabled desired > functionality or > >> gave up native-comp. Now, with this patch, not only is that issue > gone > >> entirely, but I find Emacs is generally more responsive and stable > on macOS. > >> > > Jo=C3=A3o> What LSP server are you using? Is it perhaps requesting ma= ny > file watchers? > Jo=C3=A3o> Or maybe the client is overwatching on the Emacs side (wha= t > client are you > Jo=C3=A3o> using?). Do you have a JSONRPC transcript that you can sha= re > with me? > > It=CA=BCs a macOS thing: file watching there uses a file descriptor > per-file, unlike Linux, which uses one per-directory. > Yes, for sure that should be improved. But the watches that the client are could also be reduced, perhaps. Maybe, depending on the use case, it makes sense to only watch files on behalf of the LSP that Emacs is actually visiting (Eglot doesn't do that, but maybe it could). All depends on the use case, and that's what I'm interested in. Jo=C3=A3o > --000000000000c31bfc05f6f42466 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Mar 15, 2023, 17:37 Robert Pluim <rpluim@gmail.com> wrote:
>>>>> On Wed, 15 Mar 2023 17:12:19 +0000, Jo= =C3=A3o T=C3=A1vora <joaotavora@gmail.com> said:

=C2=A0 =C2=A0 Jo=C3=A3o> Hi Elliott,
=C2=A0 =C2=A0 Jo=C3=A3o> On Tue, Mar 14, 2023, 16:10 Elliott Shugerman &= lt;eeshugerman@gmail.com> wrote:

=C2=A0 =C2=A0 >>
=C2=A0 =C2=A0 >> I work on a large codebase with LSP and used to run = into the "too many
=C2=A0 =C2=A0 >> open files" error all the time unless I disable= d desired functionality or
=C2=A0 =C2=A0 >> gave up native-comp. Now, with this patch, not only = is that issue gone
=C2=A0 =C2=A0 >> entirely, but I find Emacs is generally more respons= ive and stable on macOS.
=C2=A0 =C2=A0 >>

=C2=A0 =C2=A0 Jo=C3=A3o> What LSP server are you using? Is it perhaps re= questing many file watchers?
=C2=A0 =C2=A0 Jo=C3=A3o> Or maybe the client is overwatching on the Emac= s side (what client are you
=C2=A0 =C2=A0 Jo=C3=A3o> using?). Do you have a JSONRPC transcript that = you can share with me?

It=CA=BCs a macOS thing: file watching there uses a file descriptor
per-file, unlike Linux, which uses one per-directory.

Yes, for sure that sho= uld be improved.

But the= watches that the client are could also be reduced, perhaps. Maybe, dependi= ng on the use case, it makes sense to only watch files on behalf of the LSP= that Emacs is actually visiting (Eglot doesn't do that, but maybe it c= ould). All depends on the use case, and that's what I'm interested = in.

Jo=C3=A3o
--000000000000c31bfc05f6f42466--