From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master e4896fc 1/2: Add a new 'flex' completion style Date: Thu, 14 Feb 2019 14:40:53 +0000 Message-ID: References: <20190213212413.868.40960@vcs0.savannah.gnu.org> <20190213212414.D6F4C209C6@vcs0.savannah.gnu.org> <83o97eo2pu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240335"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Robert Pluim , emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 14 15:58:29 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1guIT2-0010IH-Bc for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 15:58:24 +0100 Original-Received: from localhost ([127.0.0.1]:49795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guIT1-0007VX-Af for ged-emacs-devel@m.gmane.org; Thu, 14 Feb 2019 09:58:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1guINB-0002gE-Ck for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:52:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1guICM-0002fb-6h for emacs-devel@gnu.org; Thu, 14 Feb 2019 09:41:10 -0500 Original-Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:44959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1guICI-0002b3-1V; Thu, 14 Feb 2019 09:41:06 -0500 Original-Received: by mail-qt1-x82f.google.com with SMTP id n32so7012022qte.11; Thu, 14 Feb 2019 06:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TXUqIYFqWRHfJEVyCEzcFrV6PUr7A7jtUMauusHf12E=; b=TTv7eyWnCFF9wFq+y8EhDr01d6pK53eyVOxdJloaX8L4F97OHIYCirK43UKD01j/sX mEiRMN0y0VaQ3vUhZmSeH02t65UvBw9gvtLRwM8XT8PRd59WvolG40iL6csnSCY85MlR 5jrDNySvYYORjnPLaYa6HENt22Y3w2a4URuOiUKQsILrVnloeAD4pXbxjBI5c8IkI++t nmdW9NVKP0r+UhRj/SUh593MztODFLuwTtE12q/IVfPciX/51WL+vpMruQS08pPpEHj9 EEsCDKLatZ+It8JBizuYlJnS8GQA6CrUfLTkyACkti1n10g3aG2sbTGGZY3//6KWdx2b pyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TXUqIYFqWRHfJEVyCEzcFrV6PUr7A7jtUMauusHf12E=; b=dPgyAV+sGQVDr/20XtT9UNndEDOmt5juL2ljNz4OnAn4Ej/6zKjyFprPr1umqnIvSL iLZ+UGhZvjUV8iRwWS+HryPfAkvrFp2cc/6H5BLTKE7VkuHRzzyaJq/WcGXfy1E21y5/ EQxnS5AkqV+3kMaBvNfxCzWdUnTnc/d8N6Eq8Mu6ofG9FcqSQQrkkGQEcx7NpQlEI6ii 8/f6irg45qqj/KqlPODoIEHvZcxx6x8XUC2bm6sTcalnWkQNTQCB0knWPV/74koxHmPw gwhThvD67rVaYNdAT57yiHwww4v23fUZni+gbGIVdqwrFiYCj+w2C9F4VlX8dbIV+XuS 87+g== X-Gm-Message-State: AHQUAubEwOb2Mar8cD/oVWMmMV0dr0vwU3M+0BHgQnoy0dykIZaDUYnI paTpZVGtLecs/HxNQh9+YTHuGbmV7notqg5Wr18pdA== X-Google-Smtp-Source: AHgI3IYV9ltqkdb2aSFfGojgPnqfHq+pt6wrU3FISuXvrTBDSEqdqedacsD6NO+05s7VyV37K0l5sQNQjNb9aeIOVak= X-Received: by 2002:aed:2a6d:: with SMTP id k42mr3479111qtf.390.1550155265155; Thu, 14 Feb 2019 06:41:05 -0800 (PST) In-Reply-To: <83o97eo2pu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233322 Archived-At: On Thu, Feb 14, 2019 at 2:37 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 14 Feb 2019 13:50:15 +0000 > > Cc: emacs-devel > > > > > I=CA=BCm all in favour of respect, but what does that mean in the con= text > > > of PRED and POINT? > > > > It means M-x checkdoc shuts up about it, that's what it means :-) > > (or rather flymake's checkdoc backend stops underlining it). > > > > It also means I'll think twice about adding docstrings to functions > > I modify, even internal functions. > > > > > What is 'PCM-style'? What does 'massaged' mean? What is the signature= of > > > TRANSFORM-PATTERN-FN? > > > > "It be" take a pattern, and it be return a pattern. > > > > To be clear, I agree this isn't the best docstring in the world. Is it > > better than what was before, which was nothing? Perhaps that's > > arguable and I shouldn't have added it in the first place, forcing > > err inviting people like me to go read the source code. Doing > > a good docstring is hard and I usually reserve those efforts for > > user-visible functions. You could have very well asked me > > what exactly a "PCM-style substring pattern" is, since that's > > just as loosely defined as everything else around those > > parts. > > There's no reason to feel offended by Robert's comments. They mean > well: to make our doc strings better. They don't mean your change > wasn't an improvement, and surely weren't meant to offend you. > > Thanks for making those changes. Sorry, I didn't _feel_ offended. Sorry if I _sounded_ offended and/or aggressive. Thanks Robert :-)