From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [External] : Re: Adding refactoring capabilities to Emacs Date: Fri, 29 Sep 2023 14:19:48 +0100 Message-ID: References: <83fs4f36wi.fsf@gnu.org> <1b963d24-51b3-8128-ad14-e4af2c9f0c43@gutov.dev> <8408fa63-af93-ab36-8524-fa12de7918ea@gutov.dev> <87pm25qck5.fsf@posteo.net> <83a5t51d21.fsf@gnu.org> <87jzs95fh5.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32496"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , Eli Zaretskii , "Alfred M. Szmidt" , drew.adams@oracle.com, dmitry@gutov.dev, philipk@posteo.net, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 29 15:17:49 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmDNN-00088K-Ek for ged-emacs-devel@m.gmane-mx.org; Fri, 29 Sep 2023 15:17:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmDMm-0002U9-LB; Fri, 29 Sep 2023 09:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmDMl-0002Tu-Km for emacs-devel@gnu.org; Fri, 29 Sep 2023 09:17:11 -0400 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmDMj-0005pa-4O; Fri, 29 Sep 2023 09:17:11 -0400 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50567477b29so2183639e87.3; Fri, 29 Sep 2023 06:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695993426; x=1696598226; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Rj4JXOvDbJdRocILrPumqmhXkqiYElyqjmzeSdrYRrs=; b=Kb/itwPjlQbrzhcf148yvZpoBOs49vRnqYjzOpmQ33vlmlrZsfHJxfZ1AwZrmWfybJ kwx2b3V4HNijPPaYL8FEiZONrLGZ279yhWOO0RNncGDAoYKxwIHJ/SZtT5u2m5SRpZt2 XCycCVWJwgPglVVrYCjmU7cc1CaS5kZITkv40XIaFj5pYSbFufpTeutaR+e0g6l+RxiE WUZlHdWHqVWrmF4J3wCQuNq4zpa5X5k5uE7vK72H5hqx0/q3hc6/fSbHf04tNGXeJW1g 4iuGkQBWUijJmB6QGsFG19B+stACMnkZeA6CqbMkrk1Idnu1EToXKIOb+otHzvy999Vd Dj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695993426; x=1696598226; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rj4JXOvDbJdRocILrPumqmhXkqiYElyqjmzeSdrYRrs=; b=TOf66RPIlX4/Tx3YLDPGLlhTcn2pX4ipjXGzbY0lJqhaiG9dNUzdfyjLCayJvVd0vu D5omER+evRvKbHYkW4HtE3KMBjcEQKR049trX7BNM8qlszwFGx5r2ufnN+H8ySumOlr5 Khko4KF9faD3LRmYMIELbEDU8zVQnTvVGFBI/Oa4N10KWTgn2Im34ne0vfxoIWl6rT9N 7+0p125zI2SoPnpn7gq239WltYzLoHZyXw9XewGT1TB9yVT1Erdy7dscVuOOdoEjel1X rwF0sKM13fFAIrwxuizbE0uZhJoOvTnPcz+uuaeLobsSO4BJxTtWH30u/UXR5Qo0Uci/ Lueg== X-Gm-Message-State: AOJu0YxixSIaPxqSSXuvbl2FhjSWn7mZ5MZB+vwik8/GQqKxBzqMaVf+ LKQbU3vHP+Cml7g7zWuoEPwNcF7G0ZIyBibqqMg= X-Google-Smtp-Source: AGHT+IFTDD3wChU0NiFfp5IrG0+qvt1D+Ld9kI7Kzvn26IK/gY2mmnssS/sZHrO/pTXNgqTA1cN3MpIqZTomQqorXR4= X-Received: by 2002:a05:6512:6c6:b0:503:7dd:7ebf with SMTP id u6-20020a05651206c600b0050307dd7ebfmr4570206lff.63.1695993426343; Fri, 29 Sep 2023 06:17:06 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311157 Archived-At: On Fri, Sep 29, 2023 at 2:16=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Fri, Sep 29, 2023 at 2:11=E2=80=AFPM Stefan Monnier wrote: > > > > > "C-x C-q" in an "occur" buffer still leaves some non-useful key > > > bindings around, like for "DEL". To usefully edit an "occur" buffer > > > you need to run `occur-edit-mode', bound to "e" by default. We could > > > fix that wart if we wanted to. > > > > We should "merge" `C-x C-q` and `e`, indeed, like we do for Dired. > > Yes, and isn't a buffer-local value for read-only-mode-hook the > suitable way to fix that? For context, I'm asking because I don't think rebinding `C-x C-q` to a different command (like in the case of Dired) is as good as using the existing hook. It should be much more consistent to use the standard facilities of the existing minor mode. Likewise, I don't think having "-read-only" or "-edit" variations of each major mode is a good idea. We can activate and deactivate keymaps on the fly right? Jo=C3=A3o