* Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 [not found] ` <20190115160813.EFFD4209E3@vcs0.savannah.gnu.org> @ 2019-01-15 23:30 ` Michael Albinus 2019-01-16 18:05 ` Alan Mackenzie 2019-01-16 19:49 ` Ted Zlatanov 1 sibling, 1 reply; 5+ messages in thread From: Michael Albinus @ 2019-01-15 23:30 UTC (permalink / raw) To: emacs-devel; +Cc: Alan Mackenzie acm@muc.de (Alan Mackenzie) writes: Hi Alan, > branch: master > commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692 > Author: Alan Mackenzie <acm@muc.de> > Commit: Alan Mackenzie <acm@muc.de> > > Make CC Mode and electric-pair-mode work together. This fixes bug #33794 This seems to break electric-tests.el: --8<---------------cut here---------------start------------->8--- # make -C test electric-tests Ran 475 tests, 387 results as expected, 88 unexpected (2019-01-16 00:28:55+0100, 214.752138 sec) 1 expected failures 88 unexpected results: FAILED electric-layout-int-main-allman-style FAILED electric-layout-int-main-kernel-style FAILED electric-pair-angle-brackets-everywhere-2-at-point-2-in-c++-mode FAILED electric-pair-angle-brackets-everywhere-2-at-point-3-in-c++-mode FAILED electric-pair-angle-brackets-everywhere-2-at-point-3-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-everywhere-2-at-point-4-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-everywhere-2-at-point-5-in-c++-mode-in-comments FAILED electric-pair-angle-brackets-everywhere-2-at-point-6-in-c++-mode-in-comments FAILED electric-pair-angle-brackets-everywhere-at-point-1-in-c++-mode FAILED electric-pair-angle-brackets-everywhere-at-point-2-in-c++-mode FAILED electric-pair-angle-brackets-everywhere-at-point-2-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-everywhere-at-point-3-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-everywhere-at-point-4-in-c++-mode-in-comments FAILED electric-pair-angle-brackets-everywhere-at-point-5-in-c++-mode-in-comments FAILED electric-pair-angle-brackets-pair-at-point-2-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-pair-at-point-4-in-c++-mode-in-comments FAILED electric-pair-angle-brackets-skip-at-point-3-in-c++-mode-in-strings FAILED electric-pair-angle-brackets-skip-at-point-5-in-c++-mode-in-comments FAILED electric-pair-autopair-keep-least-amount-of-mixed-unbalance-at-point-3-in-c++-mode-in-strings FAILED electric-pair-autopair-keep-least-amount-of-mixed-unbalance-at-point-5-in-c++-mode-in-comments FAILED electric-pair-autowrapping-1-at-point-2-in-c++-mode-in-strings FAILED electric-pair-autowrapping-1-at-point-4-in-c++-mode-in-comments FAILED electric-pair-autowrapping-2-at-point-2-in-c++-mode-in-strings FAILED electric-pair-autowrapping-2-at-point-4-in-c++-mode-in-comments FAILED electric-pair-autowrapping-3-at-point-2-in-c++-mode-in-strings FAILED electric-pair-autowrapping-3-at-point-4-in-c++-mode-in-comments FAILED electric-pair-autowrapping-4-at-point-2-in-c++-mode-in-strings FAILED electric-pair-autowrapping-4-at-point-4-in-c++-mode-in-comments FAILED electric-pair-balanced-autoskipping-at-point-5-in-c++-mode-in-strings FAILED electric-pair-balanced-autoskipping-at-point-6-in-c++-mode-in-strings FAILED electric-pair-balanced-autoskipping-at-point-7-in-c++-mode-in-comments FAILED electric-pair-balanced-autoskipping-at-point-8-in-c++-mode-in-comments FAILED electric-pair-ignore-different-nonmatching-paren-type-at-point-3-in-c++-mode-in-strings FAILED electric-pair-ignore-different-nonmatching-paren-type-at-point-5-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-1-at-point-3-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-1-at-point-5-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-1-at-point-5-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-1-at-point-7-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-2-at-point-3-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-2-at-point-5-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-2-at-point-5-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-2-at-point-6-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-2-at-point-7-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-2-at-point-8-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-3-at-point-5-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-3-at-point-6-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-3-at-point-7-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-3-at-point-8-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-4-at-point-5-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-4-at-point-7-in-c++-mode-in-comments FAILED electric-pair-mixed-paren-5-at-point-6-in-c++-mode-in-strings FAILED electric-pair-mixed-paren-5-at-point-8-in-c++-mode-in-comments FAILED electric-pair-only-skip-over-at-least-partially-balanced-stuff-at-point-7-in-c++-mode-in-strings FAILED electric-pair-only-skip-over-at-least-partially-balanced-stuff-at-point-9-in-c++-mode-in-comments FAILED electric-pair-skip-over-partially-balanced-at-point-7-in-c++-mode-in-strings FAILED electric-pair-skip-over-partially-balanced-at-point-9-in-c++-mode-in-comments FAILED electric-pair-too-many-closings-at-point-10-in-c++-mode-in-comments FAILED electric-pair-too-many-closings-at-point-8-in-c++-mode-in-strings FAILED electric-pair-too-many-closings-autoskipping-at-point-5-in-c++-mode-in-strings FAILED electric-pair-too-many-closings-autoskipping-at-point-6-in-c++-mode-in-strings FAILED electric-pair-too-many-closings-autoskipping-at-point-7-in-c++-mode-in-comments FAILED electric-pair-too-many-closings-autoskipping-at-point-7-in-c++-mode-in-strings FAILED electric-pair-too-many-closings-autoskipping-at-point-8-in-c++-mode-in-comments FAILED electric-pair-too-many-closings-autoskipping-at-point-9-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-10-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-2-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-3-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-4-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-4-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-5-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-5-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-6-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-6-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-7-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-7-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-8-in-c++-mode-in-comments FAILED electric-pair-too-many-openings-at-point-8-in-c++-mode-in-strings FAILED electric-pair-too-many-openings-at-point-9-in-c++-mode-in-comments FAILED electric-pair-whitespace-chomping-at-point-4-in-c++-mode-in-strings FAILED electric-pair-whitespace-chomping-at-point-6-in-c++-mode-in-comments FAILED electric-pair-whitespace-jumping-at-point-4-in-c++-mode-in-strings FAILED electric-pair-whitespace-jumping-at-point-5-in-c++-mode-in-strings FAILED electric-pair-whitespace-jumping-at-point-6-in-c++-mode-in-comments FAILED electric-pair-whitespace-jumping-at-point-6-in-c++-mode-in-strings FAILED electric-pair-whitespace-jumping-at-point-7-in-c++-mode-in-comments FAILED electric-pair-whitespace-jumping-at-point-7-in-c++-mode-in-strings FAILED electric-pair-whitespace-jumping-at-point-8-in-c++-mode-in-comments FAILED electric-pair-whitespace-jumping-at-point-9-in-c++-mode-in-comments make[1]: *** [Makefile:183: lisp/electric-tests.log] Error 1 make[1]: Leaving directory '/usr/local/src/emacs/test' make: *** [Makefile:248: lisp/electric-tests] Error 2 make: Leaving directory '/usr/local/src/emacs/test' --8<---------------cut here---------------end--------------->8--- Best regards, Michael. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 2019-01-15 23:30 ` master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 Michael Albinus @ 2019-01-16 18:05 ` Alan Mackenzie 2019-01-17 15:47 ` João Távora 0 siblings, 1 reply; 5+ messages in thread From: Alan Mackenzie @ 2019-01-16 18:05 UTC (permalink / raw) To: Michael Albinus; +Cc: emacs-devel Hello, Michael. On Wed, Jan 16, 2019 at 00:30:26 +0100, Michael Albinus wrote: > acm@muc.de (Alan Mackenzie) writes: > Hi Alan, > > branch: master > > commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692 > > Author: Alan Mackenzie <acm@muc.de> > > Commit: Alan Mackenzie <acm@muc.de> > > Make CC Mode and electric-pair-mode work together. This fixes bug #33794 > This seems to break electric-tests.el: Thanks! Part of the problem is in CC Mode, still. Another part of the problem is electric-tests.el making assumptions about CC Mode's implementation (which has recently changed). Thanks for reminding me to run make check. ;-( Incidentally, there's a test engine in electric-tests.el which is 100% undocumented (no doc string, no comments in functions like electric-pair-test-for and electric-pair-define-test-form). It would be appreciated if anybody reading this who understands any of these functions could add doc strings to them. > --8<---------------cut here---------------start------------->8--- > # make -C test electric-tests > Ran 475 tests, 387 results as expected, 88 unexpected (2019-01-16 00:28:55+0100, 214.752138 sec) > 1 expected failures > 88 unexpected results: > FAILED electric-layout-int-main-allman-style > FAILED electric-layout-int-main-kernel-style [ .... ] > FAILED electric-pair-whitespace-jumping-at-point-8-in-c++-mode-in-comments > FAILED electric-pair-whitespace-jumping-at-point-9-in-c++-mode-in-comments [ .... ] > Best regards, Michael. -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 2019-01-16 18:05 ` Alan Mackenzie @ 2019-01-17 15:47 ` João Távora 0 siblings, 0 replies; 5+ messages in thread From: João Távora @ 2019-01-17 15:47 UTC (permalink / raw) To: Alan Mackenzie; +Cc: Michael Albinus, emacs-devel Hi Alan, On Wed, Jan 16, 2019 at 6:18 PM Alan Mackenzie <acm@muc.de> wrote: > Thanks! Part of the problem is in CC Mode, still. Another part of the > problem is electric-tests.el making assumptions about CC Mode's > implementation (which has recently changed). Can you be specific as to what "assumptions about CC Mode's implementation" it is making? As I read it, the assumptions are this: - Create a buffer, assumes the buffer is created - Enable a specific major mode, assumes major mode is enabled. (does not M-x c++-mode RET enable c++-mode?) - Insert as string, assumes the string is inserted - Enable electric-pair-mode, assumes it succeeds - Simulate typing a key such as {, or ', or } This is done by by (call-interactively (key-binding `[,last-command-event])) Tests then verify if electric-pair-mode did what it was supposed to do. This is not an assumption, it is a verification. "what is was supposed to do" is given by M-x ert-describe-test, which basiclly restates the above assumptions in a more readable format. > Incidentally, there's a test engine in electric-tests.el which is 100% > undocumented (no doc string, no comments in functions like > electric-pair-test-for and electric-pair-define-test-form). It would be > appreciated if anybody reading this who understands any of these > functions could add doc strings to them. We've already been through this 6+ months ago. At the time I told you about M-x ert-describe-test and I even improved it at your request! M-x ert-describe-test RET <failed-test-name> RET Here's an example: electric-pair-js-mode-braces-at-point-1-in-js-mode is a test defined in `electric-tests.elc'. Electricity test in a `js-mode' buffer. Start with point at 1 in a 0-char-long buffer like this one: || (buffer start and end are denoted by `|') Now call this: #'(lambda nil (electric-pair-mode 1)) Now press the key for: { The buffer's contents should become: |{}| , and point should be at 2. João ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 [not found] ` <20190115160813.EFFD4209E3@vcs0.savannah.gnu.org> 2019-01-15 23:30 ` master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 Michael Albinus @ 2019-01-16 19:49 ` Ted Zlatanov 2019-01-17 9:27 ` Alan Mackenzie 1 sibling, 1 reply; 5+ messages in thread From: Ted Zlatanov @ 2019-01-16 19:49 UTC (permalink / raw) To: emacs-devel; +Cc: Alan Mackenzie On Tue, 15 Jan 2019 11:08:13 -0500 (EST) acm@muc.de (Alan Mackenzie) wrote: AM> branch: master AM> commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692 AM> Author: Alan Mackenzie <acm@muc.de> AM> Commit: Alan Mackenzie <acm@muc.de> Hi Alan, I think this change broke the automated tests in https://emba.gnu.org/emacs/emacs/pipelines (which are just the Emacs tests supposedly). I have not had a chance to open EMBA to public access but it would be quick to give you access right now, if that would help debug it. Ted ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 2019-01-16 19:49 ` Ted Zlatanov @ 2019-01-17 9:27 ` Alan Mackenzie 0 siblings, 0 replies; 5+ messages in thread From: Alan Mackenzie @ 2019-01-17 9:27 UTC (permalink / raw) To: Ted Zlatanov; +Cc: emacs-devel Hello, Ted. On Wed, Jan 16, 2019 at 19:49:38 +0000, Ted Zlatanov wrote: > On Tue, 15 Jan 2019 11:08:13 -0500 (EST) acm@muc.de (Alan Mackenzie) wrote: > AM> branch: master > AM> commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692 > AM> Author: Alan Mackenzie <acm@muc.de> > AM> Commit: Alan Mackenzie <acm@muc.de> > Hi Alan, > I think this change broke the automated tests in > https://emba.gnu.org/emacs/emacs/pipelines (which are just the Emacs > tests supposedly). > I have not had a chance to open EMBA to public access but it would be > quick to give you access right now, if that would help debug it. Thanks, but I've already seen a more detailed list of test failures, so I don't think such access would help me at the moment. > Ted -- Alan Mackenzie (Nuremberg, Germany). ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-17 15:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190115160812.12319.90321@vcs0.savannah.gnu.org>
[not found] ` <20190115160813.EFFD4209E3@vcs0.savannah.gnu.org>
2019-01-15 23:30 ` master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794 Michael Albinus
2019-01-16 18:05 ` Alan Mackenzie
2019-01-17 15:47 ` João Távora
2019-01-16 19:49 ` Ted Zlatanov
2019-01-17 9:27 ` Alan Mackenzie
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).