From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 0d5036061b5: Skip Eglot test if using very old clangd Date: Wed, 22 Mar 2023 10:49:41 +0000 Message-ID: References: <167942421231.13373.16122455155218245677@vcs2.savannah.gnu.org> <20230321184332.93736C13913@vcs2.savannah.gnu.org> <87lejpnk9t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20687"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 22 11:50:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pew3E-0005Dp-Ov for ged-emacs-devel@m.gmane-mx.org; Wed, 22 Mar 2023 11:50:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pew2W-0004f4-8h; Wed, 22 Mar 2023 06:49:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pew2V-0004eu-2m for emacs-devel@gnu.org; Wed, 22 Mar 2023 06:49:55 -0400 Original-Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pew2T-00067g-F8 for emacs-devel@gnu.org; Wed, 22 Mar 2023 06:49:54 -0400 Original-Received: by mail-oi1-x234.google.com with SMTP id bi31so605414oib.9 for ; Wed, 22 Mar 2023 03:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679482192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YV/HgHiVo8fr9qqjU+czPzKvuJn1k+fb8dY+KiXj84E=; b=f5pepLy3OyHavl6fUNj23uRc29OZmrSu6zQbEU55/LHQSDmyp/cjPwtoxbrUcQmOB8 j1A8ehE3lToXWwBcjZKKozdifS4ctFzvYzVOpzFmTZwlsweITdb91OQ3W+XZhIYOmhi7 /sChnjbEXJ1QImyVNejQZeEkfz1CeYr6Q6x5XF8XDo0848UBJlFvLbuASn8OVn2xCy2x KEoIY82M9E7fZt+yVJvXTe2Y9QIkYp7vqU/0Fx/28t3IvBzkFdWQCKrC24LI+T9LpysR adnKogf5T+YTWcinHRNSt1h4DIKVHeI6oUsv/nhHpllGrb+bk00IGyPRdQrRCjDi+xLI MZGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679482192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YV/HgHiVo8fr9qqjU+czPzKvuJn1k+fb8dY+KiXj84E=; b=e3dxKcR157YUfjQUVM7Q45EerW7jxrxtroKbxz/A9Ep6vo+e69Z0w4GMza7MdUUKMb QQY5g8CPsJqFeJAguJMR4kDClZkf/bAPq3XbMjfAOQVnKYgdG4dODzuS3Vc77aHEMqGx fZFdQZdZqqZMrJKIaVSWB0m26e+Xgmcv/xLJaNRVzx8hj8QCdql7HvrN1jNjlhJa1t4H jCr4ka17itPsbzNKZSA/WOAgzaNL58c21lDyn9QlWzNwqjEN3lyee+94/h4BSC4U29JU qSpahMGdxGb/SGcC9hnGg9MZpmXdZj2TYSnBGKzYHgSIbS3XViz7iOdOKSpD+0CptBFF hLSg== X-Gm-Message-State: AO0yUKUHYXu65mHzDwpT4FraKy2AxbnTsupWf7yKoaA0u2LDWmKYxyev rM+sLzb9+5FG5chXGbpPFRbZE26XqisulasklVQ= X-Google-Smtp-Source: AK7set/TFjjhC2Q/JWoONnBzE01uQhSMs0/eJQkmqrbwo/4j6ORio+tHo4vjQVm4yrAYPktFdPlNi0aX6qsXC6G2D0M= X-Received: by 2002:aca:2b06:0:b0:386:d50e:aa12 with SMTP id i6-20020aca2b06000000b00386d50eaa12mr786166oik.5.1679482191847; Wed, 22 Mar 2023 03:49:51 -0700 (PDT) In-Reply-To: <87lejpnk9t.fsf@gmail.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304702 Archived-At: On Wed, Mar 22, 2023 at 10:38=E2=80=AFAM Robert Pluim wr= ote: > Not all clangd have the version string and only the version string at > the end of 'clangd --version'. Here=CA=BCs one I installed from git earli= er: > > clangd version 16.0.0 (https://github.com/llvm/llvm-project.git 08d094a0e= 457360ad8b94b017d2dc277e697ca76) > Features: linux > Platform: x86_64-unknown-linux-gnu > > So how about the following (or we could just say 'everything > non-space', but I=CA=BCm assuming clangd versions are always made up of > numbers and '.') > > diff --git c/test/lisp/progmodes/eglot-tests.el i/test/lisp/progmodes/egl= ot-tests.el > index c4b23bfd64e..557bd899ab7 100644 > --- c/test/lisp/progmodes/eglot-tests.el > +++ i/test/lisp/progmodes/eglot-tests.el > @@ -317,7 +317,7 @@ eglot--simulate-key-event > (defun eglot--clangd-version () > "Report on the clangd version used in various tests." > (replace-regexp-in-string > - ".*version[[:space:]]+\\(.*\\)" "\\1" > + ".*version[[:space:]]+\\([0-9.]*\\).*" "\\1" > (car (split-string (shell-command-to-string "clangd --version") "\n")= ))) Sure, thanks. Bonus points for getting rid of the split-string and using a regexp that looks at the whole string and catches the version. I tried and failed. Jo=C3=A3o