Re: &allow-other-keys + &rest body in cl-defmacro (was: Permanently fix org versioning breakage during builds?)

["João Távora" <joaotavora@gmail.com>]

On Mon, Dec 25, 2023 at 11:23 AM Ihor Radchenko <yantar92@posteo.net> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> >> Hmm... It actually looks like a problem with `cl-defmacro' rather than
> >> with macro definition itself.
> >
> > No, Common Lisp's DEFMACRO works exactly like this. You need to understand
> > how &rest works with &key and &allow-other-keys. It _also_ keeps the keys.
> > That's just how it works.
>
> Now I feel a bit like RMS when he complained about CL-lib introducing
> alien concepts to Elisp :)

It's not Cl-lib's fault that the Org developers made a mistake and didn't
understand how the Common Lisp tool they selected works.

Even in Elisp a zillion macros are correctly written in this form:

  (defmacro with-foo (options-when-fooing &rest body)

It's exactly the same, only you need to do the destructuring yourself.
cl-defmacro simplifies this for free with

  (cl-defmacro with-foo ((&key option1 option2) &body body)

You (or the Org devs) just made a mistake that's all, happens to everybody.
Don't blame Cl-lib for it.

> What about non-breaking change like the attached?

You should be checking for `keywordp` instead, because &allow-other-keys.

João