unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Richard Stallman <rms@gnu.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Indentation of def*
Date: Wed, 20 Oct 2021 09:19:17 +0100	[thread overview]
Message-ID: <CALDnm52zhQh26v5o9qXX2pKqzyc++hgHXtMXFCOK87vTzepXaw@mail.gmail.com> (raw)
In-Reply-To: <87v91s876d.fsf@gnus.org>

On Wed, Oct 20, 2021 at 8:52 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
>
> Richard Stallman <rms@gnu.org> writes:
> > Please keep the heuristic.  It is still useful.
> > If file A uses a deffoober construct defined in file B, and you visit
> > file A with file B not loaded, the heuristic will make the uses of
> > deffoober indent properly.
> Or wrongly -- functions like `default-boundp' are indented wrongly using
> that heuristic.

Right. And your example is a _function_.  Why don't you _at least_ keep
the heuristic for macros? Isn't that a worthy compromise, a "no-worse"
situation? It would fix your default-boundp example and, if Richard's
example deffoober is a macro (I'd say there's a good chance it is,
statistically speaking) then the calls to that macro would also be
indented correctly.

What am I missing?

> The moral is: If you edit Emacs Lisp, you should load the file you're
> editing first, otherwise it'll indent badly.

That was always the moral yes.  But now, AFAIU, you're tightening
up those morals a bit, by requiring that Richard edit his code to add
indent specs to his macro definitions like deffoober. If I'm mistaken
in this particular example, please correct me.

João



  reply	other threads:[~2021-10-20  8:19 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 23:13 Indentation of def* Lars Ingebrigtsen
2021-10-14  4:22 ` Stefan Monnier
2021-10-14 11:07 ` Po Lu
2021-10-14 11:14   ` Lars Ingebrigtsen
2021-10-14 11:23     ` Lars Ingebrigtsen
2021-10-14 12:05       ` Po Lu
2021-10-14 12:09         ` Lars Ingebrigtsen
2021-10-14 12:22           ` Po Lu
2021-10-14 12:49             ` João Távora
2021-10-14 13:40               ` Lars Ingebrigtsen
2021-10-14 21:41                 ` João Távora
2021-10-15  9:57                   ` Lars Ingebrigtsen
2021-10-15 10:14                     ` João Távora
2021-10-14 13:25             ` Stefan Kangas
2021-10-14 13:30               ` Po Lu
2021-10-14 19:06                 ` Stefan Kangas
2021-10-14 23:42                   ` Po Lu
2021-10-15  0:50                     ` Stefan Kangas
2021-10-15  5:21                       ` Po Lu
2021-10-15  6:50                       ` Eli Zaretskii
2021-10-15  8:35                         ` Stefan Kangas
2021-10-15 10:42                           ` Eli Zaretskii
2021-10-15 13:07                             ` Stefan Kangas
2021-10-15 13:30                               ` Eli Zaretskii
2021-10-15 13:48                                 ` Stefan Kangas
2021-10-15 13:17                       ` Stefan Monnier
2021-10-15 12:42                     ` Lars Ingebrigtsen
2021-10-15 12:43                       ` Lars Ingebrigtsen
2021-10-14 18:35             ` Stefan Monnier
2021-10-18  8:02 ` Lars Ingebrigtsen
2021-10-20  6:47   ` Richard Stallman
2021-10-20  7:52     ` Lars Ingebrigtsen
2021-10-20  8:19       ` João Távora [this message]
2021-10-20  8:38         ` Lars Ingebrigtsen
2021-10-20  9:32           ` João Távora
2021-10-20  9:36             ` Lars Ingebrigtsen
2021-10-20 16:10               ` João Távora
2021-10-23 23:26             ` Richard Stallman
2021-10-24 13:22               ` Lars Ingebrigtsen
2021-10-24 14:27                 ` Stefan Kangas
2021-10-24 15:19                   ` João Távora
2021-10-24 16:23                     ` Stefan Monnier
2021-10-24 16:55                     ` Lars Ingebrigtsen
2021-10-24 18:36                       ` João Távora
2021-10-27 14:37                     ` Richard Stallman
2021-10-27 14:36                 ` Richard Stallman
2021-10-27 14:40                   ` Lars Ingebrigtsen
2021-10-30  6:49                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm52zhQh26v5o9qXX2pKqzyc++hgHXtMXFCOK87vTzepXaw@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).