From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it. Date: Thu, 17 Jan 2019 18:55:34 +0000 Message-ID: References: <20190117164350.GA18314@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547751288 1609 195.159.176.226 (17 Jan 2019 18:54:48 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Jan 2019 18:54:48 +0000 (UTC) Cc: emacs-devel To: Alan Mackenzie , Beatrix Klebe Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 17 19:54:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gkCoM-0000EP-Dw for ged-emacs-devel@m.gmane.org; Thu, 17 Jan 2019 19:54:43 +0100 Original-Received: from localhost ([127.0.0.1]:51536 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkCqT-0004O5-3E for ged-emacs-devel@m.gmane.org; Thu, 17 Jan 2019 13:56:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42406) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gkCpP-0004NN-Ej for emacs-devel@gnu.org; Thu, 17 Jan 2019 13:55:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gkCpO-0004n1-CG for emacs-devel@gnu.org; Thu, 17 Jan 2019 13:55:47 -0500 Original-Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:43806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gkCpO-0004ms-8T for emacs-devel@gnu.org; Thu, 17 Jan 2019 13:55:46 -0500 Original-Received: by mail-qt1-x830.google.com with SMTP id i7so12463308qtj.10 for ; Thu, 17 Jan 2019 10:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/cOEJ3NDrKEYwxqJIbKxVizPQhedPjPS9OUYsYWKvXM=; b=MB/wwFepwStgxOUh1+pqJ+y1x9SCKNYYRL983CSSc3rh3grgXJFTAfuz0KV3TvtC2t WYwYAcVZexTaOvH2mA1hlFL3DHjOCMhFMwCgI77aeHt0oT70KDq20dy5F5xG8Ict5DuR 4xmH4bO9C2RMKwithF17p7PVklZy9JNmIfmq5ytixL+dRYqlZXNMiXolUq0BkYk1JxRV WL+zWU89DLEn0VRyxz0tZQb1GmcfN2+6NknL2M89FTZS4wdxTG0PwVAwTnRns4PGVJ4i 8smeElkADcnONalMCXG3m184oiYaYyR4irjcMhPE0h+7J4hfbDVKJV5s9QWBXd4WYkvx FmcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/cOEJ3NDrKEYwxqJIbKxVizPQhedPjPS9OUYsYWKvXM=; b=rzE+uV4N5NmlYTL8dFBHQVYbCIcIt+iIy2n3M6xT8eEldzafRvQqH6pXSo5LGrX4JZ QXi9S3p7TV+xEF1hyV+/HEuG6jrvwe2zvNtGi4x3jOAh/u5XL5V/sSsaQSEThcnZ5pqh 9K+bt7GNo1xki6/j4VzlS/K1lPaMuazKmBg5Eu8jNo2tVUWrpI/liMGSH0s0IuAfTWW2 dOUJW5pR/R9pe1Rj/1I4u+Hj8Gp+G9limDFKYIeBEqYbPdfuUwXlNQZR6sq2vQH79rPe ZBlu/fjfPg+TnE0F3m4BZY44BTSmMyINPPJKNEi3UXE4U9W4lDXNqWbdx9p1tphwWBmZ CW5Q== X-Gm-Message-State: AJcUukdreBvQw8f6RQAUk0NaSQSa5WPpU5VVgCEbXmgMzpKj08+t13pc TNl6Ejm7wr0W3QjL7Y37+956Hx7GK8API5NtC5Q= X-Google-Smtp-Source: ALg8bN5gWdp93UaOVNvtVB0/zN/YX5fOkNA87ILiapNJjsTfJ9J6V4MsxkYCTwKwPc33RJfYPmfUX9+9FSFmtHUdAu8= X-Received: by 2002:a0c:9deb:: with SMTP id p43mr12601964qvf.107.1547751345481; Thu, 17 Jan 2019 10:55:45 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::830 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232437 Archived-At: > > Anyhow, apologies, and all that, but I don't want to spend any more tim= e > > on this topic today or until tomorrow evening, since I've got an exam > > coming up tomorrow. But I promise I'll get back to you (including > > answering your other post) either late tomorrow or on Saturday. > > Alright. Good luck for your exam. > > In the meantime. I will have to fix this differently. I will add a > temporary variable that I can set to have sane C++ behaviour > in the meantime. I will set this variable when running tests, so > the test people will see correct results. This is done in 4bdc03746915c36313b33b6998b855eef514cdd1 and be505726b68d407a44fdcd9c7ac1ef722398532d. The fix for bug#33794 can now be disabled by setting a variable to t. The variable's default value is nil, so the fix is in place and so are all the problems that come with it. Meanwhile, users of c-mode and c++-mode can: (setq c--disable-fix-of-bug-33794 t) if they don't care about the fix for bug#33794, which only affects users of c-toggle-auto-newline, off by default. Thanks again, Jo=C3=A3o commit be505726b68d407a44fdcd9c7ac1ef722398532d Date: Thu Jan 17 18:47:00 2019 +0000 Fix electric-pair-tests by disabling bug#33794's fix with a variable The variable c--disable-fix-of-bug-33794, which should be removed in the short term in favor of a permanent solution, is introduced. It is bound to nil by default. This means that breakage is still happening in actual c-mode and c++-mode usage, though the tests no longer show it. To get around this breakage, put (setq c--disable-fix-of-bug-33794 t) In your init file. Evidently, you will lose the fix for bug#33794, but that only affects a small corner case of c-toggle-auto-newline, which is not turned on by default. See https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00360.htm= l for more information. * lisp/progmodes/cc-cmds.el (c--disable-fix-of-bug-33794): New variable. (c--with-post-self-insert-hook-maybe): New macro. (c-electric-pound, c-electric-brace, c-electric-slash) (c-electric-star, c-electric-semi&comma, c-electric-colon) (c-electric-lt-gt, c-electric-paren): Use it. (c-electric-paren, c-electric-brace): Check c--disable-fix-of-bug-33794. * test/lisp/electric-tests.el (c--disable-fix-of-bug-33794): Forward declare. (electric-pair-test-for) (electric-layout-int-main-kernel-style) (electric-modes-in-c-mode-with-self-insert-command): Use it. commit 4bdc03746915c36313b33b6998b855eef514cdd1 Date: Thu Jan 17 18:08:01 2019 +0000 Revert "Temporarily comment out CC Mode from tests..." This reverts commit 54f297904e0c641fcfd81f16e9a87177124a27be.