From: "João Távora" <joaotavora@gmail.com>
To: Alan Mackenzie <acm@muc.de>, Beatrix Klebe <beeuhtricks@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it.
Date: Thu, 17 Jan 2019 18:55:34 +0000 [thread overview]
Message-ID: <CALDnm52yCA0X_FtP7PYAa0fxKW1TPVh+Y7PdROy_5noAmKJ=ng@mail.gmail.com> (raw)
In-Reply-To: <CALDnm50pBD5e4Yi+9cT=R+0tAwKyqPHGgxGKxymGFoobtYFLLw@mail.gmail.com>
> > Anyhow, apologies, and all that, but I don't want to spend any more time
> > on this topic today or until tomorrow evening, since I've got an exam
> > coming up tomorrow. But I promise I'll get back to you (including
> > answering your other post) either late tomorrow or on Saturday.
>
> Alright. Good luck for your exam.
>
> In the meantime. I will have to fix this differently. I will add a
> temporary variable that I can set to have sane C++ behaviour
> in the meantime. I will set this variable when running tests, so
> the test people will see correct results.
This is done in 4bdc03746915c36313b33b6998b855eef514cdd1 and
be505726b68d407a44fdcd9c7ac1ef722398532d.
The fix for bug#33794 can now be disabled by setting a variable
to t. The variable's default value is nil, so the fix is in place
and so are all the problems that come with it.
Meanwhile, users of c-mode and c++-mode can:
(setq c--disable-fix-of-bug-33794 t)
if they don't care about the fix for bug#33794, which only
affects users of c-toggle-auto-newline, off by default.
Thanks again,
João
commit be505726b68d407a44fdcd9c7ac1ef722398532d
Date: Thu Jan 17 18:47:00 2019 +0000
Fix electric-pair-tests by disabling bug#33794's fix with a variable
The variable c--disable-fix-of-bug-33794, which should be removed in
the short term in favor of a permanent solution, is introduced.
It is bound to nil by default. This means that breakage is still
happening in actual c-mode and c++-mode usage, though the tests no
longer show it.
To get around this breakage, put
(setq c--disable-fix-of-bug-33794 t)
In your init file. Evidently, you will lose the fix for bug#33794,
but that only affects a small corner case of c-toggle-auto-newline,
which is not turned on by default.
See https://lists.gnu.org/archive/html/emacs-devel/2019-01/msg00360.html
for more information.
* lisp/progmodes/cc-cmds.el (c--disable-fix-of-bug-33794): New
variable.
(c--with-post-self-insert-hook-maybe): New macro.
(c-electric-pound, c-electric-brace, c-electric-slash)
(c-electric-star, c-electric-semi&comma, c-electric-colon)
(c-electric-lt-gt, c-electric-paren): Use it.
(c-electric-paren, c-electric-brace): Check
c--disable-fix-of-bug-33794.
* test/lisp/electric-tests.el (c--disable-fix-of-bug-33794):
Forward declare.
(electric-pair-test-for)
(electric-layout-int-main-kernel-style)
(electric-modes-in-c-mode-with-self-insert-command): Use it.
commit 4bdc03746915c36313b33b6998b855eef514cdd1
Date: Thu Jan 17 18:08:01 2019 +0000
Revert "Temporarily comment out CC Mode from tests..."
This reverts commit 54f297904e0c641fcfd81f16e9a87177124a27be.
next prev parent reply other threads:[~2019-01-17 18:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 14:57 Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it João Távora
2019-01-17 16:43 ` Alan Mackenzie
2019-01-17 17:57 ` João Távora
2019-01-17 18:55 ` João Távora [this message]
2019-01-18 17:54 ` Alan Mackenzie
2019-01-18 19:55 ` João Távora
2019-01-18 22:53 ` Alan Mackenzie
2019-01-19 3:18 ` João Távora
2019-01-19 11:07 ` Alan Mackenzie
2019-01-19 13:52 ` João Távora
2019-01-19 17:45 ` Alan Mackenzie
2019-01-19 19:15 ` João Távora
2019-01-19 20:58 ` Alan Mackenzie
2019-01-19 23:18 ` João Távora
2019-01-21 18:04 ` Stefan Monnier
2019-01-21 20:45 ` Alan Mackenzie
2019-01-21 21:46 ` Stefan Monnier
2019-01-21 22:41 ` João Távora
2019-01-19 22:37 ` Drew Adams
2019-01-20 19:05 ` Richard Stallman
2019-01-20 21:18 ` João Távora
2019-01-21 20:59 ` Richard Stallman
2019-01-21 21:49 ` João Távora
2019-01-18 21:06 ` Stefan Monnier
2019-01-19 3:25 ` João Távora
2019-01-18 22:47 ` Michael Albinus
2019-01-19 20:18 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52yCA0X_FtP7PYAa0fxKW1TPVh+Y7PdROy_5noAmKJ=ng@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=acm@muc.de \
--cc=beeuhtricks@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).