From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [GNU ELPA] New package: url-http-oauth Date: Mon, 8 May 2023 18:03:45 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5881"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Thomas Fitzsimmons Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 08 19:04:46 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw4Hz-00017q-3p for ged-emacs-devel@m.gmane-mx.org; Mon, 08 May 2023 19:04:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw4HQ-0002ay-MM; Mon, 08 May 2023 13:04:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw4HI-0002ae-8G for emacs-devel@gnu.org; Mon, 08 May 2023 13:04:00 -0400 Original-Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pw4HF-0006us-Vv for emacs-devel@gnu.org; Mon, 08 May 2023 13:03:59 -0400 Original-Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-1927718b240so3062592fac.1 for ; Mon, 08 May 2023 10:03:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683565436; x=1686157436; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hAOHdBd4jZCIHe8QoBesHkOVN5ykU2fZ5P82TpY97uA=; b=leOQjcQ1z/WsLcWPXfqUyGGEu25QpaWaU8iyYpKq8z7BORllw3p1b1Nbv0MY6LKA/2 RId1Mh/eDW9BKIbLsg7yNkhRY9ovcPEGyEQLsPqC8Es6RAB+fVGlA0ry/8QJYpv81Fhc IgcM1pYlCayBmJp+HZZTAwcsoVv6+4WOuEc75mTriNR0XeNBdF19r2EmjWgQ2EfzmDom JGTL72I3jhTk6O2iFBcA5tCFdy1LunD7qvIDIaKnLF3wlnT9+YqhEc03q5gxmUcwbq2l 5XYLhi+da2je82bDApmBCJ3hYPcS3U91VineWpfY6lnWyPwhiq9HpYaJ/4K1wbUS0GKS jsRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683565436; x=1686157436; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hAOHdBd4jZCIHe8QoBesHkOVN5ykU2fZ5P82TpY97uA=; b=k6oCaox66xtfPJY6trMQSV/IjB+UCJuvKtYyoqyt/Pn8lAb8W8jXiH7pYYA8YVEp6h Cc9hWbD1YSNC610IR1TKUt4dXZQtKpv3CgtRFj+IznlDkPAeTt6ra985c6wUNGDYRZVj K7E143VXme7IezHB6S6ytJuon2RBlt6EJdozNhE3t9UJ0Ug16ZrEIPU2iStXyTd2NPNO NrOt3SFU9E37itbv6dFU9/D7Rwt2KFbssk9gQwfHCFS5WK790noOloD5TIW5Kr9PkvqV PGHP4ExP3PAbzq4ibSLlb235+nvXzb5GMGtItOFgUmE39OumHxyS963/ce4MYr04NbSa +IqQ== X-Gm-Message-State: AC+VfDwSFyiqQcDdb1OMQV31AQuvfp/ptCcOk/LtXj6NefPDAPQdLeAX C6qQYToBFBjzu6lwxLtoDiBti5Nxju7YLf6rhvmwdhlc X-Google-Smtp-Source: ACHHUZ6+172cggU+KURX6VLaGCGU9mMJJj9B6wnUmnVPLjksbbbC4epz2syg6sVcfAMr0ctd35bIcoLzzTGYTggocxM= X-Received: by 2002:a05:6870:7396:b0:184:2399:8730 with SMTP id z22-20020a056870739600b0018423998730mr5889443oam.6.1683565436628; Mon, 08 May 2023 10:03:56 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2001:4860:4864:20::2f; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305987 Archived-At: On Mon, May 8, 2023 at 4:27=E2=80=AFPM Thomas Fitzsimmons wrote: > > Url.el itself, last i looked, seemed a bit outdated and hard to work > > with. > > I find it OK to work with. It's primarily elisp, vs some other > proposals I've seen, so I can step through most of it with edebug. Yes, being elisp is indeed a nice property. > There's one FIXME in url-http-oauth currently that may represent a > url.el oddity (or may represent me doing something wrong): > > ;; FIXME: if anything goes wrong during the authentication steps, > ;; `url-http-end-of-document-sentinel' calls back into > ;; `url-oauth-auth' somehow. Maybe `url-http-no-retry' can help here? > > I'm sure other client libraries would have oddities too though. Well, the point was to pick one that didn't have as many oddities, i.e. a good one. > Are there bugs filed for the specific ways in which url.el may be > outdated or hard to work with? Maybe someone could maintain a > collection of links to those bug reports, to see how contenders measure > up? Of course, that list wouldn't represent the upsides of url.el, such > as the elisp purity I mentioned. > > > Are there other http client libraries for Emacs? > > Today url.el works for me, so I don't have plans to change; I'll > probably just follow what makes it into Emacs core. I remember url.el and finding it satisfactory enough for many things. Can't really remember any specific criticism, just the overall impression that it was a bit overcomplicated and didn't make use of lexical binding, for example. > > Could they also take advantage of your new library? > > If the new library implemented url.el's APIs, then sure. I would accept > well-defined/minimal compatibility patches for other client libraries > too, of course. Yes, makes sense. Well, anyway don't let this comment stop url-http-oauth from entering into ELPA. Jo=C3=A3o