From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: =?UTF-8?Q?Re=3A_31395511=3A_=22Don=E2=80=99t_attempt_to_modify_constant_st?= =?UTF-8?Q?rings=22?= Date: Thu, 4 Jun 2020 21:25:23 +0100 Message-ID: References: <871rmvn7ge.fsf@gmail.com> <87lfl36abx.fsf@gmail.com> <1abe5965-b48e-6dee-1516-c5c233f09d01@cs.ucla.edu> <87d06f5m2c.fsf@gmail.com> <87lfl3f5mj.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000043831405a747f3b8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99248"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , Pip Cet , emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 04 22:28:54 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jgwTu-000PjF-Gy for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 22:28:54 +0200 Original-Received: from localhost ([::1]:45804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgwTt-000752-Ex for ged-emacs-devel@m.gmane-mx.org; Thu, 04 Jun 2020 16:28:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgwQy-0002Nr-5k for emacs-devel@gnu.org; Thu, 04 Jun 2020 16:25:52 -0400 Original-Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]:41673) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jgwQw-0006Oj-RD for emacs-devel@gnu.org; Thu, 04 Jun 2020 16:25:51 -0400 Original-Received: by mail-io1-xd34.google.com with SMTP id o5so7816084iow.8 for ; Thu, 04 Jun 2020 13:25:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iexfHEh1Xv7gKpWcX8JPz4JjpZh47+ma79MYTw1IHIk=; b=j1DfICzjzeK/ZNR+eJuoAeTRO94dKvNV/HJGp1TYEtVqdcgoOVkU43uMQYy3OGcJSA IVhCE4HycPEXEZhsM7mxq67NRovi1rayZADH5PHkhp+emJKJzBZfsmdBkACPjQwA05kG 5tnV7MV4D2IxHoiiNOKJdLb+GyqC63o0+VdkoR+HbC8nVWAszirYjxu1ZKs+awuHXTA+ gFiL0mHwVQvPXAvmTDolU8v/k++4A/QNTgRcOEgjc+XcsH8uqpMmwf3NGm7eND5Yrrn+ Ff17dRR1mpUc/+l3Bns1embt43cZifSSxraMIkLAsLea6bl7FM1KYzzBMBf9JEerVVpA iDbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iexfHEh1Xv7gKpWcX8JPz4JjpZh47+ma79MYTw1IHIk=; b=QwiIID4za2o7d4dSd5K/wQ8P5N+pbPuXwZV1bIWNyM5G1+QD9y0tTUj8EpYOpPUap1 z5DK3d9phIJVsqh3kpUOmm4OwlAZaB1TktN0fo7juNyRmquEN/NkFnmnfzMJvBzUdjJg /lCLTGnTlYE73lSYZCDx/OsempCqhnvbkDpIHeKIaJY+PapKWMR2RAUK5s03MMzJEDl/ ypSiiuggVfVfY/0uoVeWzgTs74yQWfUib1GxEQ+YHe53Jf77BynNuoElDYMoQFLbNtzV FPcktP3RNCgggpc4M1Ej3nzwsmqQC92BAVD918DCYU5ZY0Qs2ctaUwm6S7xLcC40L6fN R3wg== X-Gm-Message-State: AOAM532hUf31rr0Eu9i5Ma6+5rN6+2tE5u+n5+xbcCPXdq/QgVJC6dTU Fug4CgjP0TwkG14IlpeE8xtiS1dT906U9tLsoRQ= X-Google-Smtp-Source: ABdhPJwMUrl5W6DGs2ZgkxfRdKcQvXtLvzdyIpNtqao3/mDznFzJ3t888f8Y4l3KjcmEXFGniMpM5Pg/m05oKZ0HWAw= X-Received: by 2002:a02:3406:: with SMTP id x6mr5867010jae.24.1591302349356; Thu, 04 Jun 2020 13:25:49 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::d34; envelope-from=joaotavora@gmail.com; helo=mail-io1-xd34.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:251861 Archived-At: --00000000000043831405a747f3b8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 4, 2020 at 8:46 PM Paul Eggert wrote: > > > > I'm still surprised my patch fixed the problem here (for some buttons, > > at least, for others there are a few more places that do the same > > thing...) but not for Jo=C3=A3o. > > There are several instances of the same problem in SLY. I found the ones > in the > attached patch, and I expect there are others. So perhaps Jo=C3=A3o was r= unning > into > one of the other problems. > Yes, sorry, that was the case. There was more code doing the same pattern. I'm OK with changing to the new pattern, and now that this has come up I do seem to remember being annoyed that I make-text-button didn't return the string it added the properties to. The only problem is that this will break Emacs 24.4 support, unless I do some version-checking thing. Jo=C3=A3o --=20 Jo=C3=A3o T=C3=A1vora --00000000000043831405a747f3b8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Jun 4, 2020 at 8:46 PM Paul Egger= t <eggert@cs.ucla.edu> wrot= e:


> I'm still surprised my patch fixed the problem here (for some butt= ons,
> at least, for others there are a few more places that do the same
> thing...) but not for Jo=C3=A3o.

There are several instances of the same problem in SLY. I found the ones in= the
attached patch, and I expect there are others. So perhaps Jo=C3=A3o was run= ning into
one of the other problems.

Yes, sorry, = that was the case.=C2=A0 There was more code doing the same pattern.
<= div>
I'm OK with changing to the new pattern, and now tha= t this
has come up I do seem to remember being annoyed that = I=C2=A0
make-text-button didn't return the string it added th= e properties
to.

The only problem i= s that this will break Emacs 24.4 support, unless
I do some = version-checking thing.

Jo=C3=A3o
<= br clear=3D"all">
--
Jo= =C3=A3o T=C3=A1vora
--00000000000043831405a747f3b8--