From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Sun, 5 Mar 2023 20:32:49 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ae366905f62d15d6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29841"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 05 21:33:48 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYv3E-0007aQ-HH for ged-emacs-devel@m.gmane-mx.org; Sun, 05 Mar 2023 21:33:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYv2a-0007Kf-6I; Sun, 05 Mar 2023 15:33:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYv2W-0007K2-RL for emacs-devel@gnu.org; Sun, 05 Mar 2023 15:33:04 -0500 Original-Received: from mail-oa1-x33.google.com ([2001:4860:4864:20::33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYv2V-0003dV-6e for emacs-devel@gnu.org; Sun, 05 Mar 2023 15:33:04 -0500 Original-Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-17683b570b8so6596309fac.13 for ; Sun, 05 Mar 2023 12:33:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678048381; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5MsBGOTAROKrFJRQLhcvU0IwvislBVUdbiZJ/Au8NPM=; b=pP3sWu9hx0QMJ1tqCIguhqSuwdHwKVmJF36LAt6wUknOtV1XR2OilFKD29HqDjw+X3 7LGHRDP/SeV7LntiSuforVjFZ9AWfRTJcVYQrEBKesrOjuYS8DugTuZEvM6C1+EpadcG ew8IULeAeDRl4X6I0FPIGKsWfltSKO042XdZnZPVXLVhAdQioqJRmaBihRYHopOQIK1T Pz5VXZIGJMzEmw7HIAgWHhsrn2LuQUusq2oVnEc1f5MVIqoAYlvXAv7QVYsgtrqafctd O6bTuvCZp9i7lG3QHMvDFwXhCRUIWis+ovFFr4sjS40baXO5w4h8FOnvhhsQzW9TOWe9 /WJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678048381; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5MsBGOTAROKrFJRQLhcvU0IwvislBVUdbiZJ/Au8NPM=; b=dXhnX7ML0asikzlTSSTSD5dsaddTrtyJFEAlpIR+PF36qceICPWs97Hw3TNeczcZW3 i6W1YcKe1w5exmxjxHU1lgd1AKzPb0cTht9wJn2K534ClCH0GvB28CgOnJZVPuE5hNBu JmxsKdbJMi7+JB0uVls1U2CO0SzvBhkCyVzpPj9Npu4A7LlFUBB11lrPzmsjrBfL6ouR VZE8Ez3mAX2MSVcbKwPXfo4t7iz5jiS1+A92hsI8stC+jS7+g6j8iiAJ3bv90lzbjIbH zTb8F5u8BdLrpUfPdzDo79bwoClibNj6+F03wtHnP7HHvdOme+MGe1jf6UqaSIPGX+Kc BmSQ== X-Gm-Message-State: AO0yUKUQumJCkKl6J6HpsskC1lfkqZ09sQSj77QxuyloAuuJDEkChHeC s+zDnEqE+9985/p0LX+gDZMgI8s6wflVSFZ3Wxs= X-Google-Smtp-Source: AK7set+xySYZlJ5pbiqtbgOrPW3NPsJnnG/EctlQTlFs/BvRhs2RwPihqzna8KU/VpA8YfLWCC44XjQXpnGOeft64ks= X-Received: by 2002:a05:6870:954c:b0:16a:17d9:b66d with SMTP id v12-20020a056870954c00b0016a17d9b66dmr2871313oal.8.1678048381251; Sun, 05 Mar 2023 12:33:01 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2001:4860:4864:20::33; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303993 Archived-At: --000000000000ae366905f62d15d6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 5, 2023, 20:10 Jo=C3=A3o T=C3=A1vora wro= te: > On Sun, Mar 5, 2023, 10:22 Helmut Eller wrote:. > >> >> I think that it's a bad idea to add language specific commands to xref. >> The next thing is that we have commands for jump-to-variable and >> jump-to-constant and jump-to-macro ... >> >> It would be better to leave those commands in the language specific mode >> with the C-c prefix. >> > > I agree, but the xref backend responsible for answering the request can > still be Eglot's. > To clarify, i think the thin commands and the keybinds should be in the major modes, but these commands should be thin and use xref as a library. And the backend should be Eglot's, if it happens to be managing the buffer via LSP, else out can be whatever the major modes sets up. Jo=C3=A3o Josh > --000000000000ae366905f62d15d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Mar 5, 2023, 20:10 Jo=C3=A3o T=C3=A1vora <<= a href=3D"mailto:joaotavora@gmail.com">joaotavora@gmail.com> wrote:<= br>
On Sun, Mar 5, 2023,= 10:22 Helmut Eller <eller.helmut@gmail.com> wrote:.

I think that it's a bad idea to add language specific commands to xref.=
The next thing is that we have commands for jump-to-variable and
jump-to-constant and jump-to-macro ...

It would be better to leave those commands in the language specific mode with the C-c prefix.

I agree, but the xref backend responsible for answering= the request can still be Eglot's.=C2=A0
=

To clarify, i think the thin = commands and the keybinds should be in the major modes, but these commands = should be thin and use xref as a library. And the backend should be Eglot&#= 39;s,=C2=A0 if it happens to be managing the buffer via LSP, else out can b= e whatever the major modes sets up.

Jo=C3=A3o

Jo= sh
--000000000000ae366905f62d15d6--