From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Apropos 54f297904e0c: Temporarily comment out CC Mode from tests which are incompatible with it. Date: Thu, 17 Jan 2019 14:57:04 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1547737184 20056 195.159.176.226 (17 Jan 2019 14:59:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 17 Jan 2019 14:59:44 +0000 (UTC) To: emacs-devel , Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 17 15:59:40 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gk98t-00056w-PF for ged-emacs-devel@m.gmane.org; Thu, 17 Jan 2019 15:59:39 +0100 Original-Received: from localhost ([127.0.0.1]:46223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk9B0-0000d0-QV for ged-emacs-devel@m.gmane.org; Thu, 17 Jan 2019 10:01:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gk96e-0005aq-9G for emacs-devel@gnu.org; Thu, 17 Jan 2019 09:57:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gk96b-00062W-10 for emacs-devel@gnu.org; Thu, 17 Jan 2019 09:57:19 -0500 Original-Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]:45670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gk96a-00061V-MV for emacs-devel@gnu.org; Thu, 17 Jan 2019 09:57:16 -0500 Original-Received: by mail-qt1-x836.google.com with SMTP id e5so11531552qtr.12 for ; Thu, 17 Jan 2019 06:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=PG9pnTIwhxuClk7v56bEO5Hymj2YAjZHUSO3aN3yhuA=; b=G2a64n4oVDPDzBv4uVX9A1jk+yULZyLo1v52lLirRqE4drDYRmCmXTQd4noy0jvkA0 glr9nT59vYQbpOXOXaZWLXCy0VXIWztmqkAjp47RX2GeIVjExmYOObbx8SiGL/7nFPFI OoWptHmBLpKCb+ms5ME5Ny8yqEufa3+2+CvPXzi5XdwOHgRsnM8NDX+L/MjSQtn0RYEa 2i+q1Ryy5Lb+5ZwJQ1Hj4wjp9M7mL1YLoxalsUdGZ3czCV2vAIiBZd9DsBAQ9V98U+CP U918atqA5KASL07ZukBNlNuhLGGozx46TYyRK1+VzAKu/8fPLxrg77698j7CYKC3+s+z rHgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=PG9pnTIwhxuClk7v56bEO5Hymj2YAjZHUSO3aN3yhuA=; b=GD+wCiU4OxK5QlvkMKeYZH1WB8UdRhtetzsUUT3g26tzdmEd0/wvnwdjyJHi4RW/D3 +KSnUxMU//n+D2KyGqREw83zZPtyj+T6Bm6CWD2SLIaemlqvMLA+fV0RU8BulQoS6Lgu wWY/7v3ECbF/RshnwsR7agfgUb6kOTc8eIYWoU6rLrkX5yJwOl1qxTljxaUOyrJA9gIR kYPUzDDdNSEa4K/B3eVlJB4TOvfgpxQ4Xm6VFbkFgJO5r2fsIFgYfso3415ToMQzwuJR 00BxWAv/MGRKrn1HUpQJn6+0cHuiJ7wAPuDe8ny0alaZLrnnTnkjpCaAjMBf2C8/Shex 8CKA== X-Gm-Message-State: AJcUukdsyWDpHp2ItcyOm4Q0kL4gI21BOx+JXX8jPNkacuwpNuuCOveB rJQbgQUaYeb2rtOLDimmm43lIC2RaemdTGlS3DbuqyHJ X-Google-Smtp-Source: ALg8bN5TCl5XBrv+Dlq5esrxJOUERIjIdhZ4Zr7nOWlyYvFUivuM3oL+lRkIMeNk/VfltTomtt/p0WDLUrXcnuaM5Ek= X-Received: by 2002:ac8:88:: with SMTP id c8mr12116075qtg.218.1547737035339; Thu, 17 Jan 2019 06:57:15 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::836 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232426 Archived-At: Hi Alan, Please revert this change ASAP: commit 54f297904e0c641fcfd81f16e9a87177124a27be Author: Alan Mackenzie Date: Thu Jan 17 12:51:40 2019 +0000 Temporarily comment out CC Mode from tests which are incompatible with it. * tests/electric-tests (electric-pair-test-for): comment out c++-mode from the list of modes to be used in tests. (electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings) (ert-deftest electric-layout-int-main-kernel-style) (ert-deftest electric-layout-int-main-allman-style): Comment out. I thought we had agreed that the way to "work around" other people's unit tests, even if temporarily, is to work in a separate git branch. The other electric-pair-test that I disabled 6 months ago, that was one tha= t also temporary, is till there. But now you destroyed even the "expected failure" mark. Why?? Is the test passing unexpectedly? @@ -396,10 +397,10 @@ whitespace-chomping-2 ;; mode will sort this out eventually, using some new e-p-m machinery. ;; See ;; https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00535.html -(setf - (ert-test-expected-result-type - (ert-get-test 'electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings)) - :failed) +;; (setf +;; (ert-test-expected-result-type +;; (ert-get-test 'electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings)) +;; :failed) But this is much more intrusive. In particular ;; Tests commented out, since C Mode does not use ;; electric-layout-mode. 2019-01-17, ACM C Mode doesn't use electric-layout mode, but a user can surely decide we wants to use it in c-mode, can he not?? These tests pass fine currently. Please revert this fix and lets discuss why you need to disable tests. If we come to the conclusion that some tests are asserting unreasonable expectations about the functionality you develop, we can disable them on a case by case basis! If on the other hand, if you need to do some work "temporarily", then the best way to do it without disturbing other people's developments is to do it in a separate branch. Jo=C3=A3o