From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master a33e7c0286c 2/2: Disable workDoneProgress if defcustom is nil Date: Wed, 17 Apr 2024 17:22:17 +0100 Message-ID: References: <7d5f1d88-e3dd-4a50-ab67-e7fb21a5a350@email.android.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Theodor Thornhill Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 17 18:23:08 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx83v-0007es-TE for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Apr 2024 18:23:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx83O-00015t-5n; Wed, 17 Apr 2024 12:22:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx83M-00015h-R3 for emacs-devel@gnu.org; Wed, 17 Apr 2024 12:22:32 -0400 Original-Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx83L-0003ii-2h for emacs-devel@gnu.org; Wed, 17 Apr 2024 12:22:32 -0400 Original-Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-516d756eb74so7294930e87.3 for ; Wed, 17 Apr 2024 09:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713370949; x=1713975749; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AKY4JTsQqPg/qPDzh7REIwlH5E85KNZOm2x+QhhoIVE=; b=CQ7AtWWWp0DXL33psZstY4aISCIfddLuabOia7WWr9DQbD90gbYG1oa9afBurBW6eX M3fhlBRb0Zv1p3F+ShSXE0aZ72ZsO5wQBwGfoSa/chFDTZt/pVxgBTXrGIgJ3f+pfTC1 iypK8FtzupUugpE+DGiZJ1eFrUDWI60p1Ri9C/l3shAMevXX6tQ7Mq0IuhDjZTj9O7tN Zj5VUT64R1KB4U7FAjlkJIhaeJOOTu5X6LlBTdJ5flQpUlheccTSc2OTsVplgvkiYvKi brJ7xwaxdZAR/Xw0GRjSu/yGjfLYTnemVX946UZDKGt6EGcgTAakR54lSdr60xbSRA4G rb2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713370949; x=1713975749; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AKY4JTsQqPg/qPDzh7REIwlH5E85KNZOm2x+QhhoIVE=; b=avKy7EaPKQ3Qe3j7jgmYLozzDmeE48obKCQpTfd8lE5EemMP+ecGc8bQ7uJklqd2GU kVriXv4battI3XVH46BFCcL03fahqzeZstrTvk3ZLSOzdRRWOvf9omW/fROu3trqdW0f yZ0wiX9+VtJN98HkPkBuLx5PsRGoHyR7tGPYadJk0XPlEmsdB66jNz0nUDRLSl3GUzS4 0mX9OC8GFbZtBx+AD7m4CARXFk71dNTi5YiXY2HoByMmFZecrbNXinc1K8AO00f1PL0h eMwGPWDQV847CDvyN/SckXR/uPFm6sGXc29/mc882+L1jTN4geZ6ygIPliQMx/1oGWBu H4dQ== X-Gm-Message-State: AOJu0Yws+1rW13LFAmJe9YaxQ8GmDb281ZnDp+2au+7FCwx/0mr6dB5u nHnSCJEQLzM5/gIyMP1/t7h/BevW+uTa/lk0jutGRfwOWlvwMo8UTmdRCQG+Cuyetx/VoPvblbe XoAX7NEvUuyp/l0Ol0DdETmYT81QWZw== X-Google-Smtp-Source: AGHT+IElgT/N/Ammo3qVMIwF4tN7UWWIloGcXD4vlawDtE944JN9LrXVHvHMt5PaEUd7uDRj3E/UDOcSzSy+cpqhxps= X-Received: by 2002:a05:6512:3492:b0:513:84b6:6915 with SMTP id v18-20020a056512349200b0051384b66915mr10352778lfr.20.1713370948961; Wed, 17 Apr 2024 09:22:28 -0700 (PDT) In-Reply-To: <7d5f1d88-e3dd-4a50-ab67-e7fb21a5a350@email.android.com> Received-SPF: pass client-ip=2a00:1450:4864:20::12e; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317778 Archived-At: On Wed, Apr 17, 2024 at 5:11=E2=80=AFPM Theodor Thornhill wrote: > On Apr 17, 2024 17:49, Jo=C3=A3o T=C3=A1vora wrote= : > > On Sat, Mar 30, 2024 at 7:52=E2=80=AFPM Theodor Thornhill via Mailing lis= t for > Emacs changes wrote: > > > > branch: master > > commit a33e7c0286c2a9c8af1c96db42f5c0c37611c9db > > Author: Theodor Thornhill > > Commit: Theodor Thornhill > > > > Disable workDoneProgress if defcustom is nil > > > > There is no need to receive the $/progress notifications from the s= erver > > if we don't want to render them. Because they are effectively ignor= ed > > when eglot-report-progress is nil we'd rather not waste cycles on s= erde > > of the messages. > > I agree with this, but it has the side-effect that a user > experimenting with setting eglot-report-progress _during_ a session > won't see the effects live and needs to reconnect. Which is perfectly > fine, IMO, but probably could be documented somewhere. See the similar > situation eglot-events-buffer-config and its docstring for an idea. > > Jo=C3=A3o > > Thanks! I'll document this. Cool. I'll leave it up to you to also add it to /etc/EGLOT-NEWS. It is a (tiny) behaviour change, after all. Jo=C3=A3o