From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 08c80c45dde: Don't use file-truepath in Eglot (bug#70036) Date: Wed, 17 Apr 2024 16:35:49 +0100 Message-ID: References: <171215083924.12380.5369373861551158668@vcs2.savannah.gnu.org> <20240403132719.A18EFC12C28@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26003"; mail-complaints-to="usenet@ciao.gmane.io" To: Theodor Thornhill , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 17 17:36:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx7L3-0006au-G9 for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Apr 2024 17:36:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx7KS-0002Wa-5h; Wed, 17 Apr 2024 11:36:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx7KQ-0002WP-Pb for emacs-devel@gnu.org; Wed, 17 Apr 2024 11:36:06 -0400 Original-Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx7KO-0004Hx-Dr for emacs-devel@gnu.org; Wed, 17 Apr 2024 11:36:06 -0400 Original-Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2db13ca0363so18291481fa.3 for ; Wed, 17 Apr 2024 08:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713368161; x=1713972961; darn=gnu.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FQAAKe9TGjlb2XqSCb08voXdUk1ebZ/3/UYA8U4FZk4=; b=i0vMQ5CmKJZhx51BYG7PK8fQafHmmzbdZUSgzTfYYDt4moORU3TFPOquR3oONg5sD7 buFOdWoDn5uLTMlZCsr7FutEfTOn5B4eO9TiA89l6zaOU/dHN5Z6ZlZVI9mMOBGNIJ5E iLcc6ofM8WpXmk4LW54fjJbsDX/JZbbzoQLi0HHIA+XRBNlR4d8jkvbOxYvOq0cu5KeT EvDwdVXyE8Toq8Zr1RhU++pwDUXoWDeDU/AjZHEwkVvVlvicp2uekBZtRtcDwVcg4iDG 2paUhFgbyeePAWZh6IY4rv47A+XZVjJ+gYyZvJVB1q4wMmZerxDaFMo7MEEmCbmjcaXf e9xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713368161; x=1713972961; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FQAAKe9TGjlb2XqSCb08voXdUk1ebZ/3/UYA8U4FZk4=; b=kxLBFH7Ho1zFY/YyC6Wuup9mAQ0MzkpJO9yE8AjF4t5dW0c18Kg9bFFLVBL5TwEjcS BJgpEMSKBi02wumt3KDOWGTDL7pZIGIOw7BZ/fNCOPv5vMwO0IrAW8ODZvjFcSdHXHrO 9fIrEt+oZX597WnIhZqFWxKsJilZfanH9r1LGIzZMnQAtytxjW+xvGiVOhyxE80LXSS2 j6WnVN4JHNj9yFdiEPkDS8wEBovfoIqO9V3em538CA/OZ+/NMIlYdibTklEoomnHVHCM Lpn9hN4SdMLG4QANPL5InuzUXNMWAWPrE6gyNYkON1yzCT32Mjya8qd3LG1QBx23QV9b ax9A== X-Forwarded-Encrypted: i=1; AJvYcCUT6SgDGLMT7NICdKqSm6eZZqF/2l85f1TAb+BGiTpSMrJOYXPDjiQMxQWVNaMLrhvx73N6ANGzd+iW2bGi8L3JiADd X-Gm-Message-State: AOJu0Yz+E/ZmzHUhDrl3IuychNWnrS604VtB/usqwNxS9/XMTUMER2dN cYznV6QaLQbXx93FEHXh8i0yIbbPTddLNdhU7uGMJJRoLbFZIiv3IzJGAvBOunIctGe+NAim5yu iLh6BJYKXxuLm4elId8reTBvkUg5GhHp9 X-Google-Smtp-Source: AGHT+IGUfFcLn1irQ6MtzmJRF81USTZKKnBSowAxv8O/vQj/2Px8rXsoia/acTPlcWsIYEOMaN5MmZ1hU6QoYYVdTVk= X-Received: by 2002:ac2:4c43:0:b0:519:482d:d285 with SMTP id o3-20020ac24c43000000b00519482dd285mr2439246lfk.21.1713368160736; Wed, 17 Apr 2024 08:36:00 -0700 (PDT) In-Reply-To: <20240403132719.A18EFC12C28@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=joaotavora@gmail.com; helo=mail-lj1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317773 Archived-At: Hey Theo, I don't disagree strongly with these changes (*), but was surprised to find them pushed without asking me specifically about this patch. It's true you CCed me about the need for file-truename and I didn't reply. But still, another email with the patch about to be pushed would have been nice. I have been looking for an Eglot maintainer but everyone I contacted said no, so I assume I'm still the maintainer. This is in contrast to Flymake and Jsonrpc where I've found two people willing to take it up. I still get some email and GitHub traffic about Eglot. I'd very much like to hand it over to you guys formally, I think you, Felici=C3=A1n, Stefan, and others will do a fine job, collectively. Even if I would prefer to hand it over to someone with some kind of vision for it (but hey beggars can't be choosers). I'd also like to be a "whole-package situation", where you guys also watch over the downstream GitHub repo (or convert it or phase it out or whatever) so I can unsubscribe in peace. Just now I got this report in the GitHub tracker about Eglot spamming *Messages* https://github.com/joaotavora/eglot/discussions/1389 and was caught a bit off-guard, as I had nothing to do with it. So I propose that as long as you and others (legitimately, of course) decline the "whole package" offer, you keep giving me just a tiny bit of he= ads up about what's being proposed to the code (beside the trivial "add support for XYZ server" of course). Or if you prefer just _inform_ me that this or that change was pushed recently, so I can comment back while the matter is still fresh. Felici=C3=A1n did this just today with a patch proposal. Thanks. And thanks for your work on Eglot, of course. Jo=C3=A3o (*) As to the actual change... On Wed, Apr 3, 2024 at 2:27=E2=80=AFPM Theodor Thornhill via Mailing list f= or Emacs changes wrote: > the implementation to a hash map will yield similar performance > benefits, but wouldn't require us to rewrite `file-truename' in C. The change seems well structured, well coded, and well described in the commit message, so I could understand it easily. Do keep that up. But of course going from file-buffer-visiting to something else whose underlying implementation is faster but doesn't chase symlinks is probably going to have some kind of functional implication right? I wonder if (or rather "I hope that") you guys considered it. Also, when using a cache to solve a problem, remember cache invalidation is one of the 2 hard ones ;-) Sure this cache won't ever need invalidation? Even when the user moves file around during an Eglot session? If you ask me, this 'rewrite `file-truename' in C.' is what should be done. No idea how hard that is, but a hash table just isn't fit to answer= the same questions as 'find-buffer-visiting'.