From: "João Távora" <joaotavora@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>, emacs-devel@gnu.org
Subject: Re: master a33e7c0286c 2/2: Disable workDoneProgress if defcustom is nil
Date: Wed, 17 Apr 2024 16:49:41 +0100 [thread overview]
Message-ID: <CALDnm52FM3d=iW=SSTKpbwxxG_2GKbkEev4CNQ4Omf5vAJbo_A@mail.gmail.com> (raw)
In-Reply-To: <20240330195235.E717BC1FB61@vcs2.savannah.gnu.org>
On Sat, Mar 30, 2024 at 7:52 PM Theodor Thornhill via Mailing list for
Emacs changes <emacs-diffs@gnu.org> wrote:
>
> branch: master
> commit a33e7c0286c2a9c8af1c96db42f5c0c37611c9db
> Author: Theodor Thornhill <theo@thornhill.no>
> Commit: Theodor Thornhill <theo@thornhill.no>
>
> Disable workDoneProgress if defcustom is nil
>
> There is no need to receive the $/progress notifications from the server
> if we don't want to render them. Because they are effectively ignored
> when eglot-report-progress is nil we'd rather not waste cycles on serde
> of the messages.
I agree with this, but it has the side-effect that a user
experimenting with setting eglot-report-progress _during_ a session
won't see the effects live and needs to reconnect. Which is perfectly
fine, IMO, but probably could be documented somewhere. See the similar
situation eglot-events-buffer-config and its docstring for an idea.
João
next parent reply other threads:[~2024-04-17 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171182835532.14560.17113012267608349468@vcs2.savannah.gnu.org>
[not found] ` <20240330195235.E717BC1FB61@vcs2.savannah.gnu.org>
2024-04-17 15:49 ` João Távora [this message]
2024-04-17 16:11 ` master a33e7c0286c 2/2: Disable workDoneProgress if defcustom is nil Theodor Thornhill
2024-04-17 16:22 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52FM3d=iW=SSTKpbwxxG_2GKbkEev4CNQ4Omf5vAJbo_A@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).