From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot Date: Mon, 12 Dec 2022 09:52:04 +0000 Message-ID: References: <167080394233.4339.5863353994038854528@vcs2.savannah.gnu.org> <20221212001223.E9A9DC004BE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004290ae05ef9e70ef" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11293"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 12 10:51:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4fTC-0002nP-IX for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Dec 2022 10:51:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4fSZ-00050I-LH; Mon, 12 Dec 2022 04:50:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fSY-000504-1s for emacs-devel@gnu.org; Mon, 12 Dec 2022 04:50:54 -0500 Original-Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4fSW-0002Zx-Cl for emacs-devel@gnu.org; Mon, 12 Dec 2022 04:50:53 -0500 Original-Received: by mail-oi1-x22b.google.com with SMTP id r11so10682640oie.13 for ; Mon, 12 Dec 2022 01:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hcjVbR8yd2+3KnN5FC0vrUFKj/w1aLttJERWGtRi5V4=; b=K4i7xy+p4ShlZN/4baBp7WazG35s1TBcjpElAiyHhqgXFfmEhOQLfFqQ5897aMTf+X 6oXJALr7/8fGewafDYHUD74hfn0trr1KIl5U8sMuIAsDESkVfOdtNanmktNOZ4wVLfw4 OMioahSSnt1i9qCV0CyIUtddQcayeYFJsqIGoMvped7XCYfHIo/aXDGvFZ1V20DnPmqS xZTmR+2Nn6rnTPd8qgYoB4a0PPBPBfbjl7PdNMh29gvaHM93GZpbWgyMx+8laITSYPsr hj+BO7uafhyX84MO2fgNY5DZjjriLZOAKjges6jsfaGwJYm9W0ziRvWw9hwO5AIaC0dD o0FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hcjVbR8yd2+3KnN5FC0vrUFKj/w1aLttJERWGtRi5V4=; b=yY5Y2LbDQj1Uz3AYWNp95er4ZI90ap2o6Rr4WsYm8/50HPFnvrIyLmsAx7IrleOWpg trlK66jZGyPS1PWWnymNzi07LSKUM1BWdPNyZxU79Wr1mjboOhSPXVmi/XCxKCVJAE0n TS2W6H9TpIXFIuKsjAAkb2fJaOwb7q2kuenEg2CzkdUXYnGpLJRGJo8PJMYoJUa0WVzr +xKZfkHOKkCTX7WCurrSignmSoZEXV0NII3VWLN43AuK/LgRw3t2UV2f3lmjQ1KJYVgX 1Hs+1uRpeibpeeDajU5MhOUHRf+YLGyH3dvo+E68Fx5zhEcvudgYk3XtwbcdARfoQa0n DyNQ== X-Gm-Message-State: ANoB5pkaR/XPqGvwrhTH0JllSNTHF39Rnaz38zkzqycP3F1GlM4feswU InlpWrDoZXxY5SV+67L9OJmKwuOmSlBUYAcCClADDF3NPbA= X-Google-Smtp-Source: AA0mqf5LLEYu7oqcjWL7bODNJ++v3TRbvfwYkpCJnO/2TvojRQ1cienHHdcHWPs1d61YGC9gV5WOb6hPke4QGcaPtpQ= X-Received: by 2002:a05:6808:254:b0:35e:4a14:8182 with SMTP id m20-20020a056808025400b0035e4a148182mr1332794oie.171.1670838650833; Mon, 12 Dec 2022 01:50:50 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22b; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x22b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301201 Archived-At: --0000000000004290ae05ef9e70ef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Stefan, Are you seeing these failures on Emacs's CI infrastructure (EMBA, If I'm not mistaken), or on your own machine? Tests run fine on my machine. I'm going to assume this was on your machine from now on. It seems you have some language servers and language toolchains installed but that, for some reason, they are not behaving as they should. In tests such as 'project-wide-diagnostics-rust-analyzer' an additional "skip-unless" check for "cargo" was missing. I've now fixed that. Can yo= u explain why you have a "rust-analyzer" executable, but not "cargo"? Is this a usual Rust setup? In other tests, such as 'javascript-basic', 'project-wide-diagnostics-typescript', the error is strange: (error "[eglot] -32603: Request initialize failed with message: Could not find a valid tsserver version. Exiting.") I don't know what this can mean. Again, it seems you have "typescript-language-server", but somehow "no valid tsserver". In general, I don't know if it's a good idea to keep these tests in the normal 'make check' run, since many Eglot tests are dependent on having correctly working servers. Or at least what I and other test authors believe to be "correctly configured". Which is generally the simplest installation method for said servers, with the fewest bells and whistles. Let me know if you've investigated your setup for these servers (again, I'm assuming this is on your machine and not EMBA). Jo=C3=A3o --0000000000004290ae05ef9e70ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Stefan,

Are you seein= g these failures on Emacs's CI infrastructure (EMBA,
If I'm no= t mistaken), or on your own machine? Tests run fine on
my machine.
I'm going to assume this was on your machine from now on.

It seems you have some language servers and language
toolchains = installed but that, for some reason, they are not behaving
a= s they should.

In tests such as 'project-wide-diagnostics-= rust-analyzer' an additional
"skip-unless" =C2=A0check for= "cargo" was missing.=C2=A0 I've now fixed that.=C2=A0 Can yo= u
explain why you have a "rust-analyzer" executable, but not &= quot;cargo"? Is
this a usual Rust setup?

In other tests, suc= h as 'javascript-basic', 'project-wide-diagnostics-typescript&#= 39;,
the error is strange:

(error "[eglot] -32603: Request i= nitialize failed with message:
=C2=A0 Could not find a valid tsserver ve= rsion. Exiting.")

I don't know what this can mean. Again, i= t seems you have
"typescript-language-server", but somehow &qu= ot;no valid tsserver".

In general, I don't know if it's= a good idea to keep these tests in the
normal 'make check' run,= since many Eglot tests are dependent
on having correctly working server= s.=C2=A0 Or at least what I and other test
authors believe to be "c= orrectly configured".=C2=A0 Which is generally the
simplest install= ation method for said servers, with the fewest bells
and whistles.
Let me know if you've investigated your setup for these servers (agai= n,
I'm assuming this is on your machine and not EMBA).

Jo=C3= =A3o --0000000000004290ae05ef9e70ef--