From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Tue, 28 Nov 2023 15:02:11 +0000 Message-ID: References: <87il697r5g.fsf@catern.com> <87r0kw8nxu.fsf@catern.com> <3fe5a8cd-b355-d7eb-10ad-8846aef3387b@gutov.dev> <878r6mx1xc.fsf@betli.tmit.bme.hu> <90e4b9a7-3b51-587d-e317-b89e5d5464d9@gutov.dev> <87sf4scxax.fsf@betli.tmit.bme.hu> <77500777-aea2-14db-4aab-7a5dff43443b@gutov.dev> <00b85d5b-7878-4099-ab44-8200e153885d@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6235"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , Spencer Baugh , emacs-devel@gnu.org, Eshel Yaron , John Yates , Ergus , Filipp Gunbin To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 28 16:03:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7zcT-0001Mm-00 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Nov 2023 16:03:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r7zbf-0005zy-NR; Tue, 28 Nov 2023 10:02:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r7zbd-0005xq-F0 for emacs-devel@gnu.org; Tue, 28 Nov 2023 10:02:33 -0500 Original-Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r7zba-0004Zn-O0 for emacs-devel@gnu.org; Tue, 28 Nov 2023 10:02:32 -0500 Original-Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-5094727fa67so8000401e87.3 for ; Tue, 28 Nov 2023 07:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701183744; x=1701788544; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x9PHEF9AgbPZL8tadI8o4AzBYTr2oE9zugEpRKd/A14=; b=VaF1k5/QfabXEk73BQxogdUWSyxqsOopuDQEpxPZZAFP2T2u3ElAifq5WbE8p9hQ2s 3p0TcKR/jut9y9Zdc+YbOWDvTZN3G9he015S502u3TIBtitCHQAKLVfIko7r4TV5EjRY e5cslz8gMGCqTepGEogqw04R9n0KuX4tz61XlOuwgDt8l3J1qym1Aj92FRp6uZwXWJma TsymJp6i1hMzSnhLChad7nXtRUY5Ynjpu4irPvJaHUT+h1cXIHnSYlGOHI6BJDN104U/ u0V+bgobkckuKZetcKKEVpzsTSJRGbHxHgCKdIOjDX36k45ORy4iafMyNkQc1jZzQRw7 K7Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701183744; x=1701788544; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x9PHEF9AgbPZL8tadI8o4AzBYTr2oE9zugEpRKd/A14=; b=GnYxxfkIwbi8tbrH/cnrQ42c25T3ipNbHa19M9rMmmDqJjjd3wnNG4pPLYjjy4VOOn 7s8mU7jl6558xulwIaFQlyc9fagIzHcPoAUCQsb7yAY6qObm0TSXps1jCItV6kLu0G3O zAMxDibKrpedfFm7HwZFfsT/mhptNi1JYsgkmkQlWU84d9N27c5doEUHsQCa3P4tsTg4 prb+itnTLqGPHK8IRhEefrWAS1hgXyOuRDW+FCwWFydXM7MXwp/uRO8pzuDph3RlGiu+ +s1Pn81hqJEEHKZDzeJqQAS/LG0a1CFrQA0HNv2WQ/yzunnxC2xNmraGkmUqzYS6mrub V5BQ== X-Gm-Message-State: AOJu0YySDAywG0aII84XArBgoOnGlOu41UdN93m17GJxqtWEma9JTDcZ 54fyT0suHjmnbBOZbLS6o1jr588qLMjF1R9RLHw= X-Google-Smtp-Source: AGHT+IF9Rf4pDf552C/av6hlxhLXW0HaBcBCIWkhb6zWPcvKE3SNEwmGaDpiBQhzXDjYELvyUobe6mo89A4YdzfEcpA= X-Received: by 2002:ac2:47e2:0:b0:509:39e3:5268 with SMTP id b2-20020ac247e2000000b0050939e35268mr9069333lfp.59.1701183743420; Tue, 28 Nov 2023 07:02:23 -0800 (PST) In-Reply-To: <00b85d5b-7878-4099-ab44-8200e153885d@gutov.dev> Received-SPF: pass client-ip=2a00:1450:4864:20::12f; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313324 Archived-At: On Tue, Nov 28, 2023 at 12:45=E2=80=AFPM Dmitry Gutov wr= ote: > That's a good practice, and it works (and mitigates the issues) until we > need to change the underlying function, for some reasons or other. In > that sense, having the expansion use private functions (with "--" in the > name) doesn't do much because those cannot be safely renamed, extended, > etc. Unlike when they're called by a public function. Sorry, that completely unspecified and vague scenario is irrelevant in both theory and practice. Why would you need to rename them? They're internal functions: noone else but you needs to know or care about them. This technique doesn't suffer from any other problem a function interface wouldn't have as well. Can't tell why you're trying to poke holes in such a well known and widely used Lisp technique, but I must be off.