From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el" Date: Wed, 7 Dec 2022 19:09:05 +0000 Message-ID: References: <167007345844.23701.8454474119701440468@vcs2.savannah.gnu.org> <20221203131739.2A601C004BA@vcs2.savannah.gnu.org> <83r0xb48sm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000002367e505ef41a80c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9877"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 07 20:10:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2zoG-0002Lx-L8 for ged-emacs-devel@m.gmane-mx.org; Wed, 07 Dec 2022 20:10:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2znK-00055a-Pf; Wed, 07 Dec 2022 14:09:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2znJ-00054d-M3 for emacs-devel@gnu.org; Wed, 07 Dec 2022 14:09:25 -0500 Original-Received: from mail-ot1-x334.google.com ([2607:f8b0:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2znE-0001Nt-U4; Wed, 07 Dec 2022 14:09:25 -0500 Original-Received: by mail-ot1-x334.google.com with SMTP id t19-20020a9d7753000000b0066d77a3d474so11879647otl.10; Wed, 07 Dec 2022 11:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XOpTpkgxENzreqhuqea58WkifDcnx51daLRT3itHENA=; b=SDzfEUi/FnCiQi74DDuzlcEn8vK3Vawk6CVR29wW5bNGlp8Qo9oTg+GyRM8VgSffTA 5zZjVWgb7PBx/M74cdYxyKmR3HthYwWQnVMBhJDdao5LwRxyhatWPouBjKb+Xg7ITimv gPqMyOuSuwq9S2vs7OAcDk8McrSh895FC2AEdJdSDcEuUE2CHNXnQQKZscu0bHdBt7Rx tnAgC1cSYPt2X0YFAPBZfzujg11+gyg35iIps2QQbBwluTRaDP+yp5ZDyFeHjWdaXPga gfzU0YL7eYhgE4EemyNqe4EeMdMGp6+Vui2aPvndCLNMyKhII9qMyIm1HN1fE4CXXGm/ 8mnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XOpTpkgxENzreqhuqea58WkifDcnx51daLRT3itHENA=; b=BpF9UsIRIl8OVHCZKFzNw8JLjkYQxnjCpG7rGoceY6cMLwx4NLhW6IcN+syFr5E9+G vEH9OhCa77ojvtSZDGhzYTV6iNDaGGZY9zxptO8/avkK99usUKJBDyJjsmTvzY7d70Xo yIgIaD6nOfZ4VFd2zAgXUtq3mSZsblhbhKxSXy31Oaivbhk+4BaryYdnjy9oJq2NmB2R WVcocgpEccJ118LSOu8J0SJfwDQCXEc7KMUzB1Z5438OQiMJdxNL9xSbhZ8AcFdpCbxY ilNhqnKHwzPzKd9GCKNX/DzHFqMhdrWlOUwu5WAWLGnOM4aYb15D+++A6IJCiw8dziNH GTFA== X-Gm-Message-State: ANoB5pmrVeBz8VcTze1EAW78unA6iZQnjvzpanBHa3pZg6wXTMVlDGXe 2KQYqHR6r3/Ks5Y4+EyfyGGuPB3tIiEyCDrdNwDv77r8 X-Google-Smtp-Source: AA0mqf5cE715rFXDqIphtzOALMBE+p1khJOaNUNot+NQPISLAPTZon7ucYStx0Q/zZDZuHTfztVEmhBUPdSNlu8YvVU= X-Received: by 2002:a9d:832:0:b0:670:5283:dd3e with SMTP id 47-20020a9d0832000000b006705283dd3emr5634206oty.201.1670440156356; Wed, 07 Dec 2022 11:09:16 -0800 (PST) In-Reply-To: <83r0xb48sm.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::334; envelope-from=joaotavora@gmail.com; helo=mail-ot1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301025 Archived-At: --0000000000002367e505ef41a80c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 7, 2022 at 1:56 PM Eli Zaretskii wrote: > > Let me know what you think. The commentary of the new file, the > docstring > > of external-completion-table and the commit messages should give detail= s. > > I'll be happy to fix them further if you have comments. > > I'm fine with installing this on the emacs-29 branch, but I think > external-completion.el warrants a NEWS entry. > Okay. I added a NEWS entry and pushed to emacs-29. Jo=C3=A3o --0000000000002367e505ef41a80c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Dec 7, 2022 at 1:56 PM Eli Zarets= kii <eliz@gnu.org> wrote:
=C2=A0
> Let me know what you think.=C2=A0 The commentary = of the new file, the docstring
> of external-completion-table and the commit messages should give detai= ls.
> I'll be happy to fix them further if you have comments.

I'm fine with installing this on the emacs-29 branch, but I think
external-completion.el warrants a NEWS entry.

Okay.=C2=A0 I added a NEWS entry = and pushed to emacs-29.

Jo=C3=A3o
--0000000000002367e505ef41a80c--