From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Dedicated window for *log-edit-files* Date: Fri, 25 Oct 2019 16:36:45 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000810bb30595bdebce" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="246873"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 25 17:37:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iO1eJ-0011zQ-FM for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 17:37:11 +0200 Original-Received: from localhost ([::1]:33920 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO1eH-000355-D8 for ged-emacs-devel@m.gmane.org; Fri, 25 Oct 2019 11:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58171) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iO1e6-0002w9-9Y for emacs-devel@gnu.org; Fri, 25 Oct 2019 11:36:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iO1e5-0006n3-4D for emacs-devel@gnu.org; Fri, 25 Oct 2019 11:36:58 -0400 Original-Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]:40778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iO1e5-0006mv-00 for emacs-devel@gnu.org; Fri, 25 Oct 2019 11:36:57 -0400 Original-Received: by mail-il1-x12f.google.com with SMTP id d83so2210502ilk.7 for ; Fri, 25 Oct 2019 08:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/CoDlt7Q4Eu79c4VJ5nbUrCO2dcb7xd7pWpGWxi4HE0=; b=qKv/MpizEm4/8mcj4NqUF2xll4+E/RDofs7JRV2zUwwb2A9KRXZ7Sl43jv1hiqm5PW OnCvZxtJuZQtzIwy2CmooCu4rwHY31SCOVt18K8MxAh9vPqT5GvezymfO8xXzdwL6U4S bUoUxSMxOlgu6WA9f2kfSypK9zDWKnwmOJZnwQoMHF/iQfaozsL0b6y6jl2n81nh0ZEq fXCrfrcvwUtJRCucp2DICiya7AlVi2IDtTfT8qHOfsyCU1mhmRWg5Sm9U9DZjl0fztY0 tTDvI2j8WvuFRY8gQ6ihjuVEdXcErWGv/UxNj1u0I5cHurg7L9AC8iNzdRw5xxmC3u1v VQwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/CoDlt7Q4Eu79c4VJ5nbUrCO2dcb7xd7pWpGWxi4HE0=; b=YsYu0KHV9vajUrJ0NKJD/ZmVJb7YPB4iXmJTOOfelr+/5+jc9eF4YzOD/rP+Th1Iaw P5zsDWE0rrf8K+t0jnkGJvnO7GA1vyiJTz9JWXNCrpabJxi3ApPZ/B+bezOAZYECHouL zVdZgsv8STrN/yyn+21zUXt1+K4h8tHxpEfpk9FJ5cu50tdY92IXWIhEEYhO2Q3hrpLJ ZDw43/hcTFBRQLDadK/M3+mrYK85jfFRX617Jhwj9i644EB82hniuV+kL5beJ+Qvfn01 tgotclJzl0UF7vZRWdxH4816pWi0SqcP1lwpMpEHYjX+ETwPM1K6ZENLSYsYUBls26QS 8dtw== X-Gm-Message-State: APjAAAXVBg8v541iYKNfb1kBpqbBlwvj6OjmjnCyP4VdWEP3lZseFK7x Wn54vNx5P1dq2nR03r7y9VOIwz0H66s+WgJGv5E= X-Google-Smtp-Source: APXvYqxSpvOSACdgE8w/EZhI7wDao9nQJ4uveO6WpHYt2YMQTGgIz7aIlqxJ7YcbDE2QkVnS5n3/UUQqNdiCjC/DGoQ= X-Received: by 2002:a92:9f1c:: with SMTP id u28mr4553078ili.97.1572017816010; Fri, 25 Oct 2019 08:36:56 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::12f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241420 Archived-At: --000000000000810bb30595bdebce Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 25, 2019 at 1:48 PM Stefan Monnier wrote: > Remove `log-edit-show-files` from `log-edit-hook`. Oh, that works perfectly! Thanks. > [ Yes, non-nil default values for non-preloaded hooks are evil. > I confess to doing it, but I plead insanity. ] Why evil? How else would you arrange to have this default behaviour? Not that I agree with this particular one: I think log-edit-show-files does more harm than good, and should be out of the default value (maybe mentioned in the docstring). But that's another discussion. Jo=C3=A3o --000000000000810bb30595bdebce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 25, 2019 at 1:48 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote= :

> Remove `log-edit-show-files` from `log-edit-hook`.
=

Oh, that works perfectly! Thanks.

> [ Yes, non-nil default values for non-preloaded hooks are evil.
=
> =C2=A0 I confess to doing it, but I plead insanity. =C2=A0]
=

Why evil? How else would you arrange to have this
<= /div>
default behaviour?

Not that I agree with= this particular one: I think
log-edit-show-files does more = harm than good,
and should be out of the default value (mayb= e
mentioned in the docstring). But that's another
<= div>discussion.

Jo=C3=A3o
--000000000000810bb30595bdebce--