unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Dedicated window for *log-edit-files*
Date: Fri, 25 Oct 2019 16:36:45 +0100	[thread overview]
Message-ID: <CALDnm51q-f4hsS91YM2YEKyxkYqSHLw1FTOAcbft0w7ew+Ofbw@mail.gmail.com> (raw)
In-Reply-To: <jwvd0elgfoj.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

On Fri, Oct 25, 2019 at 1:48 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:

> Remove `log-edit-show-files` from `log-edit-hook`.

Oh, that works perfectly! Thanks.

> [ Yes, non-nil default values for non-preloaded hooks are evil.
>   I confess to doing it, but I plead insanity.  ]

Why evil? How else would you arrange to have this
default behaviour?

Not that I agree with this particular one: I think
log-edit-show-files does more harm than good,
and should be out of the default value (maybe
mentioned in the docstring). But that's another
discussion.

João

[-- Attachment #2: Type: text/html, Size: 855 bytes --]

  reply	other threads:[~2019-10-25 15:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 11:48 Dedicated window for *log-edit-files* João Távora
2019-10-25 12:48 ` Stefan Monnier
2019-10-25 15:36   ` João Távora [this message]
2019-10-25 15:50     ` Stefan Monnier
2019-10-25 21:38       ` João Távora
2019-10-25 23:51         ` Stefan Monnier
2019-10-29 21:37     ` Juri Linkov
2019-10-25 14:43 ` Drew Adams
2019-10-25 15:21   ` João Távora
2019-10-26  8:12 ` martin rudalics
2019-10-26 12:00   ` Stefan Monnier
2019-10-27  7:49     ` martin rudalics
2019-10-27 17:43       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm51q-f4hsS91YM2YEKyxkYqSHLw1FTOAcbft0w7ew+Ofbw@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).