From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Distinguishing `consp` and `functionp`
Date: Tue, 30 Jan 2024 22:24:39 +0000 [thread overview]
Message-ID: <CALDnm51hJoJ3DamcHgh7Soutp4OWU2XxL+LoSKFVP_Hr2E-GUw@mail.gmail.com> (raw)
In-Reply-To: <jwvr0hzat34.fsf-monnier+emacs@gnu.org>
On Tue, Jan 30, 2024 at 12:54 PM Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
> Yup. My impression is that this is sufficiently rare that we can afford
> to break it. Maybe experience will show me wrong, of course.
I've definitely seen users post configs to Eglot's bug tracker where
lambdas appear incorrectly quoted. i.e.
(add-to-list 'eglot-server-programs '(foo-mode . (lambda (..) ...)))
I try to always correct them, but sometimes it'll just silently work until it
doesn't.
> We could also consider an intermediate step where `functionp` returns
> t but emits a warning.
Indeed, though in that case I'd make the funcall warn. I think it's there
that this proposed runtime warning ultimately matters and is useful
to help users correct their elisp. Runtime warnings are a bit icky though
:-| but better than nothing.
> - it can give a wrong impression to a beginner, encouraging confusion.
> - it can occasionally hide an error, making debugging a bit more difficult.
Wouldn't you add "complicates type propagation, static analysis and
optimization" to that list?
> These seem very marginal to me.
I've definitely seen this error happen more than once:
(defun call-with-oopsie (fn) (funcall fn))
(defmacro with-oopsie (_nil &rest body)
;; usually some much more complicated hairy expansion
`(call-with-oopsie '(lambda () ,@body)))
(defvar x 42)
(with-oopsie () (+ 42 x)) ;; 84, everything's fine, my macro is great
(let ((y 42)) (with-oopsie () (+ 42 y))) ;; oopsie...
The warning would have made the first call work but signal
something is off.
João
next prev parent reply other threads:[~2024-01-30 22:24 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 23:15 Distinguishing `consp` and `functionp` Stefan Monnier
2024-01-26 0:00 ` Adam Porter
2024-01-26 0:24 ` Stefan Monnier
2024-01-26 7:31 ` Eli Zaretskii
2024-01-26 19:22 ` João Távora
2024-01-26 21:13 ` Stefan Monnier
2024-01-26 21:50 ` João Távora
2024-01-26 23:55 ` Stefan Monnier
2024-01-27 0:22 ` Daniel Mendler via Emacs development discussions.
2024-01-27 11:47 ` João Távora
2024-01-27 13:20 ` Po Lu
2024-01-27 11:53 ` João Távora
2024-01-28 3:03 ` Richard Stallman
2024-01-28 21:27 ` Stefan Monnier
2024-01-29 12:45 ` Eli Zaretskii
2024-01-29 15:19 ` Stefan Monnier
2024-01-29 15:31 ` Eli Zaretskii
2024-01-29 15:41 ` Stefan Monnier
2024-01-29 15:46 ` Eli Zaretskii
2024-01-29 15:48 ` Stefan Monnier
2024-01-29 15:54 ` João Távora
2024-01-29 16:10 ` Eli Zaretskii
2024-01-29 16:25 ` João Távora
2024-01-29 16:10 ` Eli Zaretskii
2024-01-29 16:17 ` Andreas Schwab
2024-01-29 16:34 ` João Távora
2024-02-01 3:49 ` Richard Stallman
2024-01-29 16:28 ` Stefan Monnier
2024-01-29 16:34 ` João Távora
2024-01-29 20:00 ` Stefan Monnier
2024-01-30 8:58 ` João Távora
2024-01-30 12:54 ` Stefan Monnier
2024-01-30 22:24 ` João Távora [this message]
2024-01-30 23:13 ` Stefan Monnier
2024-01-30 23:43 ` João Távora
2024-01-31 0:22 ` Stefan Monnier
2024-01-31 0:40 ` João Távora
2024-01-31 3:37 ` Stefan Monnier
2024-01-31 10:51 ` João Távora
2024-01-31 18:34 ` Stefan Monnier
2024-02-01 3:49 ` Richard Stallman
2024-01-29 17:09 ` Yuri Khan
2024-02-01 3:49 ` Richard Stallman
2024-01-30 3:58 ` Richard Stallman
2024-01-27 11:00 ` Alan Mackenzie
2024-01-27 14:25 ` Stefan Monnier
2024-01-27 23:01 ` Alan Mackenzie
2024-01-28 0:00 ` Stefan Monnier
2024-01-28 6:12 ` Eli Zaretskii
2024-01-28 17:26 ` Alan Mackenzie
2024-01-28 17:48 ` Eli Zaretskii
2024-01-28 19:42 ` Alan Mackenzie
2024-01-28 20:08 ` Eli Zaretskii
2024-01-28 18:21 ` Stefan Monnier
2024-01-28 18:38 ` Stefan Monnier
2024-01-27 13:14 ` Po Lu
2024-01-27 14:41 ` Stefan Monnier
2024-01-28 1:56 ` Po Lu
2024-01-28 20:55 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm51hJoJ3DamcHgh7Soutp4OWU2XxL+LoSKFVP_Hr2E-GUw@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).