unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Stephen Leake <stephen_leake@stephe-leake.org>,
	emacs-devel <emacs-devel@gnu.org>,
	Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name
Date: Thu, 24 Nov 2022 14:43:57 +0000	[thread overview]
Message-ID: <CALDnm51du96D68s-YB_=1HAmSMXkN9y8vBeHmaaci4hTpurFgA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

Stephen,

In this commit:

commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7
Author: Stephen Leake <stephen_leake@stephe-leake.org>
Date:   Tue Nov 22 11:43:22 2022 -0800

    * lisp/progmodes/eglot.el (eglot--connect): Use project-name

    As discussed in bug#48747.

You use an fboundp check for the project-name function recently
added to project.el.

This is not necessary in eglot.el, since it already depends on the
project.el :core ELPA package.  eglot.el is itself such a package.
So you must merely bump the "Version:" of the project.el package in
that file and then make eglot.el reference the new version in its
"Package-Requires:".

Of course you should/could ask permission before bumping
project.el's version (or not, depends on Dmitry's policy)

This way we can avoid those pesky checks. I'll change the commit
to use package-name directly now.

João

PS: When about to apply a patch to eglot.el, even one where I
have already approved the underlying idea, I would appreciate
it if you could just shoot me a personal mail showing the full
contents of the patch.

[-- Attachment #2: Type: text/html, Size: 1542 bytes --]

             reply	other threads:[~2022-11-24 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 14:43 João Távora [this message]
2022-11-24 21:30 ` [SPAM UNSURE] Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name Stephen Leake
2022-11-24 21:35 ` Dmitry Gutov
2022-11-25  9:28   ` João Távora
2022-11-25 15:14     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm51du96D68s-YB_=1HAmSMXkN9y8vBeHmaaci4hTpurFgA@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=stephen_leake@stephe-leake.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).