From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 2 Jun 2021 08:53:05 +0100 Message-ID: References: <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1b73a130-204c-76fb-2b60-02b814aee0f0@daniel-mendler.de> <87r1hl8xom.fsf@gmail.com> <878s3t8tzw.fsf@gmail.com> <3c68bd00-70ca-fa18-f9b8-cd03029f9294@daniel-mendler.de> <8735u18lsd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28765"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Daniel Mendler , Juri Linkov , "emacs-devel@gnu.org" , Dmitry Gutov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 09:54:19 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loLhj-0007HN-0g for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 09:54:19 +0200 Original-Received: from localhost ([::1]:51820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loLhi-0001xz-0N for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 03:54:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loLgn-0001HF-1G for emacs-devel@gnu.org; Wed, 02 Jun 2021 03:53:21 -0400 Original-Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:39462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loLgl-00064B-DD for emacs-devel@gnu.org; Wed, 02 Jun 2021 03:53:20 -0400 Original-Received: by mail-pg1-x534.google.com with SMTP id v14so1562011pgi.6 for ; Wed, 02 Jun 2021 00:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=QJhIr/wcVmhilPq0+JSrT/+EwiHCDQJeyxEq5+9upZE=; b=IMALFWS0xFQIYWBrfEyj/BI4C1qsCfRZiJTAgFeP49p/TYlNgd+zkLcIQqNlCVf6ii 5oNEgFUiDcC7AQE/CzroHmyjXHxs4efTsufsz6KDl6uDaktdMUPSXlEGUM1PWstsQVQw 5iaVUNGggtQaud65wL2I3/rk8Hnj1H1TbKk3Gxb7nZlSQBFhKZHQ3pSlxFE8MUdb8qaG CHtapPU7HMTINHtrDPmqhhlewm29t+5N2mNdD85JE31vdA3qIVC0GkwRVN3MKMTsn+4q kMBf98Qmjts5N9y2qsyAty1djH2CbFuCWECrY7CQp/c3Zh1up6SQOqyfcoh9Q+v1kMKe D4xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=QJhIr/wcVmhilPq0+JSrT/+EwiHCDQJeyxEq5+9upZE=; b=bOqTbqVEYxAn9OZKSZ6cDyLW/5B/5seN/nPw3NCEiGnoxgTAFJxcg/huCiBhR6EnX0 DJj5y5oYAhB+9r9vMxKFNbKkvfIB/Qk9tbeLozkl01YmwWdnNeBCfhnt18kfWwxYCTQo 05hXgRVtWZUxzswWec4ivW46anQLgPftf8fgNGom9jOkpYGezepkFOSie8kLofmdyAjM NTyXGYHY6E+/hEo6PdfP8obeOE+b/4H/wzpEbFZEpJicdgnJDxa8+l++wW3SROouzhb2 +R69EboXqzZloameETIN39rlYkeigKYGAiushCF9JXwuPevBL2aWg4RB3DUE9XU6KXES iQgA== X-Gm-Message-State: AOAM530/KrsNHg2vJbPWwQxvSKvEZDr042VQeKMF844cNX+LuXErPXMI +iy6naIX4+kSNTCpGtDkX0Zh4KYXnt2JspvQxD0= X-Google-Smtp-Source: ABdhPJxSjcIGAsscGN7x+PM7LuBJHwG+T8IRjYmHM8sz4IocCKW6g4ZqT5OM0Z6tQdZ1QzXJ+yO/NULT6U0aSWAxM2w= X-Received: by 2002:aa7:8c02:0:b029:2e9:c513:1e10 with SMTP id c2-20020aa78c020000b02902e9c5131e10mr4491486pfd.2.1622620397950; Wed, 02 Jun 2021 00:53:17 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=joaotavora@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270271 Archived-At: On Wed, Jun 2, 2021 at 3:40 AM Stefan Monnier wr= ote: > These are judgment calls, i.e. aesthetic dislikes. > The long discussion we've had about ti shows that there's a lot of > disagreeing tastes around this topic, so I'm pretty sure we won't find > one that satisfies everyone. I admit I don't know how long or painful the discussion was for all of you, but so far the only argument against doing what I suggest is performance, and it seems weak according to my measurements (which are the only ones I've seen). So I miss how ideas for less code and stabler return type of an API call fall into bikeshedding territory. Those would be more struct vs deflcass vs list vs propertized string for me, for example. But even there, might not be bikeshedding, it depends on the intentions. > I highly doubt changing the API for `group-function` would make any > measurable difference in this respect since it's a pretty small part of > "the complicated minibuffer.el". They make a difference in the part I was trying to touch. Jo=C3=A3o