From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode Date: Thu, 4 Jul 2019 19:45:26 +0100 Message-ID: References: <20190702131632.GA30597@ACM> <20190702160410.GB30597@ACM> <20190702182811.GC30597@ACM> <20190703105804.GA11238@ACM> <20190704165846.GF5564@ACM> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000594442058cdf6262" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="124816"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 04 20:48:38 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hj6mc-000WNn-Er for ged-emacs-devel@m.gmane.org; Thu, 04 Jul 2019 20:48:38 +0200 Original-Received: from localhost ([::1]:48194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj6mV-0006IS-Db for ged-emacs-devel@m.gmane.org; Thu, 04 Jul 2019 14:48:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33782) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj6jo-0006IH-Ob for emacs-devel@gnu.org; Thu, 04 Jul 2019 14:45:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hj6jl-0000ZJ-VD for emacs-devel@gnu.org; Thu, 04 Jul 2019 14:45:43 -0400 Original-Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]:42579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hj6jl-0000XL-FM for emacs-devel@gnu.org; Thu, 04 Jul 2019 14:45:41 -0400 Original-Received: by mail-io1-xd36.google.com with SMTP id u19so14459200ior.9 for ; Thu, 04 Jul 2019 11:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l6m0GYxn1YQ2YUw1moEwP1Wn3SSTQnnLYINCWrn5LYY=; b=Re/Xw99MfRo00snKSw72nECMZvV+XfwgLLkEQ27jsW4XTIgLOeJsgcIMBFBamtR9F9 47Vs8pVN/qGKE6B89vsM4Nh9jCsp2WrqZ7nezWZ+XQWOszpX1FnxoVH3+nJtJ9wCJnHS urK6udi/e4CtCdgAIX+dqhMZKos+uPmhDZwNb4samthwDWPB3r2deHTrucVy8QfCtmDU VcSkAhv4My4+kYoCIQ58a4Kh5/ElexX04EPhgBK06subbTmNjLl7zgTce+EG+4+IX5fF Zd8O7Ri+4sd6ygujx9o76nDFlPUDfIJuULo/agdHYqSZT+mnrKOsziqfTxcGnhBpwMbS DEgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l6m0GYxn1YQ2YUw1moEwP1Wn3SSTQnnLYINCWrn5LYY=; b=NqH43p3iH8Zu5a3VR3I5x+R2hlnMqGJ59Ff4O8nGvQOI5A8lo2VBeIBRbi569DYPiP U0kFi3kkft84/WCNcpQyGxZIS/ZmLQdCzri9cFe4JUpsZOF8oM2UNw4TC3RDln4VKptH SxewTecddbYXZqtgfiXa2Kxntc1FhP33K0e2i+/iae4Cgirr1BcGiHCYeDVI756WH+TV 6hqaEdqHvI7MyXRiybwNn9BfMRKPZVqZB3NLg9MQmpCoHFgBfR9LcFUhDjp3fLD5hGXo sywSXTHQbBv/qawAcpM8yKtzSJMWPcVyAjjsJA1p6iPeRZEb7V1TN5eXuwiHxjFLSG1q b00A== X-Gm-Message-State: APjAAAV+bFEAFK4jVYCV5WEZ5qjcOfPxrBh9l05u9CWCn73ETrPeaC8b YvnTAm5AFt1ekTan1mL3B4qAivtuqOogdlJO3QIbFeif X-Google-Smtp-Source: APXvYqxhQvrZxcPIstXQka7l8DDeKYa7CQ0EJdS3Q/KT8fqk4IhchL1b129C6Nx+aqoF4rxWBQiFgJpde6YoI+FeXUY= X-Received: by 2002:a02:69d1:: with SMTP id e200mr6770816jac.138.1562265939164; Thu, 04 Jul 2019 11:45:39 -0700 (PDT) In-Reply-To: <20190704165846.GF5564@ACM> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238358 Archived-At: --000000000000594442058cdf6262 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 03, 2019 at 14:31:58 +0100, Jo=C3=A3o T=C3=A1vora wrote: > [ .... ] > > > If [you] don't agree, find a small enough solution that fixes e-p-m, > > propose it here, then find a consensus that overrides my opinion, it > > happens all the time, won't hold it against you or anyone else, good > > luck. > > Here is the entire part of the fix needed for bug #36474, that should go > into elec-pair-mode.el: I'll have a look, but please show the whole change, not just the new function. A new function by itself has no effect in e-p-m or any other part of emacs. You should show where you intend to use it (it should, in principle, be in one of e-p-m's external-facing variables). Thanks, Jo=C3=A3o --000000000000594442058cdf6262 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 03, 2019 at 14:31:58 +0100, Jo=C3=A3o T=C3=A1v= ora wrote:
[ .... ]

> If [you] don't agree, find a small enough solution that fixes e-p-= m,
> propose it here,=C2=A0 then find a consensus that overrides my opinion= , it
> happens all the time, won't hold it against you or anyone else, go= od
> luck.

Here is the entire part of the fix needed for bug #36474, that should go into elec-pair-mode.el:

I'll have a loo= k, but please show the whole change, not just
the new functi= on. A new function by itself has no effect in e-p-m or
any other = part of emacs. You should show where you intend to use it
(i= t should, in principle, be in one of e-p-m's external-facing variables)= .

Thanks,
Jo=C3=A3o

--000000000000594442058cdf6262--