From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: scratch/backend-completion 1af23aade6f: More tweaks to external-completion.el after Stefan's comments Date: Sun, 4 Dec 2022 09:45:45 +0000 Message-ID: References: <167011058506.11167.15396713347917244845@vcs2.savannah.gnu.org> <20221203233625.5BBB0C00B0F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000003023805eefd70b1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 04 10:46:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1la7-00050j-H1 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Dec 2022 10:46:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1lZR-00030i-LR; Sun, 04 Dec 2022 04:46:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1lZQ-00030Q-0w for emacs-devel@gnu.org; Sun, 04 Dec 2022 04:46:00 -0500 Original-Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1lZO-0003hf-9x for emacs-devel@gnu.org; Sun, 04 Dec 2022 04:45:59 -0500 Original-Received: by mail-oi1-x232.google.com with SMTP id v70so1552271oie.3 for ; Sun, 04 Dec 2022 01:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6nEEF3Qd0DCFv5OWsueNfSQhPP6gqnS3dgPPBOm+Zac=; b=mjN/qNzA+NW8xfNEJ9ir8V2TSjQ9Mafab/UBb2U4+SoLFj4pvZmn4s1Y6YBNhz94ew 2bel9CGa+Ttr7Kr6rAC1NB00RqColkBWHPxBp+OZZBVgUt80zzHery/hLFwasRspGacH M5VxJNt6Ysv2L1IgMicHXkQ/Lzx4krfp5323/pIU7WCXbvmacY/9uVczHSeOqNX3Z6pB BOhW4vM57W2CjXA4wnajesKRyKAEgt+jq2o+RvYsp3DWX8zQo4xtyOw9uQjqagg2/waL JVmkbSD29kfJjYHqUSUjkIh0yU2zEfiT0UPvfROYBhRJt/7z8tTiIKm7pezQyrdVqykW 3pnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6nEEF3Qd0DCFv5OWsueNfSQhPP6gqnS3dgPPBOm+Zac=; b=HGSjhNfgY4EAgAOBMLsNVBgL+rd2T5VvU5lZZ6ymRU3WpxhW8WnV0SvQSWuuHoDkxk JOaITeElOxhxuAhefML6OYwrHd3o2mcDD1UPiOx90eQQTQ+vpUyBTfaahtQmQ4gKzGDf 8Md4W1nefoaKARbAcSQ7MEaNjN9Rl4rCTCFJEMunCycrXSaEuV5HwT4kBOwBtWej7CSv mGe8nB8p7BcXH75fstVG0Jj/pWo7/82AphzzkizCDVtzgl3LD4dEE+GUy9F+g7kDwlrD qUU+JEi8IVnyF35NnyOXHNySrZfIpVk65pyFW3S5Mi1nFLBzEfX2dcIchW0Na3QKPnSV VdKg== X-Gm-Message-State: ANoB5pkNKibXMgrYYAO7osbeFt9yGwie5Kfh6TafHeJ6KNqJveWJW8Is P+jDCmgdiIFqjZ9/8gpeBCXvoEEbnglrb6Xnuz84hlJL X-Google-Smtp-Source: AA0mqf5gooL6AQRUCEaG4GXcsTP4SS9gV32vX4C6cooNQ+yVlgdTLIwaYYoDczxKVZKhD5G6wXdsht5C5jAnddYUOsI= X-Received: by 2002:aca:ac44:0:b0:35c:2ddf:59d5 with SMTP id v65-20020acaac44000000b0035c2ddf59d5mr495361oie.215.1670147156933; Sun, 04 Dec 2022 01:45:56 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::232; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x232.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300897 Archived-At: --00000000000003023805eefd70b1 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 4, 2022, 04:23 Stefan Monnier wrote: > > +Despite the original authors's best efforts, > > +TRY-COMPLETION-FUNCTION is still a poorly understood > > +implementation detail. If you understand what it's for, you > > FWIW, I'm not really the original author of try-completion. > More specifically, the `try-completion` function itself predates my > involvement with Emacs, and its generalization in > `partial-completion-mode` as well. I do take responsability for > `completion-try-completion`, admittedly, where I tried to give an > "official" interface to that operation, but I was just trying to > preserve existing semantics. Thanks for the insight. But I meant the original author of this function, of course. I don't have a gripe with try-completion. I'm sure it's doing useful stuff. I just don't know what to write in this docstring for it to teach the caller how to use the argument effectively. Please help me, it's the last thing that needs to be done, i think. And of course I'll squash all this silly history afterwards, this is just a scratch branch. > > --00000000000003023805eefd70b1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Dec 4, 2022, 04:23 Stefan Monnier <monnier@iro.umontreal.ca> wrote= :
> +Despite the original author= s's best efforts,
> +TRY-COMPLETION-FUNCTION is still a poorly understood
> +implementation detail.=C2=A0 If you understand what it's for, you=

FWIW, I'm not really the original author of try-completion.
More specifically, the `try-completion` function itself predates my
involvement with Emacs, and its generalization in
`partial-completion-mode` as well.=C2=A0 I do take responsability for
`completion-try-completion`, admittedly, where I tried to give an
"official" interface to that operation, but I was just trying to<= br> preserve existing semantics.

=

Thanks for the insight.= But I meant the original author of this function, of course. I don't h= ave a gripe with try-completion. I'm sure it's doing useful stuff. = I just don't know what to write in this docstring for it to teach the c= aller how to use the argument effectively.=C2=A0 Please help me, it's t= he last thing that needs to be done, i think.

And of course I'll squash all this silly history = afterwards, this is just a scratch branch.
=C2=A0
--00000000000003023805eefd70b1--