From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Indentation of def* Date: Sun, 24 Oct 2021 16:19:54 +0100 Message-ID: References: <878ryw1ptl.fsf@gnus.org> <87czo2lq0d.fsf@gnus.org> <87v91s876d.fsf@gnus.org> <87ee8gnlar.fsf@gnus.org> <87bl3ea76o.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9769"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Richard Stallman , emacs-devel To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 24 17:22:37 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mefKX-0002Jk-Eh for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Oct 2021 17:22:37 +0200 Original-Received: from localhost ([::1]:44906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mefKV-0007EJ-L1 for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Oct 2021 11:22:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35004) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mefIB-0005Uy-0t for emacs-devel@gnu.org; Sun, 24 Oct 2021 11:20:11 -0400 Original-Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]:33521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mefI8-0004RN-T5; Sun, 24 Oct 2021 11:20:10 -0400 Original-Received: by mail-pg1-x536.google.com with SMTP id r28so4053574pga.0; Sun, 24 Oct 2021 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pPxkOQ/HDLBB/UgsW3L7oI1VCB9l9U1xmwtU6F0zZpE=; b=TV/85bgIOIEUZHb2Ebds54+XvNOTadx7p2DJNeXJCPPaNScZcW4t2sJPSQXoVffdbb UlmloHuTFmL+djEPerve77BvICJo9qOem2u/xwSKApOKBA5lw2szb8ZGxWa/FCpnDhyK pMYAL/tXmICvlQ2jOyMEtlQPkJfndKyZGtqqBWkrzniGPWeWeF7/x8tCMssuLEI6H8Ir w4Q46dXHG9rrfG+QQOHRcOpyzJ4h8Mu0aZOOCjPwmOv/LGyAFxgM/sNAYb+mYlPi+5Xa AtFQNTv4FTjxhmF5XOl4nYhs70mJXaKw+5eMZrH/eziIlkYFP8AP+0Q29ZduSJtdYGBb xCVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pPxkOQ/HDLBB/UgsW3L7oI1VCB9l9U1xmwtU6F0zZpE=; b=imWs6qyXjqNBn/0dUzwV5ayJxJiAIXfm44ZJKh0Say1iX0NVBxgsfZDzdgoQRTNqBQ kMnw5FLhYfq0ceT2FArnkuWwNFwjP7ZpA0JsfQ1Dwc1xNytqQOjaGngjsGcLuMCm9doC JnXLDVYiTKSxXkf3mzhKo+TX10mvcqEVA6XxkE7HQjyQ7NRSnMiQ5ohBCXk0LKWbsIP3 geueP0Qyy7aLqH6C2htdTMU+8xiSWCofDK50R+KB76i8vlY70+PVAIxUtsT3aXUyZpHT 5XbDbiZ5qlBz/sz+W8F3TB526ofqBynXZLOwtYx5eib+99TVG87utWLzTiO8RARcO+N0 tIHQ== X-Gm-Message-State: AOAM532lkD2mjswnQ/PkKgCTFQZagZZnPU3eby4YMhAH0xyQBEWQKOqi cd4jpKpF1w3jZUu4MDFKsT6fP1ECQYM5qUyWlkg= X-Google-Smtp-Source: ABdhPJybXfNBqErtjzPQu5FG1dyhzOWwjbyPG2P5GuYw2JtiVjaTaPAEsnuHDDNTduXqvZEr+XjMAg8SG2K0kMuF7iY= X-Received: by 2002:a05:6a00:15d3:b0:44d:f85a:4c3a with SMTP id o19-20020a056a0015d300b0044df85a4c3amr12946344pfu.72.1635088805857; Sun, 24 Oct 2021 08:20:05 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=joaotavora@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277660 Archived-At: On Sun, Oct 24, 2021 at 3:27 PM Stefan Kangas wrot= e: > > Lars Ingebrigtsen writes: > > > The introduction of the `with-*' macros, added three decades ago withou= t > > any such heuristic, shows that these heuristics aren't necessary (or > > useful). > > And, again, the correct fix for this is to explicitly say what you want > with an indent declaration. Unlike a heuristic, this will have no false > positives - the user decides. If there was NO code in the wild that didn't rely on this heuristic, I could agree to that. But it is an undeniable fact that we do, and that code's indentation will be broken. So, instead of killing the heuristic altogether, why shouldn't we adjust it so that it has less false positives? In fact I think if we tweak the heuristic to only apply to macro definitions it will probably have zero false positives. Unless I'm mistaken there are NO macros whose name starts 'def' for which we DON'T want to indent their uses like a `defun`. Yes, that action will still bring some false negatives, i.e. the indentation of SOME code in the wild will still be broken. But "some" is better than "a lot of" in my book, so I'm completely the rationale for NOT doing this less intrusive fix is completely lost on me. Jo=C3=A3o